From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: <thor.thayer@linux.intel.com>, <bp@alien8.de>,
<james.morse@arm.com>, <rric@kernel.org>, <morbidrsa@gmail.com>,
<ralf@linux-mips.org>, <david.daney@cavium.com>,
<andy.gross@linaro.org>, <david.brown@linaro.org>,
<ckadabi@codeaurora.org>, <vnkgutta@codeaurora.org>,
<jglauber@cavium.com>, <khuong@os.amperecomputing.com>,
<dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mips@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [UNVERIFIED SENDER] Re: [RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce()
Date: Sun, 28 Jul 2019 12:34:35 +0300 [thread overview]
Message-ID: <355dc172-52f5-3d9c-883a-4ad1fd10d54c@amazon.com> (raw)
In-Reply-To: <20190725153658.084ea1aa@coco.lan>
On 7/25/2019 9:36 PM, Mauro Carvalho Chehab wrote:
>> /* Propagate the count up the 'totals' tree */
>> - instance->counters.ue_count++;
>> - edac_dev->counters.ue_count++;
>> + instance->counters.ue_count += error_count;
>> + edac_dev->counters.ue_count += error_count;
> Patch itself looks a good idea, but maybe it should rise a WARN()
> if error_count == 0.
Good point, shouldn't we use WARN_ONCE here? if the user call
edac_device_handle_ue() with error count == 0, it not be change in
run-time, only if the error count parameter is calculated somehow, and
it'll be the *caller* issue that didn't check the error count.
What you think?
>
> That applies for both CE and UE error logic.
Sure.
Thanks,
Hanna
>
> Thanks,
> Mauro
next prev parent reply other threads:[~2019-07-28 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 10:53 [RFC 1/1] edac: Add a counter parameter for edac_device_handle_ue/ce() Hanna Hawa
2019-07-17 12:06 ` Jan Glauber
2019-07-17 14:45 ` Hawa, Hanna
2019-07-25 18:36 ` Mauro Carvalho Chehab
2019-07-28 9:34 ` Hawa, Hanna [this message]
2019-08-01 11:35 ` Robert Richter
2019-08-01 12:29 ` Hawa, Hanna
2019-08-01 14:17 ` Robert Richter
2019-08-01 14:30 ` Hawa, Hanna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355dc172-52f5-3d9c-883a-4ad1fd10d54c@amazon.com \
--to=hhhawa@amazon.com \
--cc=andy.gross@linaro.org \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=ckadabi@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=david.daney@cavium.com \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=james.morse@arm.com \
--cc=jglauber@cavium.com \
--cc=jonnyc@amazon.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=morbidrsa@gmail.com \
--cc=ralf@linux-mips.org \
--cc=ronenk@amazon.com \
--cc=rric@kernel.org \
--cc=talel@amazon.com \
--cc=thor.thayer@linux.intel.com \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).