From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D73C43381 for ; Mon, 11 Mar 2019 20:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49C142087C for ; Mon, 11 Mar 2019 20:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729330AbfCKT6P (ORCPT ); Mon, 11 Mar 2019 15:58:15 -0400 Received: from mleia.com ([178.79.152.223]:48070 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729294AbfCKT6O (ORCPT ); Mon, 11 Mar 2019 15:58:14 -0400 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id A4090457CBF; Mon, 11 Mar 2019 19:58:11 +0000 (GMT) Subject: Re: [PATCH 18/42] drivers: gpio: lpc18xx: use devm_platform_ioremap_resource() To: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, andrew@aj.id.au, f.fainelli@gmail.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, hoan@os.amperecomputing.com, orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, keguang.zhang@gmail.com, matthias.bgg@gmail.com, thierry.reding@gmail.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, robert.jarzmik@free.fr, yamada.masahiro@socionext.com, jun.nie@linaro.org, shawnguo@kernel.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org, linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org References: <1552330521-4276-1-git-send-email-info@metux.net> <1552330521-4276-18-git-send-email-info@metux.net> From: Vladimir Zapolskiy Message-ID: <3a36e19b-05ef-2c0d-ce86-9422d6748b0c@mleia.com> Date: Mon, 11 Mar 2019 21:58:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1552330521-4276-18-git-send-email-info@metux.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20190311_195811_744851_E739B33D X-CRM114-Status: GOOD ( 14.69 ) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 03/11/2019 08:54 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/gpio/gpio-lpc18xx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c > index d441dba..d711ae0 100644 > --- a/drivers/gpio/gpio-lpc18xx.c > +++ b/drivers/gpio/gpio-lpc18xx.c > @@ -340,10 +340,7 @@ static int lpc18xx_gpio_probe(struct platform_device *pdev) > index = of_property_match_string(dev->of_node, "reg-names", "gpio"); > if (index < 0) { > /* To support backward compatibility take the first resource */ > - struct resource *res; > - > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - gc->base = devm_ioremap_resource(dev, res); > + gc->base = devm_platform_ioremap_resource(pdev, 0); > } else { > struct resource res; > > Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir