linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: agriveaux@deutnet.info
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paul.burton@mips.com>,
	James Hogan <jhogan@kernel.org>,
	linux-mips <linux-mips@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding
Date: Mon, 6 Jul 2020 13:15:04 +0200	[thread overview]
Message-ID: <457C75ED-A033-4B46-A9D9-53B510C16F37@goldelico.com> (raw)
In-Reply-To: <20200705103215.96672-1-agriveaux@deutnet.info>

Hi Alexandre,

> Am 05.07.2020 um 12:32 schrieb agriveaux@deutnet.info:
> 
> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> 
> Use brcm,bcm4329-fmac instead of brcm,bcm4330-fmac.
> 
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index 75f5bfbf2c37..82a1f126b778 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -116,8 +116,8 @@
> 	pinctrl-0 = <&pins_mmc1>;
> 
> 	brcmf: wifi@1 {
> -/*		reg = <4>;*/
> -		compatible = "brcm,bcm4330-fmac";
> +		reg = <1>;
> +		compatible = "brcm,bcm4329-fmac";
> 		vcc-supply = <&wlan0_power>;
> 		device-wakeup-gpios = <&gpd 9 GPIO_ACTIVE_HIGH>;
> 		shutdown-gpios = <&gpf 7 GPIO_ACTIVE_LOW>;

Do you have it working with a v5.8 kernel?

I don't see any activity to detect the module or load firmware.

Does it rely on some other patch?

BR and thanks,
Nikolaus


  reply	other threads:[~2020-07-06 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 10:32 [PATCH] MIPS: CI20: DTS: Correcting IW8103 Wifi binding agriveaux
2020-07-06 11:15 ` H. Nikolaus Schaller [this message]
2020-07-06 20:22   ` Alexandre GRIVEAUX
2020-07-11 20:24     ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457C75ED-A033-4B46-A9D9-53B510C16F37@goldelico.com \
    --to=hns@goldelico.com \
    --cc=agriveaux@deutnet.info \
    --cc=devicetree@vger.kernel.org \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=paul.burton@mips.com \
    --cc=ralf@linux-mips.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).