linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Rob Herring <robh+dt@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
	Paul Burton <paulburton@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>,
	Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 19/19] auxdisplay: ht16k33: Add LED support
Date: Tue, 27 Jul 2021 14:05:05 -0700	[thread overview]
Message-ID: <5b70f272-eec9-0ff7-1bd2-bf1659b10e9c@infradead.org> (raw)
In-Reply-To: <20210727140459.3767788-20-geert@linux-m68k.org>

On 7/27/21 7:04 AM, Geert Uytterhoeven wrote:
> Instantiate a single LED based on the "led" subnode in DT.
> This allows the user to control display brightness and blinking (backed
> by hardware support) through the LED class API and triggers, and exposes
> the display color.  The LED will be named
> "auxdisplay:<color>:<function>".
> 
> When running in dot-matrix mode and if no "led" subnode is found, the
> driver falls back to the traditional backlight mode, to preserve
> backwards compatibility.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v4:
>   - Add missing select LEDS_CLASS,
> 
> v3:
>   - Remove unneeded C++ comment,
>   - Use "err" instead of "error" to be consistent with existing driver
>     naming style,
>   - Make the creation of the LED device dependent on the presence of the
>     "led" subnode in DT, so it can be used in dot-matrix mode too.
>   - Use led_init_data() and devm_led_classdev_register_ext() to retrieve
>     all LED properties from DT, instead of manual LED name construction
>     based on just the "color" property,
> 
> v2:
>   - Use "auxdisplay" instead of DRIVER_NAME in LED name.

Hi Geert,

Since LEDS_CLASS depends on NEW_LEDS, does this also need to
select NEW_LEDS?

and similar for INPUT_MATRIXKMAP: it depends on INPUT.

However, selecting (enabling) an entire subsystem is not a
preferable thing to do.

> ---
>  drivers/auxdisplay/Kconfig   |   1 +
>  drivers/auxdisplay/ht16k33.c | 124 ++++++++++++++++++++++++++++++-----
>  2 files changed, 108 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 42fc7b155de09dbc..7436b9a4edbe5450 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -176,6 +176,7 @@ config HT16K33
>  	select FB_SYS_IMAGEBLIT
>  	select INPUT_MATRIXKMAP
>  	select FB_BACKLIGHT
> +	select LEDS_CLASS
>  	select LINEDISP
>  	help
>  	  Say yes here to add support for Holtek HT16K33, RAM mapping 16*8

thanks.
-- 
~Randy


  reply	other threads:[~2021-07-27 21:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 14:04 [PATCH v4 00/19] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 01/19] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 02/19] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-08-02 20:40   ` Rob Herring
2021-07-27 14:04 ` [PATCH v4 03/19] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 04/19] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 05/19] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 06/19] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 07/19] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 08/19] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 09/19] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 10/19] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 11/19] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 12/19] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 13/19] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 14/19] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 15/19] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 16/19] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 17/19] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 18/19] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-07-27 14:04 ` [PATCH v4 19/19] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-07-27 21:05   ` Randy Dunlap [this message]
2021-07-28  7:39     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b70f272-eec9-0ff7-1bd2-bf1659b10e9c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).