From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57874C5DF60 for ; Thu, 7 Nov 2019 09:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A01621D7B for ; Thu, 7 Nov 2019 09:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbfKGJ10 (ORCPT ); Thu, 7 Nov 2019 04:27:26 -0500 Received: from mail.loongson.cn ([114.242.206.163]:58143 "EHLO mail.loongson.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGJ10 (ORCPT ); Thu, 7 Nov 2019 04:27:26 -0500 Received: from [10.20.41.27] (unknown [10.20.41.27]) by mail (Coremail) with SMTP id QMiowPBxc+h248NdE1wAAA--.26S3; Thu, 07 Nov 2019 17:27:18 +0800 (CST) Subject: Re: [PATCH] MIPS: Scan the DMI system information References: <5959f904-5c46-30a7-7a4f-17f692aca320@loongson.cn> To: Jiaxun Yang , Paul Burton , Ralf Baechle , James Hogan , Jean Delvare , Huacai Chen Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Yinglu Yang , Xuefeng Li From: Tiezhu Yang X-Forwarded-Message-Id: <5959f904-5c46-30a7-7a4f-17f692aca320@loongson.cn> Message-ID: <5c042bd8-40ad-e84f-588d-f3ee56f7216d@loongson.cn> Date: Thu, 7 Nov 2019 17:26:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5959f904-5c46-30a7-7a4f-17f692aca320@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: QMiowPBxc+h248NdE1wAAA--.26S3 X-Coremail-Antispam: 1UD129KBjvJXoWxKF18JrW3XFy8Ww1Uur4xCrg_yoWxJFyUpF y8Ja1rKF48Xr17GF1Sq343Wr9Iyrs5tFZ0gFy7tF17u3s8Zw17AFs3KayUCFy8Ar1DJFy0 9a40gFW3uFs8CaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBa14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF 04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2js IEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUqeHgUUUUU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Sorry to resend this email because the mail list server was denied due to it is not plain text. On 11/07/2019 11:42 AM, Jiaxun Yang wrote: > 于 2019年11月7日 GMT+08:00 上午10:42:23, Tiezhu Yang 写到: >> On 11/07/2019 08:35 AM, Jiaxun Yang wrote: >>> 于 2019年11月7日 GMT+08:00 上午12:05:41, Tiezhu Yang >> 写到: >>>> Enable DMI scanning on the MIPS architecture, this setups DMI >>>> identifiers >>>> (dmi_system_id) for printing it out on task dumps and prepares DIMM >>>> entry >>>> information (dmi_memdev_info) from the SMBIOS table. With this >> patch, >>>> the >>>> driver can easily match various of mainboards. >>>> >>>> In the SMBIOS reference specification, the table anchor string >> "_SM_" >>>> is >>>> present in the address range 0xF0000 to 0xFFFFF on a 16-byte >> boundary, >>>> but there exists a special case for loongson platform, when call >>>> function >>>> dmi_early_remap, it should specify the start address to 0xFFFE000 >> due >>>> to >>>> it is reserved for SMBIOS and can be normally access in the BIOS. >>>> >>>> Co-developed-by: Yinglu Yang >>>> Signed-off-by: Yinglu Yang >>>> Signed-off-by: Tiezhu Yang >>>> --- >>>> arch/mips/Kconfig | 12 ++++++++++++ >>>> arch/mips/include/asm/dmi.h | 43 >>>> +++++++++++++++++++++++++++++++++++++++++++ >>>> arch/mips/kernel/setup.c | 2 ++ >>>> 3 files changed, 57 insertions(+) >>>> create mode 100644 arch/mips/include/asm/dmi.h >>>> >>>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig >>>> index 7cb8947..0a67b18 100644 >>>> --- a/arch/mips/Kconfig >>>> +++ b/arch/mips/Kconfig >>>> @@ -2757,6 +2757,18 @@ config HW_PERF_EVENTS >>>> Enable hardware performance counter support for perf events. If >>>> disabled, perf events will use software events only. >>>> >>>> +# Mark as expert because too many people got it wrong. >>>> +# The code disables itself when not needed. >>>> +config DMI >>>> + default y >>>> + select DMI_SCAN_MACHINE_NON_EFI_FALLBACK >>>> + bool "Enable DMI scanning" if EXPERT >>>> + help >>>> + Enabled scanning of DMI to identify machine quirks. Say Y >>>> + here unless you have verified that your setup is not >>>> + affected by entries in the DMI blacklist. Required by PNP >>>> + BIOS code. >>>> + >>>> config SMP >>>> bool "Multi-Processing support" >>>> depends on SYS_SUPPORTS_SMP >>>> diff --git a/arch/mips/include/asm/dmi.h >> b/arch/mips/include/asm/dmi.h >>>> new file mode 100644 >>>> index 0000000..1f3da37 >>>> --- /dev/null >>>> +++ b/arch/mips/include/asm/dmi.h >>>> @@ -0,0 +1,43 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>> +#ifndef _ASM_MIPS_DMI_H >>>> +#define _ASM_MIPS_DMI_H >>>> + >>>> +#define dmi_early_remap mips_early_memremap >>>> +#define dmi_early_unmap mips_early_memunmap >>>> +#define dmi_remap(_x, _l) mips_memremap(_x, _l, MEMREMAP_WB) >>>> +#define dmi_unmap(_x) mips_memunmap(_x) >>>> + >>>> +#define dmi_alloc(l) memblock_alloc_low(l, PAGE_SIZE) >>>> + >>>> +void __init *mips_early_memremap(resource_size_t phys_addr, >> unsigned >>>> long size) >>>> +{ >>>> +#if defined(CONFIG_MACH_LOONGSON64) >>>> + if (phys_addr == 0xF0000) >>>> + phys_addr = 0xFFFE000; >>>> + >>>> + return (void *)TO_CAC(phys_addr); >>>> +#else >>>> + return NULL; >>>> +#endif >>>> +} >>> Hi Tiezhu, >>> >>> It is really tricky to hijack dmi address here during remap. >>> I think we should set the dmi table address at dmi_scan.c by a marco >> or something else rather than hijack it during remap. >> >> Hi Jiaxun, >> >> Thanks for your review. I agree with you, let me think about it and try >> to >> find a proper way, and then I will send a v2 patch. Hi Jiaxun, It seems that there is no absolutely better way to handle this case. 1. use conditional compilation in drivers/firmware/dmi_scan.c: #if defined(CONFIG_MACH_LOONGSON64) p = dmi_early_remap(0xFFFE000, 0x10000); #else p = dmi_early_remap(0xF0000, 0x10000); #endif This will influence the common code. 2. use callback function in arch/mips/include/asm/dmi.h: struct plat_dmi_ops { void (*early_memremap)(void); void (*memremap)(void); }; extern struct plat_dmi_ops *dmi_ops; void __init *mips_early_memremap(resource_size_t phys_addr, unsigned long size) { dmi_ops->early_memremap(); } void *mips_memremap(resource_size_t offset, size_t size, unsigned long flags) { dmi_ops->memremap(); } we can implement the callback function in various of MIPS platforms, like this: struct plat_dmi_ops loongson3_dmi_ops = { .early_memremap = loongson3_early_memremap, .memremap = loongson3_memremap, }; register_dmi_ops(&loongson3_dmi_ops); #ifdef CONFIG_DMI void __init *loongson3_early_memremap(resource_size_t phys_addr, unsigned long size) { if (phys_addr == 0xF0000) phys_addr = 0xfffe000; return (void *)TO_CAC(phys_addr); } void *loongson3_memremap(resource_size_t offset, size_t size, unsigned long flags) { return (void *)TO_CAC(phys_addr); } #else void __init __iomem *loongson3_early_memremap(u64 phys_addr, unsigned long size) { return NULL; } void __init __iomem *loongson3_memremap(u64 phys_addr, unsigned long size) { return NULL; } #endif This will not influence the common code. What do you think? Hi Jean, Could you give some suggestions? >>> Btw: Probably we should set DMI default y when MACH_LOONGSON64 is >> set? >> >> CONFIG_DMI is set to y by default, I think there is no need to select >> DMI when >> set CONFIG_MACH_LOONGSON64. > Sorry, I meant only default to y when MACH_LOONGSON64 is set or even depends on MACH_LOONGSON64. As Loongson is the only known MIPS platform that supports DMI. Default y unconditionally may lead to regression on other MIPS platforms. OK, I prefer to select DMI when set MACH_LOONGSON64 instead of DMI depends on MACH_LOONGSON64, I will modify the Kconfig file. Thanks, Tiezhu Yang >> Thanks, >> >> Tiezhu Yang >> >>> Thanks. >>>