linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	"Keguang Zhang" <keguang.zhang@gmail.com>,
	"John Crispin" <john@phrozen.org>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] MIPS: replace add_memory_region with memblock
Date: Fri, 9 Oct 2020 11:00:36 +0800	[thread overview]
Message-ID: <631aa35e-2575-3ec0-ec0f-7d45e49b8373@flygoat.com> (raw)
In-Reply-To: <20201008152006.4khkbzsxqmmz76rw@mobilestation>



在 2020/10/8 23:20, Serge Semin 写道:

[...]
>
>> -		add_memory_region(LOONGSON_HIGHMEM_START,
>> -				  highmemsize << 20, BOOT_MEM_RAM);
>> -
>> -	add_memory_region(LOONGSON_PCI_MEM_END + 1, LOONGSON_HIGHMEM_START -
>> -			  LOONGSON_PCI_MEM_END - 1, BOOT_MEM_RESERVED);
>> -
>> +		memblock_add(LOONGSON_HIGHMEM_START, highmemsize << 20);
> The same question. Is it ok to discard the
> [LOONGSON_PCI_MEM_END+1:LOONGSON_HIGHMEM_START-LOONGSON_PCI_MEM_END-1] region
> removal operation?
Hi all,

I can confirm this reservation can be removed.
It was used to ensure HIGHMEM won't overlap PCI MMIO region when
firmware was unreliable.
But I do think we shouldn't care this case as an unreliable firmware 
shouldn't
ship with any devices for end users.

Also it won't affect display of /proc/iomem, now we're on age of 
DeviceTree :-)

Thanks.

- Jiaxun

>
> -Sergey
>
>>   #endif /* !CONFIG_64BIT */
>>   }
>>   

  parent reply	other threads:[~2020-10-09  3:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08  8:43 [PATCH v2] MIPS: replace add_memory_region with memblock Thomas Bogendoerfer
2020-10-08 15:20 ` Serge Semin
2020-10-08 15:30   ` Maciej W. Rozycki
2020-10-08 15:54     ` Serge Semin
2020-10-08 16:49       ` Florian Fainelli
2020-10-08 21:20         ` Serge Semin
2020-10-08 16:56       ` Maciej W. Rozycki
2020-10-08 22:51         ` Serge Semin
2020-10-09  3:00   ` Jiaxun Yang [this message]
2020-10-09 12:09     ` Thomas Bogendoerfer
2020-10-09 12:07   ` Thomas Bogendoerfer
2020-10-09 14:15     ` Serge Semin
2020-10-12 10:01       ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=631aa35e-2575-3ec0-ec0f-7d45e49b8373@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=fancer.lancer@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).