From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A71B2C5DF64 for ; Wed, 6 Nov 2019 16:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CB2C21882 for ; Wed, 6 Nov 2019 16:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="aZjOEKuw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732175AbfKFQj6 (ORCPT ); Wed, 6 Nov 2019 11:39:58 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38671 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732169AbfKFQj6 (ORCPT ); Wed, 6 Nov 2019 11:39:58 -0500 Received: by mail-pl1-f194.google.com with SMTP id w8so11681576plq.5 for ; Wed, 06 Nov 2019 08:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=aZjOEKuwvk4LUjS0Pg/iyqv8fUwr+4Eqr4VNsOuYqjPBPirNxvv5KtXr/6+DvhEEeS fmtm+BfBI6Fgt3CeqBDIV/tP+8GstwQh0JsjJ3sYRdaIk0GLhOwMvca5Ymb8nyz5sCB8 bhaQzrbAb+6CErGpjDhkRIjrO5rlEPsDprWki5Fb2Mum/9MbX9Jf95N6JsliyllKSJVI Il7Rovp8XoqxkTcJcmJjRSncQE73tk/DeDoYM/TjrvEBhtbrtNoyTrcJLbJRh7+3wUG2 FTBbSr+lLJZwiQA0K1a6KQpZqVbUp7Vc8DofHhprXygu6WGOo7KWvqM7uY4vVgFlF9/9 qKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=mYjqsgXNOZV87YXz6Y69j8QpwHNRsYSL6oZsFQRFjf1FN7O33op8i4Rp698tapl8aX 3lWMF+nqflU5OBCYykk1KOXnVMSS1paZrQlOpNnt1+0zB7h/WwmfjwaZ6pky41C8R0bA 9hgj1FH2eIs1Rn6VcseJ5yHL8leSDkJPuPKYjNmO05Lc5gcUSWxGES/Pc0D/PSayp+Rc /gobhEHSyNYaM6E/ZEIaXMmZlhtKqD8Z2XUt4Jy4+EGHGO9EXXzzTUkUYz0Z3z6LyiY3 we5z0NwVw5SL06XZJJXgkdpZurIijl4SeVgnWBthYojpj0kiUjfoTrSB3ASZoletE/bE 1Ztg== X-Gm-Message-State: APjAAAXWt+ZSaMh2plny+GV49EiUeQO+pv8z8yTNl1bUmjNnTTp4av3T cW3djmpZ2/ykTLj6Ffm+JKzklQ== X-Google-Smtp-Source: APXvYqywfR9UQlZvtVaHdkOoCsd877Kid/BBKE9QMojVPiD4B1uPWPELoLK/DLKCNhVOxuK2oHgGlQ== X-Received: by 2002:a17:902:8647:: with SMTP id y7mr2024671plt.285.1573058397431; Wed, 06 Nov 2019 08:39:57 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id y26sm13229647pfo.76.2019.11.06.08.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2019 08:39:56 -0800 (PST) Subject: Re: [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() To: Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Albert Ou , Ben Segall , Dietmar Eggemann , Greentime Hu , Ingo Molnar , James Hogan , Juri Lelli , Mel Gorman , Michal Simek , Palmer Dabbelt , Paul Burton , Paul Walmsley , Peter Zijlstra , Ralf Baechle , Thomas Gleixner , Vincent Chen , Vincent Guittot , Will Deacon , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-2-dima@arista.com> <20191106043851.GA131976@google.com> From: Dmitry Safonov Message-ID: <65ef777b-ceb0-09d7-6fb0-fb79328ad87d@arista.com> Date: Wed, 6 Nov 2019 16:39:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191106043851.GA131976@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Sergey, On 11/6/19 4:38 AM, Sergey Senozhatsky wrote: > On (19/11/06 03:04), Dmitry Safonov wrote: > [..] >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index dd05a378631a..774ff0d8dfe9 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -3858,7 +3858,7 @@ static noinline void __schedule_bug(struct task_struct *prev) >> if (IS_ENABLED(CONFIG_DEBUG_PREEMPT) >> && in_atomic_preempt_off()) { >> pr_err("Preemption disabled at:"); >> - print_ip_sym(preempt_disable_ip); >> + print_ip_sym(KERN_ERR, preempt_disable_ip); >> pr_cont("\n"); > > Is this working with pr_cont()? print_ip_sym() will cause log_store().. And pr_cont("\n") will go here: : /* Skip empty continuation lines that couldn't be added - they just flush */ : if (!text_len && (lflags & LOG_CONT)) : return 0; So it doesn't do anything. I didn't want to change any behavior in the patch, but seems that I can remove this pr_cont() while at here. Thanks, Dmitry