From: Yunsheng Lin <linyunsheng@huawei.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <mingo@redhat.com>,
<bp@alien8.de>, <rth@twiddle.net>, <ink@jurassic.park.msu.ru>,
<mattst88@gmail.com>, <benh@kernel.crashing.org>,
<paulus@samba.org>, <mpe@ellerman.id.au>,
<heiko.carstens@de.ibm.com>, <gor@linux.ibm.com>,
<borntraeger@de.ibm.com>, <ysato@users.sourceforge.jp>,
<dalias@libc.org>, <davem@davemloft.net>, <ralf@linux-mips.org>,
<paul.burton@mips.com>, <jhogan@kernel.org>,
<jiaxun.yang@flygoat.com>, <chenhc@lemote.com>,
<akpm@linux-foundation.org>, <anshuman.khandual@arm.com>,
<tglx@linutronix.de>, <cai@lca.pw>, <robin.murphy@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>, <x86@kernel.org>,
<dave.hansen@linux.intel.com>, <luto@kernel.org>,
<peterz@infradead.org>, <len.brown@intel.com>, <axboe@kernel.dk>,
<dledford@redhat.com>, <jeffrey.t.kirsher@intel.com>,
<linux-alpha@vger.kernel.org>, <naveen.n.rao@linux.vnet.ibm.com>,
<mwb@linux.vnet.ibm.com>, <linuxppc-dev@lists.ozlabs.org>,
<linux-s390@vger.kernel.org>, <linux-sh@vger.kernel.org>,
<sparclinux@vger.kernel.org>, <tbogendoerfer@suse.de>,
<linux-mips@vger.kernel.org>, <rafael@kernel.org>,
<mhocko@kernel.org>, <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 7/8] mips: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for mips
Date: Sun, 15 Sep 2019 14:51:49 +0800 [thread overview]
Message-ID: <67673e73-168b-976f-83e2-11edc7e412ee@huawei.com> (raw)
In-Reply-To: <20190915064647.GD11429@linux.ibm.com>
On 2019/9/15 14:46, Mike Rapoport wrote:
> On Sun, Sep 15, 2019 at 02:13:51PM +0800, Yunsheng Lin wrote:
>> On 2019/9/15 13:49, Mike Rapoport wrote:
>>> Hi,
>>>
>>> On Thu, Sep 12, 2019 at 06:15:33PM +0800, Yunsheng Lin wrote:
>>>> When passing the return value of dev_to_node() to cpumask_of_node()
>>>> without checking the node id if the node id is NUMA_NO_NODE, there is
>>>> global-out-of-bounds detected by KASAN.
>>>>
>>>> From the discussion [1], NUMA_NO_NODE really means no node affinity,
>>>> which also means all cpus should be usable. So the cpumask_of_node()
>>>> should always return all cpus online when user passes the node id
>>>> as NUMA_NO_NODE, just like similar semantic that page allocator handles
>>>> NUMA_NO_NODE.
>>>>
>>>> But we cannot really copy the page allocator logic. Simply because the
>>>> page allocator doesn't enforce the near node affinity. It just picks it
>>>> up as a preferred node but then it is free to fallback to any other numa
>>>> node. This is not the case here and node_to_cpumask_map will only restrict
>>>> to the particular node's cpus which would have really non deterministic
>>>> behavior depending on where the code is executed. So in fact we really
>>>> want to return cpu_online_mask for NUMA_NO_NODE.
>>>>
>>>> Since this arch was already NUMA_NO_NODE aware, this patch only changes
>>>> it to return cpu_online_mask and use NUMA_NO_NODE instead of "-1".
>>>>
>>>> [1] https://lore.kernel.org/patchwork/patch/1125789/
>>>> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>>>> Suggested-by: Michal Hocko <mhocko@kernel.org>
>>>> ---
>>>> V3: Change to only handle NUMA_NO_NODE, and return cpu_online_mask
>>>> for NUMA_NO_NODE case, and change the commit log to better justify
>>>> the change.
>>>> ---
>>>> arch/mips/include/asm/mach-ip27/topology.h | 4 ++--
>>>
>>> Nit: the subject says "mips:", but this patch only touches sgi-ip27 and
>>> loongson is updated as a separate patch. I don't see why both patches
>>> cannot be merged. Moreover, the whole set can be made as a single patch,
>>> IMHO.
>>
>> Thanks for reviewing.
>>
>> As this patchset touches a few files, which may has different maintainer.
>> I am not sure if a separate patch for different arch will make the merging
>> process easy, or a single patch will make the merging process easy?
>
> The set makes the same logical change to several definitions of
> cpumask_of_node(). It's appropriate to have all these changes in a single
> patch.
Ok, thanks.
Will have all these changes in a single patch.
>
>> It can be made as a single patch if a single patch will make the merging
>> process easy.
>>
>>>
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/mips/include/asm/mach-ip27/topology.h b/arch/mips/include/asm/mach-ip27/topology.h
>>>> index 965f079..04505e6 100644
>>>> --- a/arch/mips/include/asm/mach-ip27/topology.h
>>>> +++ b/arch/mips/include/asm/mach-ip27/topology.h
>>>> @@ -15,8 +15,8 @@ struct cpuinfo_ip27 {
>>>> extern struct cpuinfo_ip27 sn_cpu_info[NR_CPUS];
>>>>
>>>> #define cpu_to_node(cpu) (sn_cpu_info[(cpu)].p_nodeid)
>>>> -#define cpumask_of_node(node) ((node) == -1 ? \
>>>> - cpu_all_mask : \
>>>> +#define cpumask_of_node(node) ((node) == NUMA_NO_NODE ? \
>>>> + cpu_online_mask : \
>>>> &hub_data(node)->h_cpus)
>>>> struct pci_bus;
>>>> extern int pcibus_to_node(struct pci_bus *);
>>>> --
>>>> 2.8.1
>>>>
>>>
>>
>
next prev parent reply other threads:[~2019-09-15 6:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 10:15 [PATCH v3 0/8] make node_to_cpumask_map() NUMA_NO_NODE aware Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 1/8] arm64: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for arm64 Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 2/8] x86: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for x86 Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 3/8] alpha: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for alpha Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 4/8] powerpc: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for powerpc Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 5/8] s390: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for s390 Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 6/8] sparc64: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for sparc64 Yunsheng Lin
2019-09-12 10:15 ` [PATCH v3 7/8] mips: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for mips Yunsheng Lin
2019-09-15 5:49 ` Mike Rapoport
2019-09-15 6:13 ` Yunsheng Lin
2019-09-15 6:46 ` Mike Rapoport
2019-09-15 6:51 ` Yunsheng Lin [this message]
2019-09-12 10:15 ` [PATCH v3 8/8] mips: numa: make node_to_cpumask_map() NUMA_NO_NODE aware for loongson64 Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67673e73-168b-976f-83e2-11edc7e412ee@huawei.com \
--to=linyunsheng@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=chenhc@lemote.com \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=len.brown@intel.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mattst88@gmail.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mwb@linux.vnet.ibm.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.ibm.com \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).