From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 31 Jan 2017 16:30:05 +0100 (CET) Received: from outils.crapouillou.net ([89.234.176.41]:37398 "EHLO outils.crapouillou.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993893AbdAaP37Gx0Ao (ORCPT ); Tue, 31 Jan 2017 16:29:59 +0100 To: Linus Walleij Subject: Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 31 Jan 2017 16:29:58 +0100 From: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Ulf Hansson , Boris Brezillon , Thierry Reding , Bartlomiej Zolnierkiewicz , Maarten ter Huurne , Lars-Peter Clausen , Paul Burton , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux MIPS , linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, James Hogan In-Reply-To: References: <27071da2f01d48141e8ac3dfaa13255d@mail.crapouillou.net> <20170125185207.23902-1-paul@crapouillou.net> <20170125185207.23902-5-paul@crapouillou.net> Message-ID: <699f0c63e95ecdafe6946fdcdbb97a37@mail.crapouillou.net> X-Sender: paul@crapouillou.net Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 56550 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul@crapouillou.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Le 2017-01-31 15:20, Linus Walleij a écrit : >> + of_property_read_u32(dev->of_node, "base", &jzgc->gc.base); > > Remove this. Dynamic allocation should be fine, if you're using the > new userspace ABI like tools/gpio/* or libgpiod and only that and > in-kernel > consumers, dynamic numbers are just fine. The problem is that the QI_LB60 board code still have a lot of references to global GPIO numbers. Just grep for JZ_GPIO_PORT in arch/mips/jz4740/board-qi_lb60.c to see what I mean... -Paul