From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CEEC4332F for ; Fri, 4 Nov 2022 08:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230098AbiKDIDi (ORCPT ); Fri, 4 Nov 2022 04:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbiKDIDg (ORCPT ); Fri, 4 Nov 2022 04:03:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E294B2656B for ; Fri, 4 Nov 2022 01:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667548959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJu1Z+r/Jj1Q22H/Z28kMZfifRbtSqoNatlqDbaYr8M=; b=MQhZGzB+MjleKW2tWxurDMtuktfyHT95T+ODfSjucIPFc97wjdNSECCZtjzKTWn02bL6Oi q+3B7r2WF8cCKtAoBLdyuwe6JzNLtjr6jyVDYMVvNb+Vczla52KsneSPDYMWDlLzya9wsR auRpq+JurG2JjhD92rtwOOJjkzTFz/M= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-562-Eyzri-0jPByLRQ7wlwMzdw-1; Fri, 04 Nov 2022 04:02:36 -0400 X-MC-Unique: Eyzri-0jPByLRQ7wlwMzdw-1 Received: by mail-ed1-f72.google.com with SMTP id b13-20020a056402350d00b00464175c3f1eso2988338edd.11 for ; Fri, 04 Nov 2022 01:02:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QJu1Z+r/Jj1Q22H/Z28kMZfifRbtSqoNatlqDbaYr8M=; b=jJhqiIKULzstuJUYFkGc1IQtQYKWqqHxgxgVZNRSGqG0fAFOus6B49nDUbaiWDv50C shT5nKt6wRMmMVQqligJT8xYsAry8IFXtu/9Mf5xxJg6/xL+xtd46VQ/tkhEBjBlktvw 9onoquBxpAicb4lr35hblqbVA5TAr1SNxRHxTU2Uh559O4FmvJRypnsVdTlfNe3RQ45w NGgPzWeIW3A9JipAmcnb+XIF6ArhtIa0jHf8igLBJWwQ+KftxstxS+jK5wGcLlNry4Du zi89Ky6hOBiIQoACcvBn9qnfynw5RV9qPk47kC/m68D1sP/wkOWabM/PAMdEs+W6QhI2 MZPQ== X-Gm-Message-State: ACrzQf20mHd2/Ko/8ktqlgsje1JsXNKT/LCx0/sC+X8ZDmxk+D6a4i/1 SENNV6KIgkFYFwFtotH6E33yzPeV4xhwEz1A+1g47osb2L8tscXPL8RCnbFUcdIEzbERdvlxsA4 ToHLn4deW7ICHsAVbKDZr7g== X-Received: by 2002:a17:907:1dda:b0:7a6:8ffc:7dc with SMTP id og26-20020a1709071dda00b007a68ffc07dcmr33677017ejc.163.1667548955857; Fri, 04 Nov 2022 01:02:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ZNqKb/aQP9ibAQb8G5uHFxFpKasjpH84kkwoGMwJiLbxjg9Lh2wolUrwViafofx0ss1frxA== X-Received: by 2002:a17:907:1dda:b0:7a6:8ffc:7dc with SMTP id og26-20020a1709071dda00b007a68ffc07dcmr33676971ejc.163.1667548955613; Fri, 04 Nov 2022 01:02:35 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:4783:a68:c1ee:15c5? ([2001:b07:6468:f312:4783:a68:c1ee:15c5]) by smtp.googlemail.com with ESMTPSA id tz14-20020a170907c78e00b0078ddb518a90sm1433630ejc.223.2022.11.04.01.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 01:02:34 -0700 (PDT) Message-ID: <6c71fcca-c17f-5979-e15e-afcf08899064@redhat.com> Date: Fri, 4 Nov 2022 09:02:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 33/44] KVM: x86: Do VMX/SVM support checks directly in vendor code Content-Language: en-US To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Fabiano Rosas , Michael Ellerman , Chao Gao , Thomas Gleixner , Yuan Yao References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-34-seanjc@google.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 11/3/22 19:58, Sean Christopherson wrote: > > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 3e508f239098..ebe617ab0b37 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -191,6 +191,8 @@ static void default_init(struct cpuinfo_x86 *c) > strcpy(c->x86_model_id, "386"); > } > #endif > + > + clear_cpu_cap(c, X86_FEATURE_MSR_IA32_FEAT_CTL); > } > > static const struct cpu_dev default_cpu = { Not needed I think? default_init does not call init_ia32_feat_ctl. > diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid-deps.c > index c881bcafba7d..3a7ae67f5a5e 100644 > --- a/arch/x86/kernel/cpu/cpuid-deps.c > +++ b/arch/x86/kernel/cpu/cpuid-deps.c > @@ -72,6 +72,8 @@ static const struct cpuid_dep cpuid_deps[] = { > { X86_FEATURE_AVX512_FP16, X86_FEATURE_AVX512BW }, > { X86_FEATURE_ENQCMD, X86_FEATURE_XSAVES }, > { X86_FEATURE_PER_THREAD_MBA, X86_FEATURE_MBA }, > + { X86_FEATURE_VMX, X86_FEATURE_MSR_IA32_FEAT_CTL }, > + { X86_FEATURE_SGX, X86_FEATURE_MSR_IA32_FEAT_CTL }, > { X86_FEATURE_SGX_LC, X86_FEATURE_SGX }, > { X86_FEATURE_SGX1, X86_FEATURE_SGX }, > { X86_FEATURE_SGX2, X86_FEATURE_SGX1 }, > Yes, good idea. Paolo