linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: auxdisplay: img-ascii-lcd: Convert to json-schema
@ 2021-07-27 16:10 Geert Uytterhoeven
  2021-08-02 20:52 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-07-27 16:10 UTC (permalink / raw)
  To: Rob Herring, Paul Burton, Miguel Ojeda
  Cc: devicetree, linux-mips, linux-kernel, Geert Uytterhoeven

Convert the Device Tree binding documentation for ASCII LCD displays on
Imagination Technologies boards to json-schema.

Drop bogus regmap property.
Add example.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 .../bindings/auxdisplay/img,ascii-lcd.yaml    | 54 +++++++++++++++++++
 .../bindings/auxdisplay/img-ascii-lcd.txt     | 17 ------
 MAINTAINERS                                   |  2 +-
 3 files changed, 55 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
 delete mode 100644 Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt

diff --git a/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml b/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
new file mode 100644
index 0000000000000000..66e54f12f40f2f78
--- /dev/null
+++ b/Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/auxdisplay/img,ascii-lcd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASCII LCD displays on Imagination Technologies boards
+
+maintainers:
+  - Paul Burton <paulburton@kernel.org>
+
+properties:
+  compatible:
+    enum:
+      - img,boston-lcd
+      - mti,malta-lcd
+      - mti,sead3-lcd
+
+  reg:
+    maxItems: 1
+
+  offset:
+    description:
+      Offset in bytes to the LCD registers within the system controller
+
+required:
+  - compatible
+
+oneOf:
+  - required:
+      - reg
+  - required:
+      - offset
+
+if:
+  properties:
+    compatible:
+      contains:
+        const: img,boston-lcd
+then:
+  required:
+    - reg
+else:
+  required:
+    - offset
+
+additionalProperties: false
+
+examples:
+  - |
+    lcd: lcd@17fff000 {
+            compatible = "img,boston-lcd";
+            reg = <0x17fff000 0x8>;
+    };
diff --git a/Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt b/Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt
deleted file mode 100644
index b69bb68992fdf2a7..0000000000000000
--- a/Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Binding for ASCII LCD displays on Imagination Technologies boards
-
-Required properties:
-- compatible : should be one of:
-    "img,boston-lcd"
-    "mti,malta-lcd"
-    "mti,sead3-lcd"
-
-Required properties for "img,boston-lcd":
-- reg : memory region locating the device registers
-
-Required properties for "mti,malta-lcd" or "mti,sead3-lcd":
-- regmap: phandle of the system controller containing the LCD registers
-- offset: offset in bytes to the LCD registers within the system controller
-
-The layout of the registers & properties of the display are determined
-from the compatible string, making this binding somewhat trivial.
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c2ca9c3809f0104..a8afc9238fd8e164 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9063,7 +9063,7 @@ F:	drivers/usb/atm/ueagle-atm.c
 IMGTEC ASCII LCD DRIVER
 M:	Paul Burton <paulburton@kernel.org>
 S:	Maintained
-F:	Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt
+F:	Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
 F:	drivers/auxdisplay/img-ascii-lcd.c
 
 IMGTEC IR DECODER DRIVER
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: auxdisplay: img-ascii-lcd: Convert to json-schema
  2021-07-27 16:10 [PATCH] dt-bindings: auxdisplay: img-ascii-lcd: Convert to json-schema Geert Uytterhoeven
@ 2021-08-02 20:52 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-08-02 20:52 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: devicetree, linux-mips, Miguel Ojeda, Paul Burton, linux-kernel,
	Rob Herring

On Tue, 27 Jul 2021 18:10:34 +0200, Geert Uytterhoeven wrote:
> Convert the Device Tree binding documentation for ASCII LCD displays on
> Imagination Technologies boards to json-schema.
> 
> Drop bogus regmap property.
> Add example.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  .../bindings/auxdisplay/img,ascii-lcd.yaml    | 54 +++++++++++++++++++
>  .../bindings/auxdisplay/img-ascii-lcd.txt     | 17 ------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 55 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
>  delete mode 100644 Documentation/devicetree/bindings/auxdisplay/img-ascii-lcd.txt
> 

Added a type to 'offset' and applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-02 20:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 16:10 [PATCH] dt-bindings: auxdisplay: img-ascii-lcd: Convert to json-schema Geert Uytterhoeven
2021-08-02 20:52 ` Rob Herring

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox