linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: "paul.burton@mips.com" <paul.burton@mips.com>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"jonas.gorski@gmail.com" <jonas.gorski@gmail.com>
Subject: Re: [PATCH] MIPS: Add CPU option reporting to /proc/cpuinfo
Date: Mon, 24 Dec 2018 09:03:24 +0000	[thread overview]
Message-ID: <81623E5E-FAB2-4C91-B7F9-8C5BB8422D5C@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <20181223225224.23042-1-hauke@hauke-m.de>



> On 23 Dec 2018, at 22:52, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> 
> Many MIPS CPUs have optional CPU features which are not activates for
> all CPU cores. Print the CPU options which are implemented in the core
> in /proc/cpuinfo. This makes it possible to see what features are
> supported and which are not supported. This should cover all standard
> MIPS extensions, before it only printed information about the main MIPS
> ASEs.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---

Hi Hauke (& lists)

Apologies if I speak out of turn and/or ignorance.

The problem I have with this is that cpu_has_foo macros can (and often are in openwrt) overridden in by cpu-feature-overrides.h (e.g. arch/mips/include/asm/mach-ath79/cpu-feature-overrides.h) and thus the info shown represents features that the kernel is capable of using and not features that the cpu core is actually capable.

As you know we ended up printing cpu config registers to be sure of what the cpu was really (in theory) capable vs features that had been masked out due to overrides (and to cut a very long story short, found them to be the same in the end but they may not have been)

Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A


  reply	other threads:[~2018-12-24  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23 22:52 [PATCH] MIPS: Add CPU option reporting to /proc/cpuinfo Hauke Mehrtens
2018-12-24  9:03 ` Kevin 'ldir' Darbyshire-Bryant [this message]
2018-12-24 13:42   ` Hauke Mehrtens
2018-12-24 14:43     ` Kevin 'ldir' Darbyshire-Bryant
2018-12-25 21:35       ` Kevin 'ldir' Darbyshire-Bryant
2018-12-27 12:39         ` Hauke Mehrtens
2018-12-27 13:08           ` Kevin 'ldir' Darbyshire-Bryant
2019-01-03 21:49             ` Hauke Mehrtens
2019-01-03 23:13               ` Kevin 'ldir' Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81623E5E-FAB2-4C91-B7F9-8C5BB8422D5C@darbyshire-bryant.me.uk \
    --to=ldir@darbyshire-bryant.me.uk \
    --cc=hauke@hauke-m.de \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).