linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file
Date: Mon, 12 Oct 2020 14:17:54 +0300	[thread overview]
Message-ID: <89f93c5f-e672-74aa-51c3-7829e6d9ef9b@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.2010101259400.866917@eddie.linux-mips.org>

Hello!

On 10/10/20 3:11 PM, Maciej W. Rozycki wrote:

>>>   Umm, this has formatting issues with lines extending beyond column #80.
>>
>>    80 columns are no longer a line length limit -- 100 is, IIRC.
> 
>  I don't think anything has changed here:

   Oh, it did! Look for max_line_length in scripts/checkpatch.pl. :-)

> "The preferred limit on the length of a single line is 80 columns.
> 
> "Statements longer than 80 columns should be broken into sensible chunks,
> unless exceeding 80 columns significantly increases readability and does
> not hide information."
> 
> -- from Documentation/process/coding-style.rst, "Breaking long lines and 
> strings".
> 
>  And if it were to change anytime, then I think it would make sense for 
> such a new rule to apply to new files only.  I would be strongly against 
> it anyway, as the human's capability to parse lines has not changed when 
> it comes to the quantity of characters easily processed at once: the angle 
> spanned by eyes is hardwired.  For this reason the GNU toolchain projects 

   The font sizea are not hardwired though...

> keep the limit even lower, at 74 columns (after extensive discussions).

   This is also close to a limit on the patch descriptions...

>   Maciej

MBR, Sergei


  reply	other threads:[~2020-10-12 11:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 21:33 [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file Thomas Bogendoerfer
2020-10-08 21:33 ` [PATCH v2 2/2] MIPS: cpu-probe: introduce exclusive R3k CPU probe Thomas Bogendoerfer
2020-10-12 10:30   ` Thomas Bogendoerfer
2020-10-10  0:30 ` [PATCH v2 1/2] MIPS: cpu-probe: move fpu probing/handling into its own file Maciej W. Rozycki
2020-10-10  8:56   ` Sergei Shtylyov
2020-10-10 12:11     ` Maciej W. Rozycki
2020-10-12 11:17       ` Sergei Shtylyov [this message]
2020-10-12 10:29   ` Thomas Bogendoerfer
2020-10-12 10:30 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89f93c5f-e672-74aa-51c3-7829e6d9ef9b@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).