From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD9EC6FD1D for ; Mon, 20 Mar 2023 11:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbjCTLRp (ORCPT ); Mon, 20 Mar 2023 07:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjCTLRS (ORCPT ); Mon, 20 Mar 2023 07:17:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6C15B96 for ; Mon, 20 Mar 2023 04:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679310874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0EOqQNOoDr9J5ZhYSbGmkTrdHGjzdKjU2v0LKERLeQ=; b=erQjEfCLxk/jszXWpzrl8FIU8WaQYA3phLTP7BojMOLKqZOVWtOvMi5+Bu6hqiz1RkHXg/ FgBkJ3mPSnVNRdleVFddNtgTonm+EKjp6kq0xpi52rK6XVfA2lug3kHcmxkOEik66QDg0J GFe+vKS4kOLdWfAjBe2YialqPrDXDoo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-aQqjPuE6O1uPino-RfT9cw-1; Mon, 20 Mar 2023 07:14:33 -0400 X-MC-Unique: aQqjPuE6O1uPino-RfT9cw-1 Received: by mail-wm1-f69.google.com with SMTP id l17-20020a05600c1d1100b003ed29ba093cso4279755wms.6 for ; Mon, 20 Mar 2023 04:14:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679310872; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B0EOqQNOoDr9J5ZhYSbGmkTrdHGjzdKjU2v0LKERLeQ=; b=Yt4Ojl3SWeBy+h1gnmgtEC3DF1xFtt61ZEZH7baUfk8bKSyApC8f2LAMxDgHPcAyDX 0Ne3YFfqDGgRtGrUyT73e/ZSfNWaIW4vDZAqsJ6FEWUQ8Vw16AMvqI3xMimBvceeJ1lV A7Fs6lKY25nay3kA4MYImuKcUvGIt6DEl2IbXpatA0Ygm+GZQUAWjE+cdW/06gsb6tAA EtSjy7rIDqlUIk1tC6bdDiH/G6W+/8UPB/wUVi1UadJWE8M8REiO1uclLwTLlJgNiINn neP/3qr+LyRIPKCEx2tV4zFc+skpZIdVPINQWI2g3oVZ0GvmVFv9x5jHQD0pevJzHduQ OcpA== X-Gm-Message-State: AO0yUKVQR8rje8cJBcnv5VpLxDRYeraNv8JBj4KgaS2IeTRRZygiHbs1 k7H+7OSStzujWT4z7wqKfUGApwUwLTrerrTtk/2FilJuCUttPyaUwkIDGB3dLoj1vONyFuPva7A /B/2cugx2+JkAstnUazgn2w== X-Received: by 2002:a05:600c:444c:b0:3ea:d620:570a with SMTP id v12-20020a05600c444c00b003ead620570amr31908134wmn.38.1679310871944; Mon, 20 Mar 2023 04:14:31 -0700 (PDT) X-Google-Smtp-Source: AK7set+oDHc1SsjzfN93tiAdKSTwxgdoq4X5250NkurTWNXcaq4UNjbKf13f5qD5SXb1ugKzI+ONSg== X-Received: by 2002:a05:600c:444c:b0:3ea:d620:570a with SMTP id v12-20020a05600c444c00b003ead620570amr31908117wmn.38.1679310871619; Mon, 20 Mar 2023 04:14:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id s11-20020a1cf20b000000b003db0bb81b6asm10467233wmc.1.2023.03.20.04.14.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 04:14:31 -0700 (PDT) Message-ID: <8aa1db52-bc5b-a734-cf4f-ddee518ee9fb@redhat.com> Date: Mon, 20 Mar 2023 12:14:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static Content-Language: en-US To: Mike Rapoport Cc: Andrew Morton , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 20.03.23 12:11, Mike Rapoport wrote: > On Mon, Mar 20, 2023 at 11:30:20AM +0100, David Hildenbrand wrote: >> On 19.03.23 22:59, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> init_cma_reserved_pages() only used in cma.c, no point of having it in >>> page_alloc.c. >>> >>> Move init_cma_reserved_pages() to cma.c and make it static. >> >> I guess the motivation is to avoid letting too many subsystems mess with >> pageblock migratetypes, managed pages, PG_reserved ... > > Judging by the git log it just ended up in page_alloc.c because > set_pageblock_migratetype() was static back then ;) Yeah, it leaked into page_isolation, which heavily relies on migratetype handling :) -- Thanks, David / dhildenb