From: Yicong Yang <yangyicong@huawei.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: <yangyicong@hisilicon.com>, <corbet@lwn.net>,
<peterz@infradead.org>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, <darren@os.amperecomputing.com>,
<huzhanyuan@oppo.com>, <lipeifeng@oppo.com>,
<zhangshiming@oppo.com>, <guojian@oppo.com>, <realmz6@gmail.com>,
<linux-mips@vger.kernel.org>, <openrisc@lists.librecores.org>,
<linux-mm@kvack.org>, <x86@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linuxppc-dev@lists.ozlabs.org>, <akpm@linux-foundation.org>,
<linux-riscv@lists.infradead.org>, <linux-s390@vger.kernel.org>,
Barry Song <21cnbao@gmail.com>, <wangkefeng.wang@huawei.com>,
<xhao@linux.alibaba.com>, <prime.zeng@hisilicon.com>,
Barry Song <v-songbaohua@oppo.com>, Nadav Amit <namit@vmware.com>,
Mel Gorman <mgorman@suse.de>, <catalin.marinas@arm.com>,
<will@kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] arm64: support batched/deferred tlb shootdown during page reclamation
Date: Tue, 27 Sep 2022 17:15:40 +0800 [thread overview]
Message-ID: <8e391962-4e3a-5a56-64b4-78e8637e3b8c@huawei.com> (raw)
In-Reply-To: <168eac93-a6ee-0b2e-12bb-4222eff24561@arm.com>
On 2022/9/27 14:16, Anshuman Khandual wrote:
> [...]
>
> On 9/21/22 14:13, Yicong Yang wrote:
>> +static inline bool arch_tlbbatch_should_defer(struct mm_struct *mm)
>> +{
>> + /* for small systems with small number of CPUs, TLB shootdown is cheap */
>> + if (num_online_cpus() <= 4)
>
> It would be great to have some more inputs from others, whether 4 (which should
> to be codified into a macro e.g ARM64_NR_CPU_DEFERRED_TLB, or something similar)
> is optimal for an wide range of arm64 platforms.
>
Do you prefer this macro to be static or make it configurable through kconfig then
different platforms can make choice based on their own situations? It maybe hard to
test on all the arm64 platforms.
Thanks.
>> + return false;> +
>> +#ifdef CONFIG_ARM64_WORKAROUND_REPEAT_TLBI
>> + if (unlikely(this_cpu_has_cap(ARM64_WORKAROUND_REPEAT_TLBI)))
>> + return false;
>> +#endif
>> +
>> + return true;
>> +}
>> +
>
> [...]
>
> .
>
next prev parent reply other threads:[~2022-09-27 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:43 [PATCH v4 0/2] mm: arm64: bring up BATCHED_UNMAP_TLB_FLUSH Yicong Yang
2022-09-21 8:43 ` [PATCH v4 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Yicong Yang
2022-09-21 8:54 ` Barry Song
2022-09-21 8:43 ` [PATCH v4 2/2] arm64: support batched/deferred tlb shootdown during page reclamation Yicong Yang
2022-09-27 6:16 ` Anshuman Khandual
2022-09-27 9:15 ` Yicong Yang [this message]
2022-09-28 0:23 ` Barry Song
2022-10-27 10:41 ` Anshuman Khandual
2022-10-27 14:19 ` Punit Agrawal
2022-10-27 21:55 ` Barry Song
2022-10-28 2:14 ` Anshuman Khandual
2022-10-28 13:12 ` Punit Agrawal
2022-10-28 1:20 ` Yicong Yang
2022-10-28 13:11 ` Punit Agrawal
2022-10-28 21:40 ` Barry Song
2022-10-31 18:36 ` Punit Agrawal
2022-10-27 22:07 ` Barry Song
2022-10-28 1:56 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e391962-4e3a-5a56-64b4-78e8637e3b8c@huawei.com \
--to=yangyicong@huawei.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=darren@os.amperecomputing.com \
--cc=guojian@oppo.com \
--cc=huzhanyuan@oppo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lipeifeng@oppo.com \
--cc=mgorman@suse.de \
--cc=namit@vmware.com \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=realmz6@gmail.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).