From: Mark Tomlinson <Mark.Tomlinson@alliedtelesis.co.nz>
To: "f4bug@amsat.org" <f4bug@amsat.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chris Packham" <Chris.Packham@alliedtelesis.co.nz>,
"paulburton@kernel.org" <paulburton@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] MIPS: cavium_octeon: Fix syncw generation.
Date: Mon, 17 Feb 2020 04:58:00 +0000 [thread overview]
Message-ID: <8e852d84c8b0c6b35faa3b3f2a1034d93a6e8967.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <CAAdtpL5Tf-8O=xMKO33DWDs=2_Hsdk=FQSNO5Gsrx=9hWvENdg@mail.gmail.com>
Hi Phil,
On Mon, 2020-02-17 at 01:22 +0100, Philippe Mathieu-Daudé wrote:
> Hi Mark,
>
> On Tue, Feb 11, 2020 at 10:42 PM Mark Tomlinson
> <mark.tomlinson@alliedtelesis.co.nz> wrote:
> >
> > The Cavium Octeon CPU uses a special sync instruction for implementing
> > wmb, and due to a CPU bug, the instruction must appear twice. A macro
> > had been defined to hide this:
> >
> > #define __SYNC_rpt(type) (1 + (type == __SYNC_wmb))
> >
> > which was intended to evaluate to 2 for __SYNC_wmb, and 1 for any other
> > type of sync. However, this expression is evaluated by the assembler,
> > and not the compiler, and the result of '==' in the assembler is 0 or
> > -1, not 0 or 1 as it is in C. The net result was wmb() producing no code
> > at all. The simple fix in this patch is to change the '+' to '-'.
>
> Isn't this particular to the assembler implementation?
> Can you explicit the assembler you are using in the commit description?
> Assuming we have to look at your commit in 3 years from now, we'll
> wonder what assembler you were using.
>
> Thanks,
>
> Phil.
Yes, it is tied to the assembler. But the Linux kernel is tied to GCC,
and GCC (I believe) is tied to GNU as. I can't see the specification of
GNU as changing, since that could break anything written for it.
> > Fixes: bf92927251b3 ("MIPS: barrier: Add __SYNC() infrastructure")
> > Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> > ---
> > arch/mips/include/asm/sync.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/include/asm/sync.h b/arch/mips/include/asm/sync.h
> > index 7c6a1095f5..aabd097933 100644
> > --- a/arch/mips/include/asm/sync.h
> > +++ b/arch/mips/include/asm/sync.h
> > @@ -155,9 +155,11 @@
> > * effective barrier as noted by commit 6b07d38aaa52 ("MIPS: Octeon: Use
> > * optimized memory barrier primitives."). Here we specify that the affected
> > * sync instructions should be emitted twice.
> > + * Note that this expression is evaluated by the assembler (not the compiler),
> > + * and that the assembler evaluates '==' as 0 or -1, not 0 or 1.
> > */
> > #ifdef CONFIG_CPU_CAVIUM_OCTEON
> > -# define __SYNC_rpt(type) (1 + (type == __SYNC_wmb))
> > +# define __SYNC_rpt(type) (1 - (type == __SYNC_wmb))
> > #else
> > # define __SYNC_rpt(type) 1
> > #endif
> > --
> > 2.25.0
> >
next prev parent reply other threads:[~2020-02-17 4:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 21:24 [PATCH] MIPS: cavium_octeon: Fix syncw generation Mark Tomlinson
2020-02-11 21:37 ` Chris Packham
2020-02-15 22:55 ` Paul Burton
2020-02-17 0:22 ` Philippe Mathieu-Daudé
2020-02-17 4:58 ` Mark Tomlinson [this message]
2020-02-17 20:01 ` Chris Packham
2020-02-18 18:37 ` Nick Desaulniers
2020-02-20 15:28 ` Dmitry Golovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e852d84c8b0c6b35faa3b3f2a1034d93a6e8967.camel@alliedtelesis.co.nz \
--to=mark.tomlinson@alliedtelesis.co.nz \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=f4bug@amsat.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).