From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D279C433FE for ; Fri, 18 Nov 2022 12:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241302AbiKRMiv (ORCPT ); Fri, 18 Nov 2022 07:38:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241542AbiKRMit (ORCPT ); Fri, 18 Nov 2022 07:38:49 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49A840440 for ; Fri, 18 Nov 2022 04:38:48 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id u2so6627408ljl.3 for ; Fri, 18 Nov 2022 04:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=no+H9b9eosuH2qEiOD6KMI4wDDshNFpABjP/G2BO63Y=; b=jppWrMespj1W0x31C9rRdsaH+buh83dd/Gcj7rlLRtIESrlD//bdSWM9+4ikPaNATM 3jNHsYnzfIt+1qp93V6OXnhxPO5SNUxRXJ/TWMh0jB8rnvAN/Bn44AAO/yLzhzCdJsuG DguZeIHz+DYm4t6pdwsZB5gtuYIMZaU8yFSrD8Ycim0rDmOfIz8FGLO50T2CTSFKv3LH Oh80rSa6GhGxaEnIuQPwfKoXqHD5jgqlpqmDsi0WdOwZ0TXMPF1FsLhToraw3qbOR6tu PdLgJzSuXcAj6AcIyebrgco2D6UH2F5Y1YrjKqRQhOvfz8cwn6sywTCGsU70k8ptIo7c vbtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=no+H9b9eosuH2qEiOD6KMI4wDDshNFpABjP/G2BO63Y=; b=jQS3svfAOySOJQIv0PX1o2l3Sjfo55M+N/Zn8AfNE0LB6w5IrYTfbZG2N//2ANm3BE hG5ITS5H/27Vz+M4OqbEu1xQbetLidYERlt00/D0c6pg5yxkbwFKmvkj7vVSG4hqWPpn UJuYigFW5ZPgjNuWFSIgvpSBv9WC49PaK21klW2mZQvOxbhxn/6T5pBfYdeKoT4r9+gX 1uWC6FStzTxy+VPfY+IKUhNrSx+qRg1kEWxf4dESZz+XcM51wJtvgmHMETL5eUCJQMT2 Brj0ArJA6cwmxuotPIO/Y5BJGkKfgrSzmwoTOyf7p2j0JbQ098O2f1+VK+FOZJVNsAVA tFkA== X-Gm-Message-State: ANoB5pk3Irx6i1MpM/HvkKP2AoQe+h0653Joh9KUX3Q6lUpeI1DMjly3 ueEIxG/TjJu84bzbsXvScA82XA== X-Google-Smtp-Source: AA0mqf62h736Id6DM8RIqmZIS9xAsNwoJ77uCAoB61kEqeITqo+LxKOuY7z4FqSEcmCxnj0W6V0Atw== X-Received: by 2002:a2e:b529:0:b0:26a:c77f:57f8 with SMTP id z9-20020a2eb529000000b0026ac77f57f8mr2247605ljm.465.1668775127010; Fri, 18 Nov 2022 04:38:47 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u24-20020a2e9b18000000b002637c04b472sm638303lji.83.2022.11.18.04.38.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 04:38:46 -0800 (PST) Message-ID: <947bc72f-2273-9474-9af4-5532d69491b2@linaro.org> Date: Fri, 18 Nov 2022 13:38:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Content-Language: en-US To: Yinbo Zhu , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , WANG Xuerui , Jiaxun Yang , Thomas Bogendoerfer , Juxin Gao , Bibo Mao , Yanteng Si , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, richard.liu@st.com, Arnaud Patard , Hongbing Hu , Huacai Chen References: <20221108092107.28996-1-zhuyinbo@loongson.cn> <20221108092107.28996-2-zhuyinbo@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 14/11/2022 10:50, Yinbo Zhu wrote: > >>> + >>> + "#gpio-cells": >>> + const: 2 >>> + >>> + gpio-controller: true >>> + >>> + gpio-ranges: true >>> + >>> + loongson,conf_offset: >> >> No underscores in node names. Plus comments from Linus seem to apply >> here as well. Drop it entirely or explain why this is not part of >> compatible, why this is needed and why encoding programming model >> address in DT matches the DT... > Add it is to distinguish differnt address in different platform. > and I had drop them and initial them in kernel driver that depend > on diffent compatible. >> So if you had to drop these, please drop from the bindings. Best regards, Krzysztof