linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context
@ 2020-01-03 16:20 Vikas Gupta
  2020-01-03 16:20 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Reduce shm mem size to 4K Vikas Gupta
  2020-01-05 22:47 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Vikas Gupta @ 2020-01-03 16:20 UTC (permalink / raw)
  To: Rafał Miłecki, David S. Miller, Sheetal Tigadoli,
	netdev, linux-mips, linux-kernel, Sumit Garg
  Cc: vasundhara-v.volam, vikram.prakash, Vikas Gupta

Fix calling multiple tee_client_close_context in case of shm allocation
fails.

Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”)
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
---
 drivers/firmware/broadcom/tee_bnxt_fw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89..ed10da5 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
 	fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
 				    TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
 	if (IS_ERR(fw_shm_pool)) {
-		tee_client_close_context(pvt_data.ctx);
 		dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
 		err = PTR_ERR(fw_shm_pool);
 		goto out_sess;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-06  6:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 16:20 [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context Vikas Gupta
2020-01-03 16:20 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Reduce shm mem size to 4K Vikas Gupta
2020-01-05 22:47 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context David Miller
2020-01-06  6:25   ` Vikas Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).