From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-mips@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Kevin Cernekee <cernekee@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>
Subject: Re: [PATCH 1/3] devicetree: document the BCM63XX gated clock bindings
Date: Mon, 6 May 2019 01:26:04 +0200 [thread overview]
Message-ID: <98402178-2576-dc91-06e2-b8b4664ef348@amsat.org> (raw)
In-Reply-To: <CAOiHx==tzUHU1nSf9c2+EtR0wJ=HDstRhHBCBQE5j79_uwJOLQ@mail.gmail.com>
On 5/5/19 8:57 PM, Jonas Gorski wrote:
> Hi Philippe,
>
> On Fri, 3 May 2019 at 16:36, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> Hi Jonas,
>>
>> On 5/2/19 2:26 PM, Jonas Gorski wrote:
>>> Add binding documentation for the gated clock controller found on MIPS
>>> based BCM63XX SoCs.
>>
>> I'd have ordered this patch after the #2 of this series, or eventually
>> squashed both together. It is weird to document an unexistant feature
>> then implement it, while the opposite looks more natural.
>> (If you agree, maybe Paul can invert those when applying this series).
>>
>> Anyway:
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> You are documenting hardware, not a driver/feature. :-)
>
> The binding is supposed to be a separate patch [1]. The natural order
> is to first describe the hardware (with the binding documentation),
> then add the actual driver making use of the binding. Checkpatch.pl
> will also warn if you use a compatible that isn't documented, which
> happens (shortly) if you first add the driver.
Oh, thanks for the pointer, this is my first DT review ;)
> Regards
> Jonas
>
> [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/submitting-patches.txt#L8
>
next prev parent reply other threads:[~2019-05-05 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 12:26 [PATCH 0/3] MIPS: BMIPS: add support for gated clock controller Jonas Gorski
2019-05-02 12:26 ` [PATCH 1/3] devicetree: document the BCM63XX gated clock bindings Jonas Gorski
2019-05-03 1:44 ` Florian Fainelli
2019-05-03 9:47 ` Jonas Gorski
2019-05-03 14:36 ` Philippe Mathieu-Daudé
2019-05-05 18:57 ` Jonas Gorski
2019-05-05 23:26 ` Philippe Mathieu-Daudé [this message]
2019-05-14 20:33 ` Rob Herring
2019-06-27 20:36 ` Stephen Boyd
2019-05-02 12:26 ` [PATCH 2/3] clk: add BCM63XX gated clock controller driver Jonas Gorski
2019-05-03 1:46 ` Florian Fainelli
2019-05-03 14:13 ` Philippe Mathieu-Daudé
2019-06-27 20:43 ` Stephen Boyd
2019-05-02 12:26 ` [PATCH 3/3] MIPS: BMIPS: add clock controller nodes Jonas Gorski
2019-05-03 1:47 ` Florian Fainelli
2019-05-03 14:36 ` Philippe Mathieu-Daudé
2019-07-22 21:22 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98402178-2576-dc91-06e2-b8b4664ef348@amsat.org \
--to=f4bug@amsat.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jhogan@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).