From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF5DC04AB3 for ; Mon, 27 May 2019 11:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AB7620815 for ; Mon, 27 May 2019 11:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726463AbfE0Ljb (ORCPT ); Mon, 27 May 2019 07:39:31 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:44041 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfE0Lja (ORCPT ); Mon, 27 May 2019 07:39:30 -0400 Received: by mail-ot1-f66.google.com with SMTP id g18so14506656otj.11; Mon, 27 May 2019 04:39:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V0OzTK0kT2ddqZaGr86QRO9HD6H6ELQHgY3vn9EoNSY=; b=nxBPaLcOHEMMdpZHLjXHOILUXYM8fTOI5bfBJJzIuPdm5mvL9uczAcDCZzKQcheqrN /sF7iVdTly8QcS37JohIugNQjMN+SdRwmaBlWSF/xXV+G21BU9sSG6IxvMYDy6VXPHka fFkS2JnNuppbI0A+djLSGEumGqTrDD273Rcea3ZL1j3XS8ACje+k2KImh+nLJXhy2qgQ 7K+npPDh3CfHY22hHIYqECLOuBYeiWASF3C5kbgwIVMhNRZRDELzyr3e4j0wGdhtd3ch n/RTnCJSfoeoWo1JNkNo4d5wo6AO5aBK5s7Iq7mjEAM5BnDWeIoU1nH0ddDGyz98XP9Q 4djg== X-Gm-Message-State: APjAAAV89id1kqpUo8Ajpos7Z4do0GkQNSRoWc00IV5DeQI2NoTE3B0V qTmjmzwgYCtu+y4Fq030nQnnVHdu0JHoWMvMO34= X-Google-Smtp-Source: APXvYqzRJPkCqJiOx+VOhGWb3xNSagzD3mXtVwSHX6dsr/mX9srOC/7Nko7rnVoMhplnBtrellrsrHboMJ8YmHsuPBA= X-Received: by 2002:a9d:1a5:: with SMTP id e34mr44398857ote.59.1558957169445; Mon, 27 May 2019 04:39:29 -0700 (PDT) MIME-Version: 1.0 References: <20190521145141.9813-1-paul@crapouillou.net> In-Reply-To: <20190521145141.9813-1-paul@crapouillou.net> From: Mathieu Malaterre Date: Mon, 27 May 2019 13:39:18 +0200 Message-ID: Subject: Re: Ingenic Timer/Counter Unit (TCU) patchset v12 To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Jonathan Corbet , Daniel Lezcano , Thomas Gleixner , Michael Turquette , Stephen Boyd , Jason Cooper , Marc Zyngier , Lee Jones , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, od@zcrc.me Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, May 21, 2019 at 4:51 PM Paul Cercueil wrote: > > Hi, > > Here's the V12 of my patchset to add support for the Timer/Counter Unit > (TCU) present on the JZ47xx SoCs from Ingenic. > > This patchset is much shorter at only 13 patches vs. 27 patches in V11; > the remaining patches will be sent in parallel (if applicable) or as a > follow-up patchset once this one is merged. > > In V11 the clocksource maintainers weren't happy with the size of the > ingenic-timer driver, which included clocks and irqchip setup code. > On the other hand, devicetree maintainers wanted one single node for > the TCU hardware since it's effectively just one hardware block. > > In this patchset the functionality is cut in four different drivers: > a MFD one to provide the regmap, probe the children and which provides > several API functions; a clocks driver; a irqchip driver; a clocksource > driver. All these drivers work with the same regmap, have the same > compatible strings, and will probe _with the same devicetree node_. For the series: Tested-by: Mathieu Malaterre System: MIPS Creator CI20 For reference, here is my local patch: diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index 1bfac58da5df..e7b7da32f278 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include / { @@ -80,6 +81,15 @@ interrupt-parent = <&intc>; interrupts = <27 26 25>; + + watchdog: watchdog@0 { + compatible = "ingenic,jz4780-watchdog"; + reg = <0x0 0xc>; + + clocks = <&tcu TCU_CLK_WDT>; + clock-names = "wdt"; + }; + }; rtc_dev: rtc@10003000 { @@ -287,14 +297,6 @@ status = "disabled"; }; - watchdog: watchdog@10002000 { - compatible = "ingenic,jz4780-watchdog"; - reg = <0x10002000 0x10>; - - clocks = <&cgu JZ4780_CLK_RTCLK>; - clock-names = "rtc"; - }; - nemc: nemc@13410000 { compatible = "ingenic,jz4780-nemc"; reg = <0x13410000 0x10000>; > Regards, > -Paul > >