From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409EAC4338F for ; Wed, 4 Aug 2021 13:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17F1E60F43 for ; Wed, 4 Aug 2021 13:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237394AbhHDNrR (ORCPT ); Wed, 4 Aug 2021 09:47:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236758AbhHDNrQ (ORCPT ); Wed, 4 Aug 2021 09:47:16 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB2DFC0613D5 for ; Wed, 4 Aug 2021 06:47:02 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id u3so3853796ejz.1 for ; Wed, 04 Aug 2021 06:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hev-cc.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZdWCbKQ0FeBPqzrHYkEiTGQcOJDgW/YM6BhLZvlGVa0=; b=bd+MQUXjLGYM2BWsZBVdwUXcKoZhBZTarzqqinr42+H8hC5UYktDAos8vj5w/BGSSE qC6SZUHfBD7DT8eRSRCtJ1uPaaFrYM11X912eALlWJk20icqfiKUIXCfm4mMELRTMQn3 B28Y/CXzoXfQ96g/11w1Va8Eui3Gf9FjMs5ms9UmXWpZS2ZSDsC4XIRetjyiFEOluc9x esXBVBPh5+pg1c0RYipG0UqUOwPM3d7315zzIzRXZvj1BH+CIq5o2dunC6DTYLXPk3zE MOtYRR8zKiHNCnwuEXZoxUudpHQsdPOCTCO7SBw3Nk6s911eTF2JwPx7UkkcPHSddfUV HKVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZdWCbKQ0FeBPqzrHYkEiTGQcOJDgW/YM6BhLZvlGVa0=; b=iWCBQOAhoGTipfR3XBhzbKJZGVlN14DifxATfYo0B6IK8J8jvJaebgp6dkKhl71+Fu 11pERIWRjg4Hc1PJT8iVQ6KJP2Eay1bwsMf8cEfEpn5SoRoc22r/0IDxiSFHs5QEda5u denu0jB12/iwHZRBN5LdSXMrcSP6dFQwtFzI+9r0eoU6XYqzi6G6c3P1H6MGMG/69I43 NFkYcoz7pbgCtVQ5GXly/t7/UEYVi+bV2YWOxjH+GaUz7yZ7lM/a9FzTFhj/jWy4soRQ EwfMHb3Ha1kd1wpB/gR1gfsTlFh1fJLf8fAp43pf0ErFVyA3S5u1qnn6ozNB2fjnl5YQ cqEA== X-Gm-Message-State: AOAM530LlvyuSUun4T9+t6I/E3RS22FHdIjUx268pg3ThPQXwmUNsLEn 9+5dS30cC1j5Hx2V4LUb+9l492kHb1uEFQ4wzsB4bA== X-Google-Smtp-Source: ABdhPJyhVGHT+EfmUvgX2/jIbnFHTnjhaZPNSXW2mejIDCZ+TVSLsD62L2XpG1vvE6+F4OiCSchYQS0noBgHWewXzus= X-Received: by 2002:a17:906:f20a:: with SMTP id gt10mr26145158ejb.267.1628084821505; Wed, 04 Aug 2021 06:47:01 -0700 (PDT) MIME-Version: 1.0 References: <20210729082549.144559-1-wangrui@loongson.cn> <20210729095342.GB8286@alpha.franken.de> <20210729143307.GA13231@alpha.franken.de> In-Reply-To: <20210729143307.GA13231@alpha.franken.de> From: hev Date: Wed, 4 Aug 2021 21:46:50 +0800 Message-ID: Subject: Re: [RFC PATCH] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive To: Thomas Bogendoerfer Cc: Rui Wang , Peter Zijlstra , Will Deacon , Boqun Feng , Linux Kernel Mailing List , linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Jul 29, 2021 at 10:33 PM Thomas Bogendoerfer wrote: > > On Thu, Jul 29, 2021 at 08:31:11PM +0800, hev wrote: > > Hi, Thomas, > > > > On Thu, Jul 29, 2021 at 5:53 PM Thomas Bogendoerfer > > wrote: > > > > > > On Thu, Jul 29, 2021 at 04:25:49PM +0800, Rui Wang wrote: > > > > This looks like a typo and that caused atomic64 test failed. > > > > > > > > Signed-off-by: Rui Wang > > > > Signed-off-by: hev > > > > --- > > > > arch/mips/include/asm/atomic.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h > > > > index 95e1f7f3597f..a0b9e7c1e4fc 100644 > > > > --- a/arch/mips/include/asm/atomic.h > > > > +++ b/arch/mips/include/asm/atomic.h > > > > @@ -206,7 +206,7 @@ ATOMIC_OPS(atomic64, xor, s64, ^=, xor, lld, scd) > > > > * The function returns the old value of @v minus @i. > > > > */ > > > > #define ATOMIC_SIP_OP(pfx, type, op, ll, sc) \ > > > > -static __inline__ int arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > > > > +static __inline__ type arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > > > > { \ > > > > type temp, result; \ > > > > \ > > > > > > sub_if_postive looks unused to me. Could you send a patch removing it > > > instead ? riscv also has a sub_if_positive implementation, which looks > > > unused. > > I found atomic{_64,}_dec_if_postive is based on sub_if_postive, and > > used in many places: > > > > kernel/kmod.c: if (atomic_dec_if_positive(&kmod_concurrent_max) < 0) { > > kernel/kmod.c: > > atomic_dec_if_positive(&kmod_concurrent_max) >= 0, > > kernel/module.c: ret = atomic_dec_if_positive(&module->refcnt); > > ... > > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c: > > atomic64_dec_if_positive(&esw->user_count); > > drivers/net/netdevsim/fib.c: atomic64_dec_if_positive(&entry->num); > > drivers/net/netdevsim/fib.c: atomic64_dec_if_positive(&entry->num); > > > > Are you sure to remove it? > > in that case, let's keep it. There is a fallback for atomic_dec_if_positive, > that's why I didn't notice where it is used. yep, do you think this patch is okay? Regards, Rui