From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E24C43331 for ; Sat, 7 Sep 2019 17:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDE3921871 for ; Sat, 7 Sep 2019 17:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567878770; bh=msHmPyEJDzQFsZmLPdWi5gjJmS+VqKjbTg7O/MhE5Lo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QiLrTeprHyQRI+xn7fximXLNvW6FfLol65Qb5Zns8u2EGg9tDAWqIpj9x3KRiRdo8 AIVGlNnNTgIS+WBfaX6ko1jn1vtE2/3iIqjtKsLeAMDdUTwi0CItWSmkil4ezFcSwU 9d1EAk82I8ohj1dbC6WBmy72+duNQh23zbw5cff8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388396AbfIGRwu (ORCPT ); Sat, 7 Sep 2019 13:52:50 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38850 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387400AbfIGRwu (ORCPT ); Sat, 7 Sep 2019 13:52:50 -0400 Received: by mail-lj1-f195.google.com with SMTP id y23so8578122ljn.5 for ; Sat, 07 Sep 2019 10:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=O0k0d7lqzfAmPEYFzDlOGgQsR12LVtrvxo5oTKj/qTWwdx05EQgXW+UipRXAFcHY7l NJSN5sB8Bd0GzZnsutsLrlnHa03N+sVzppgC400AeuuF3leAik8ua94YYTL1N/jeDSEY p0NLqzIjW/MddvLJPDdxPws4zfzc5nCUgJ+sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=DwYPDq4j8YyMLgbwarnUJwb/+CTvpY5kpW47hr4/uEfc+2Nqljv4ffBKpuUdLp20lu d81xVz2xdwP6At+pllmLy/0SUcGVhmFtKle7Nsq/2haxCFxB6RvvYj0H5ntLgHxLWcuA HI9vO1KvS//y/vrs5lrmdOa4JPfJ/If8pL7+vHem40qRdz6dLpKoBW0177GqV889DW1M dKd7WfUS+u/CQk8qkVN/4dcJGoAEiVliZFhMNCz7G+PJsXtAhSlDwOUVJPBlLAFPpGaA veVC4G2/Tkm44a2bHoUJ//dOeZh2C+9bVd1g+DBKUMLXbXX/X8i0+U54IGluSaBNn8WA 7wHQ== X-Gm-Message-State: APjAAAXZUK5POWj+Yh+7DMNeXQx3nmj68uN258w+t/ZRKTJGoTR5n3mX pDknc9c+vUkpgo9EcFaaefQZsbBbEiM= X-Google-Smtp-Source: APXvYqyFvN6h+qfYkRtlgvG2zHDxQSDrcGcgdr6H+xKg49gUMgk8YXkaCD7OG5IGBDY4UwjkzLyfnA== X-Received: by 2002:a2e:551:: with SMTP id 78mr9985576ljf.48.1567878767755; Sat, 07 Sep 2019 10:52:47 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id r27sm1555551ljn.60.2019.09.07.10.52.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Sep 2019 10:52:47 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id l1so8876393lji.12 for ; Sat, 07 Sep 2019 10:52:47 -0700 (PDT) X-Received: by 2002:a2e:8645:: with SMTP id i5mr9691835ljj.165.1567878349245; Sat, 07 Sep 2019 10:45:49 -0700 (PDT) MIME-Version: 1.0 References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-12-cyphar@cyphar.com> <7236f382d72130f2afbbe8940e72cc67e5c6dce0.camel@kernel.org> In-Reply-To: From: Linus Torvalds Date: Sat, 7 Sep 2019 10:45:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 11/12] open: openat2(2) syscall To: Andy Lutomirski Cc: Jeff Layton , Aleksa Sarai , Al Viro , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Peter Zijlstra , Christian Brauner , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Rasmus Villemoes , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Aleksa Sarai , Linux Containers , alpha , Linux API , linux-arch , Linux ARM , linux-fsdevel , linux-ia64@vger.kernel.org, Linux List Kernel Mailing , "open list:KERNEL SELFTEST FRAMEWORK" , linux-m68k , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390 , Linux-sh list , linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Sep 7, 2019 at 10:42 AM Andy Lutomirski wrote: > > Linus, you rejected resolveat() because you wanted a *nice* API No. I rejected resoveat() because it was a completely broken garbage API that couldn't do even basic stuff right (like O_CREAT). We have a ton of flag space in the new openat2() model, we might as well leave the old flags alone that people are (a) used to and (b) we have code to support _anyway_. Making up a new flag namespace is only going to cause us - and users - more work, and more confusion. For no actual advantage. It's not going to be "cleaner". It's just going to be worse. Linus