From: Chuanhong Guo <gch981213@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-mips@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
Felix Fietkau <nbd@nbd.name>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/3] MIPS: ath79: add ag71xx support
Date: Sun, 5 May 2019 00:01:00 +0800 [thread overview]
Message-ID: <CAJsYDV+1dXfQ3qKMDkbbXa94UQ+DiNCQ3YQB=PTkeXJ19Xa8uQ@mail.gmail.com> (raw)
In-Reply-To: <20190422064046.2822-1-o.rempel@pengutronix.de>
Hi!
On Mon, Apr 22, 2019 at 2:41 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> [...]
> - most of deficetree bindings was removed. Not every thing made sense
> and most of it is SoC specific, so it is possible to detect it by
> compatible.
I noticed that you've dropped all PLL and gmac-config stuff. These are
board-specific properties and PLL registers should be changed
accroding to negotiated ethernet speed. By dropping them, you rely on
bootloader to configure everything corectly for you (which has been
proven unreliable for many ath79 routers) and ethernet won't work if
negotiated speed changed after u-boot's configuration.
Regards,
Chuanhong Guo
next prev parent reply other threads:[~2019-05-04 16:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 6:40 [PATCH v3 0/3] MIPS: ath79: add ag71xx support Oleksij Rempel
2019-04-22 6:40 ` [PATCH v3 1/3] dt-bindings: net: add qca,ar71xx.txt documentation Oleksij Rempel
2019-04-30 22:51 ` Rob Herring
2019-04-22 6:40 ` [PATCH v3 2/3] MIPS: ath79: ar9331: add Ethernet nodes Oleksij Rempel
2019-04-22 6:40 ` [PATCH v3 3/3] net: ethernet: add ag71xx driver Oleksij Rempel
2019-04-22 13:25 ` Andrew Lunn
2019-05-04 15:40 ` Chuanhong Guo
2019-05-05 5:41 ` Oleksij Rempel
2019-05-19 7:40 ` Oleksij Rempel
2019-05-04 16:01 ` Chuanhong Guo [this message]
2019-05-04 17:45 ` [PATCH v3 0/3] MIPS: ath79: add ag71xx support Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJsYDV+1dXfQ3qKMDkbbXa94UQ+DiNCQ3YQB=PTkeXJ19Xa8uQ@mail.gmail.com' \
--to=gch981213@gmail.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jcliburn@gmail.com \
--cc=jhogan@kernel.org \
--cc=john@phrozen.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).