From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E51C04AB4 for ; Fri, 17 May 2019 04:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 072C42083E for ; Fri, 17 May 2019 04:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="MjmYEj/7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727086AbfEQEY4 (ORCPT ); Fri, 17 May 2019 00:24:56 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:49060 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfEQEY4 (ORCPT ); Fri, 17 May 2019 00:24:56 -0400 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x4H4OW2a016993; Fri, 17 May 2019 13:24:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x4H4OW2a016993 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1558067073; bh=XSdURHr+DFj73XgjlE8DVqoSorih7QO9jSg+HW1D8TM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MjmYEj/7xZIYGboJToCEBgv5PN/8CD6sDWZgip2cIfkO7e3Ii9sfP5C3OkJ+w+bmf nV6cmWzKaBSSjsZhyrn4bys5Y4Q6I+OEw7Kw5shBSlS1idFvlydMF1XAeStprazHXe YEbmOvO03hshhgHZXMzPoXOKrUM23BsqSOjE9eL/rkptHR8OUhQKwyp/IklD0+/Dl9 owyazsPp24tpqnpga80RjHHMgFR00FgPaqDWKyOVGScKcv6zoiLl/Anuo6IiuxTxjf qbtJQzYFIsrlK27Oe+MJKRLUUuHhjaC4kJm7cNQh1CbYjHyDzVm4085SMLX6fx2uBd H18+0yFykqaGg== X-Nifty-SrcIP: [209.85.217.49] Received: by mail-vs1-f49.google.com with SMTP id o10so3750740vsp.12; Thu, 16 May 2019 21:24:32 -0700 (PDT) X-Gm-Message-State: APjAAAUM7tMr8SHSizjNRn02KJyzLHVXpwOUD1M81+T2t10lCH1GD3ZS gOrlhGZjT2w8LXvKFSaC90rpzIRamTE26OnpgKU= X-Google-Smtp-Source: APXvYqwRom2nfToM4jL1gKybhnXBZPLM/8GRypEcR2drcSxkNBd5y+Id9rfE+eiIpAnAfm5gkg5AbPeOHdYPagE+d9M= X-Received: by 2002:a67:ad0f:: with SMTP id t15mr7896301vsl.179.1558067071748; Thu, 16 May 2019 21:24:31 -0700 (PDT) MIME-Version: 1.0 References: <20190423034959.13525-1-yamada.masahiro@socionext.com> <20190423034959.13525-5-yamada.masahiro@socionext.com> In-Reply-To: From: Masahiro Yamada Date: Fri, 17 May 2019 13:23:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH v3 04/11] s390/cpacf: mark scpacf_query() as __always_inline To: Laura Abbott Cc: Andrew Morton , linux-arch , Christophe Leroy , linux-s390 , Arnd Bergmann , Mathieu Malaterre , X86 ML , Heiko Carstens , linux-mips@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , linux-mtd , linuxppc-dev , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, May 17, 2019 at 8:01 AM Laura Abbott wrote: > > On 4/22/19 8:49 PM, Masahiro Yamada wrote: > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > place. We need to eliminate potential issues beforehand. > > > > If it is enabled for s390, the following error is reported: > > > > In file included from arch/s390/crypto/des_s390.c:19: > > ./arch/s390/include/asm/cpacf.h: In function 'cpacf_query': > > ./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't match constraints > > asm volatile( > > ^~~ > > ./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm' > > > > This also seems to still be broken, again with gcc 9.1.1 > > BUILDSTDERR: In file included from arch/s390/crypto/prng.c:29: > BUILDSTDERR: ./arch/s390/include/asm/cpacf.h: In function 'cpacf_query_func': > BUILDSTDERR: ./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't match constraints > BUILDSTDERR: 170 | asm volatile( > BUILDSTDERR: | ^~~ > BUILDSTDERR: ./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm' > > I realized we're still carrying a patch to add -fno-section-anchors > but it's a similar failure to powerpc. Christophe had already pointed out potential issues for "i" constraint, and I have fixups in hand: See https://lkml.org/lkml/2019/5/3/459 My plan was to send it after all of my base patches were merged. This s390 cparf.h is included in the TODO list. Will fix soon. Thanks. -- Best Regards Masahiro Yamada