From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB18CC04AB6 for ; Fri, 31 May 2019 08:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 857C926561 for ; Fri, 31 May 2019 08:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbfEaIfR (ORCPT ); Fri, 31 May 2019 04:35:17 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36259 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfEaIfR (ORCPT ); Fri, 31 May 2019 04:35:17 -0400 Received: by mail-qt1-f193.google.com with SMTP id u12so10398196qth.3; Fri, 31 May 2019 01:35:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6IAGTJ1uN3QgaPB0JEyQM4jANte20b3cD0wECnCP0+4=; b=n4dNxHkho9p36ijPunDYFCbKnuTSzDXRzM6VfR3VtuYRkQ5sqpjHkr3imVWxIv4Oxw gdmOC1B5RnOiK9UQSvHnPkZCdtShNip/BCTEH0/MuQmlF/TobDTCeJlJOH6nSE1oEc5Y g8NdCCk6xrIZdqPTn+5SK47VyOCovnvEX1t5+1QzP3bCJBIrqEiGUUi3YTZklCvSgjxD 7+eGF/YAdanOuAvtt9+x0m32NpNcPsrozsoCuhQiCejq7tbOGJO2XA6yoB0l9pEhEkG6 oKuDAFKwLbrkx8F/qGPFONHCScCOJit7RcLRzmW5eY17T3b2bVF3XFmLP9788so9Gaf7 D6hg== X-Gm-Message-State: APjAAAVp8cmCMkT7z2OqCBJ14Tyz2h69ZkisJVVX0Ocq5uS9TBcOLOC7 5la64MfGXgnNMgqAE55z0rsen5xpZ6CKEG1dV+Y= X-Google-Smtp-Source: APXvYqwJnDx5Tq81xAUY+isfpEB8HE2a5+TeAN3eO+1/XlqybT+dn9X3SVzRZ6Qq/cvLrjWF8XAcIqH+slSq4FlW4JU= X-Received: by 2002:aed:2bc1:: with SMTP id e59mr7134581qtd.7.1559291715239; Fri, 31 May 2019 01:35:15 -0700 (PDT) MIME-Version: 1.0 References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-18-vincenzo.frascino@arm.com> In-Reply-To: <20190530141531.43462-18-vincenzo.frascino@arm.com> From: Arnd Bergmann Date: Fri, 31 May 2019 10:34:59 +0200 Message-ID: Subject: Re: [PATCH v6 17/19] mips: Add support for generic vDSO To: Vincenzo Frascino Cc: linux-arch , Linux ARM , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino wrote: > --- a/arch/mips/vdso/vdso.lds.S > +++ b/arch/mips/vdso/vdso.lds.S > @@ -99,6 +99,10 @@ VERSION > global: > __vdso_clock_gettime; > __vdso_gettimeofday; > + __vdso_clock_getres; > +#if _MIPS_SIM != _MIPS_SIM_ABI64 > + __vdso_clock_gettime64; > +#endif > #endif > local: *; > }; Same comment as for the corresponding arm change: I'd leave the ABI changes to a separate patch, and probably not add __vdso_clock_getres at all. Also, you seem to have a typo here: > +notrace int __vdso_clock_gettime_time64(clockid_t clock, > + struct __kernel_timespec *ts) > +{ > + return __cvdso_clock_gettime(clock, ts); > +} This should be __vdso_clock_gettime64, not __vdso_clock_gettime_time64 I think. Arnd