From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78112C3A5A6 for ; Thu, 29 Aug 2019 15:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CDAC2166E for ; Thu, 29 Aug 2019 15:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567092210; bh=2+HFlzM/yfynG5ANvTwsYTNcTosDJEfLB1NO1x5eKc8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=KBxW0VafjggMMbk6ltI2BNL1eSHr0budDFTty4YXUEwagCGy131f6vy8xAXsHaJFv B7ccPruCHiIZtlLyFunCG26mO2gKKGkC6ku6Gh16oyEjBNSQDE8wHsha7MkSFi+G45 dn/ybY3pdpiNvusfXlmL3QqLoKSqn//xE50eGlSg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbfH2PX0 (ORCPT ); Thu, 29 Aug 2019 11:23:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2PX0 (ORCPT ); Thu, 29 Aug 2019 11:23:26 -0400 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C11972341B for ; Thu, 29 Aug 2019 15:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567092205; bh=2+HFlzM/yfynG5ANvTwsYTNcTosDJEfLB1NO1x5eKc8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GAVnAPkSxjpWAZC93k6hMInjPRKhvc39VTMjooTTdWO7dn7yisl64tavG1j2Q2ZLU MPrSp8U6Vp6wzEg8iWg3R11+R4lOJYRZ6GR2hzR0ihp2fXafPxntv2PlfPsUBCso/C z+0HR98BCFWc7g/gTOZ9HLJZmXNUr9gddpHfPWcA= Received: by mail-wm1-f45.google.com with SMTP id d16so4288453wme.2 for ; Thu, 29 Aug 2019 08:23:24 -0700 (PDT) X-Gm-Message-State: APjAAAXKwkYhBugmPIy5NHdek4J+SEUKkabmz3Sc/q/nczcTpW4LpRx9 WpsmMlRy4OdNH0//ebjEqrLG0YeE+WpBYRvDoaMMuw== X-Google-Smtp-Source: APXvYqxvavrhFMLKkvBENomgDKP8QLeedIChXt62FYtW3S9te9FAf4UqqaK8w3TWd/JOSNU9JURf6QE1EcsgN2GtvFA= X-Received: by 2002:a05:600c:22d7:: with SMTP id 23mr12797740wmg.0.1567092203251; Thu, 29 Aug 2019 08:23:23 -0700 (PDT) MIME-Version: 1.0 References: <20190829111843.41003-1-vincenzo.frascino@arm.com> <20190829111843.41003-3-vincenzo.frascino@arm.com> In-Reply-To: <20190829111843.41003-3-vincenzo.frascino@arm.com> From: Andy Lutomirski Date: Thu, 29 Aug 2019 08:23:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/7] lib: vdso: Build 32 bit specific functions in the right context To: Vincenzo Frascino Cc: linux-arch , linux-arm-kernel , LKML , linux-mips@vger.kernel.org, Catalin Marinas , Will Deacon , Paul Burton , Thomas Gleixner , Mark Salyzyn , Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Lutomirski Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Aug 29, 2019 at 4:19 AM Vincenzo Frascino wrote: > > clock_gettime32 and clock_getres_time32 should be compiled only with a > 32 bit vdso library. > > Exclude these symbols when BUILD_VDSO32 is not defined. Reviewed-by: Andy Lutomirski BTW, this is a great patch: it's either correct or it won't build. I like patches like that.