From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508A0C433E7 for ; Wed, 14 Oct 2020 18:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 003F62222A for ; Wed, 14 Oct 2020 18:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602700535; bh=Pda5e4mTtOE+ZlY6hUmRRRDO7I+9vJoYWhBous9Gcls=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qyJaWFoz/zv9ICAOWKzoRIjdMVglr0g7/vBVUoVER6PjG1NFmjtEZ7MHR1vIX8zAb FIj6faC4Jse4Ygf+IzWaiAQmwHowXxBots7JmhZ+2x+d40Jm8BooQ+A8Ci2sNJIJ60 l7cwnnL6Aqxfxg4p6EbqjERurRQBGzSuuohmg/KE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388617AbgJNSfe (ORCPT ); Wed, 14 Oct 2020 14:35:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:56664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388112AbgJNSfa (ORCPT ); Wed, 14 Oct 2020 14:35:30 -0400 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 322C122267; Wed, 14 Oct 2020 18:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602700529; bh=Pda5e4mTtOE+ZlY6hUmRRRDO7I+9vJoYWhBous9Gcls=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Pofh7UmO7iRQ6dIxMcM+BkYBtJ7jUuuDxYvnx45uCg3oTKCzplu1qgt32rENNlGE+ 6CbsGFGyyKtjPzOfwqXjDpOqeJ9TKaHnrisubMIcT108UpGEmLQHnQg3MzptTLo85b 09GIwDh7G3BzSCkAOxH94vxwT2RuWvy6ESdGDHkk= Received: by mail-ua1-f41.google.com with SMTP id x11so67387uav.1; Wed, 14 Oct 2020 11:35:29 -0700 (PDT) X-Gm-Message-State: AOAM5339it8HidodmOJsfvSdSSyUjlEzrGhA1RS5MKiJtH7XFyV/0TVE CJOoiiX0vI++kId91FjpAg/bjYOjwwz6wCxHiA== X-Google-Smtp-Source: ABdhPJxmywHYTJ4dMOU2YaRv5iUSZXhICQXEppzBvIlKDcu6yZMwhcqON/hhJlbOheAOzFbJbkRhHRpm3BOL3wbOkQ8= X-Received: by 2002:a9d:5e14:: with SMTP id d20mr18868oti.107.1602700527584; Wed, 14 Oct 2020 11:35:27 -0700 (PDT) MIME-Version: 1.0 References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-21-Sergey.Semin@baikalelectronics.ru> <878sc8lx0e.fsf@kernel.org> <20201014143720.yny3jco5pkb7dr4b@mobilestation> In-Reply-To: <20201014143720.yny3jco5pkb7dr4b@mobilestation> From: Rob Herring Date: Wed, 14 Oct 2020 13:35:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name To: Serge Semin Cc: Felipe Balbi , Serge Semin , Mathias Nyman , Greg Kroah-Hartman , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Kukjin Kim , Krzysztof Kozlowski , Santosh Shilimkar , Shawn Guo , Li Yang , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Wei Xu , Andy Gross , Bjorn Andersson , Alexey Malahov , Pavel Parkhomenko , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , Neil Armstrong , Kevin Hilman , linux-arm-kernel , arcml , "open list:MIPS" , linuxppc-dev , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-samsung-soc , linux-omap , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Oct 14, 2020 at 9:37 AM Serge Semin wrote: > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > > > Hi Serge, > > > > Serge Semin writes: > > > In accordance with the DWC USB3 bindings the corresponding node name is > > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > > > > DWC3 is not a simple HDC, though. > > Yeah, strictly speaking it is equipped with a lot of vendor-specific stuff, > which are tuned by the DWC USB3 driver in the kernel. But after that the > controller is registered as xhci-hcd device so it's serviced by the xHCI driver, > which then registers the HCD device so the corresponding DT node is supposed > to be compatible with the next bindings: usb/usb-hcd.yaml, usb/usb-xhci.yaml > and usb/snps,dwc3,yaml. I've created the later one so to validate the denoted > compatibility. > > > > > > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > > > of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have > > > name as "^dwc3@.*" or "^usb[1-3]@.*" or even "^dwusb@.*", which will cause > > > the dtbs_check procedure failure. Let's fix the nodes naming to be > > > compatible with the DWC USB3 DT schema to make dtbs_check happy. > > > > > > Note we don't change the DWC USB3-compatible nodes names of > > > arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the > > > in-source comment says that the nodes name need to be preserved as > > > "^dwusb@.*" for some backward compatibility. > > > > > interesting, compatibility with what? Some debugfs files, perhaps? :-) > > Don't really know.) In my experience the worst type of such compatibility is > connected with some bootloader magic, which may add/remove/modify properties > to nodes with pre-defined names. I seriously doubt anyone is using the APM machines with DT (even ACPI is somewhat doubtful). I say change them. Or remove the dts files and see what happens. Either way it can always be reverted. Rob