From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31545C282DB for ; Mon, 21 Jan 2019 08:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09AE22084A for ; Mon, 21 Jan 2019 08:56:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbfAUI4W (ORCPT ); Mon, 21 Jan 2019 03:56:22 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:43551 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729860AbfAUI4V (ORCPT ); Mon, 21 Jan 2019 03:56:21 -0500 Received: by mail-vs1-f65.google.com with SMTP id x1so12141390vsc.10; Mon, 21 Jan 2019 00:56:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uun2AU3eJW+aX9fhOUjPPIC4XfawfY9i9oS9NgvU6Z4=; b=PA94EDL2K5Zfg09NwyH7gxdqMe6rq+6Bkpa47ZcNK5VdQjSTqyqa6JZ1fXWyPhowNt c6IClQjbx8pFE/DO5rNy0KHS6RVO0Z+e8l+54jRGpTjt/3Z3MvtdLyEe1yvkjhXNRfWI Jb19x2LXb/cYhYPzJwzqsFh08m4oULnJw4cbmRAYyrBjslBCh6QNXjEu8NMYC//eiEaI 8q2SyHlZzA6PLW2azL2DHW41QNoL7qSQtWVaUe1rbaCVmwV/ZIMGcMe9KT6VoBZs1V7P 0pHpWjj1pUONqi0Hsr9coxDhg2flvzYOExkA+SWNwgB6xb7QRbyJJ2B2bU8pd1G85f5q TbBg== X-Gm-Message-State: AJcUukd0PKrObwi5L7kBSeX3zvIe9pZX09bWlI24/MY9yfaYyfnZ/5XX Hs8I2lClRVTqzqukhDI8jX3mUww2/jAy30NFx84= X-Google-Smtp-Source: ALg8bN5Zv5T9HgEze01gQpDUuzyqM6YeldP0GcLXE8vieJqOlkOh/z7Dnz2dgUAbu8nwMIPAviPimX4i+NMBPPzq9wY= X-Received: by 2002:a67:f43:: with SMTP id 64mr11966034vsp.166.1548060979206; Mon, 21 Jan 2019 00:56:19 -0800 (PST) MIME-Version: 1.0 References: <20190118161835.2259170-1-arnd@arndb.de> <20190118161835.2259170-29-arnd@arndb.de> In-Reply-To: <20190118161835.2259170-29-arnd@arndb.de> From: Geert Uytterhoeven Date: Mon, 21 Jan 2019 09:56:06 +0100 Message-ID: Subject: Re: [PATCH v2 28/29] y2038: rename old time and utime syscalls To: Arnd Bergmann Cc: y2038 Mailman List , Linux API , Linux Kernel Mailing List , Linux-Arch , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Michal Simek , Paul Burton , Helge Deller , Benjamin Herrenschmidt , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S. Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "the arch/x86 maintainers" , Max Filippov , Andrew Morton , Deepa Dinamani , "Eric W. Biederman" , Firoz Khan , alpha , Linux ARM , "linux-ia64@vger.kernel.org" , linux-m68k , linux-mips@vger.kernel.org, Parisc List , linuxppc-dev , linux-s390 , Linux-sh list , sparclinux , netdev , Linux FS Devel Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Jan 18, 2019 at 5:21 PM Arnd Bergmann wrote: > The time, stime, utime, utimes, and futimesat system calls are only > used on older architectures, and we do not provide y2038 safe variants > of them, as they are replaced by clock_gettime64, clock_settime64, > and utimensat_time64. > > However, for consistency it seems better to have the 32-bit architectures > that still use them call the "time32" entry points (leaving the > traditional handlers for the 64-bit architectures), like we do for system > calls that now require two versions. > > Note: We used to always define __ARCH_WANT_SYS_TIME and > __ARCH_WANT_SYS_UTIME and only set __ARCH_WANT_COMPAT_SYS_TIME and > __ARCH_WANT_SYS_UTIME32 for compat mode on 64-bit kernels. Now this is > reversed: only 64-bit architectures set __ARCH_WANT_SYS_TIME/UTIME, while > we need __ARCH_WANT_SYS_TIME32/UTIME32 for 32-bit architectures and compat > mode. The resulting asm/unistd.h changes look a bit counterintuitive. > > This is only a cleanup patch and it should not change any behavior. > > Signed-off-by: Arnd Bergmann > arch/m68k/include/asm/unistd.h | 4 ++-- > arch/m68k/kernel/syscalls/syscall.tbl | 10 +++++----- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds