From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61386C2BA83 for ; Wed, 12 Feb 2020 08:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4016321569 for ; Wed, 12 Feb 2020 08:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728422AbgBLIIE (ORCPT ); Wed, 12 Feb 2020 03:08:04 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34811 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728386AbgBLIIE (ORCPT ); Wed, 12 Feb 2020 03:08:04 -0500 Received: by mail-oi1-f195.google.com with SMTP id l136so1222464oig.1; Wed, 12 Feb 2020 00:08:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gxq+7Sc2rUn1eaXQOPvDb63UOLOu7jeHo0xijtFEwKY=; b=XrXoIvtnkGbjIpNA2YfM41QoHSp86bK7CdqIxO59ezTrYyYTKL675TR6Utok2Gr3Fc /tsUNg7tCOFLnD6mWDn/YxaTIO+mtax/SSmyMXZ+Kn1hZZto9gK4otkrx3++5lP5idg3 4/1XRWK1VnCjS7+QsWrCv4NZ1yFkep1d2UhpaLFMeKph50+OKMHqtizhcFgqruTIIvRy +DX4LLbDkJob3InGuIKB0SerEmq9AzZnw+ScCmfm+qZaLaUIxC8h8tmOA1inRSTiH5Uk V1MRpMsF9uFiq5vGtX72Zb1r+0TqnbCmmxaPhaZGtbNx7GGIqIsouABB/en+qfBrL6JL 7zeQ== X-Gm-Message-State: APjAAAWbA2myywO0EYjaKwaymqC1PDIVpQas6nfonupUaAt7vxn1KYI9 E4xFlWhk6UT7CVrG9/MZ+GcHcMp8tMIlD0chMPA= X-Google-Smtp-Source: APXvYqwuciUD6vwdUq4CPbVsyvYm1qjVrqqXMQjb87WUGx79yOvkcjnbAhitCFpK3ey7L0Tzueo+r4X+s+cf+LPG7uM= X-Received: by 2002:aca:48cd:: with SMTP id v196mr5626851oia.102.1581494883264; Wed, 12 Feb 2020 00:08:03 -0800 (PST) MIME-Version: 1.0 References: <4e11dd4183da55012198824ca7b8933b1eb57e4a.1581457290.git.hns@goldelico.com> <20200211222506.GP19213@lunn.ch> In-Reply-To: <20200211222506.GP19213@lunn.ch> From: Geert Uytterhoeven Date: Wed, 12 Feb 2020 09:07:52 +0100 Message-ID: Subject: Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter To: Andrew Lunn Cc: "H. Nikolaus Schaller" , Paul Cercueil , Paul Boddie , Alex Smith , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , David Airlie , Daniel Vetter , "David S. Miller" , Linus Walleij , Andi Kleen , Krzysztof Kozlowski , Geert Uytterhoeven , Miquel Raynal , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Richard Fontana , Allison Randal , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, Linux Kernel Mailing List , DRI Development , Linux I2C , netdev , "open list:GPIO SUBSYSTEM" , letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Type: text/plain; charset="UTF-8" Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Feb 11, 2020 at 11:25 PM Andrew Lunn wrote: > On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote: > > This is needed to give the MIPS Ingenic CI20 board a stable MAC address > > which can be optionally provided by vendor U-Boot. > > > > For get_mac_addr() we use an adapted copy of from ksz884x.c which > > has very similar functionality. > > > > Signed-off-by: H. Nikolaus Schaller > > Hi Nikolaus > > Please split these patches by subsystem. So this one patch needs to go > via netdev. > > > +static char *mac_addr = ":"; > > +module_param(mac_addr, charp, 0); > > +MODULE_PARM_DESC(mac_addr, "MAC address"); > > Module parameters are not liked. > > Can it be passed via device tree? The driver already has code to get > it out of the device tree. Yep, typically U-Boot adds an appropriate "local-mac-address" property to the network device's device node, based on the "ethernet0" alias. However, the real clue here may be "vendor U-Boot", i.e. no support for the above? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds