From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F63C4338F for ; Mon, 23 Aug 2021 10:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDBEE61051 for ; Mon, 23 Aug 2021 10:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233444AbhHWKOY (ORCPT ); Mon, 23 Aug 2021 06:14:24 -0400 Received: from mail-vs1-f50.google.com ([209.85.217.50]:39455 "EHLO mail-vs1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232890AbhHWKOY (ORCPT ); Mon, 23 Aug 2021 06:14:24 -0400 Received: by mail-vs1-f50.google.com with SMTP id e9so10719571vst.6; Mon, 23 Aug 2021 03:13:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QGWlxXbqp4C9V0pOALutj8L5f0IIEa5u3E7vAfklyGo=; b=SIi2V6dyjKIL/fg+PPR92B32IH5ZqM6GbyIP1iquL64x6g9uMeLmGR3icsh4ME06dz WL4kmPrRm4OgnqIi6UCv5lwetbC9ByeOgijrE8Odt0jH06lou5V0NrVrSFK4ZtHYSdAc dDzZ+Uh2Owj9Fp2bQWuBPgIGjmV9IgPhrlEtF9Ia8YWVejqoTngHZlSUQ5xcUXmjXNS+ qyVR6yMAaJWvqCE7a79kgin3vWfvWE3noz8ZBN+IQlJTciFWBqoNvyME5EsIxqxSpeSZ haMQbgPJdbuGLyLDkVTIqIZefdAYKHdrkx+PwrQsxHeTQaBz/QMnF+iorsFTQRJHcJsp qLyg== X-Gm-Message-State: AOAM530Y6/PLy3pogCZt663u6PjFJelhQX+s5KS0Xn6uuuz143EATOjs T4v/FB2UkNfsQXpINWtD5DvWfrHbVDi7P0yBjao= X-Google-Smtp-Source: ABdhPJyH0E1pyhC89wWPYYQoaEHA/nfpaJPSksxoQnbMkworBUBLdcC7hq0D2zToet9d4s7ykx8MrywnipUtR++lG+Q= X-Received: by 2002:a67:6e86:: with SMTP id j128mr22666984vsc.26.1629713621125; Mon, 23 Aug 2021 03:13:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 12:13:29 +0200 Message-ID: Subject: Re: [PATCH v5 0/9] Add generic support for kdump DT properties To: Rob Herring Cc: Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Nick Kossifidis , Paul Walmsley , Palmer Dabbelt , Albert Ou , Frank Rowand , Dave Young , Baoquan He , Vivek Goyal , Mike Rapoport , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:BROADCOM NVRAM DRIVER" , linux-riscv , kexec@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Rob, On Sun, Aug 15, 2021 at 5:25 PM Rob Herring wrote: > On Wed, Aug 11, 2021 at 10:50:58AM +0200, Geert Uytterhoeven wrote: > > This patch series adds generic support for parsing DT properties related > > to crash dump kernels ("linux,elfcorehdr" and "linux,elfcorehdr" under > > the "/chosen" node), makes use of it on arm32, and performs a few > > cleanups. It is an evolution of the combination of [1] and [2]. > > The DT bits look fine to me. How do you expect this to be merged? I'm > happy to take it if arch maintainers can ack it. I had hoped you could take the series... > > The series consists of 6 parts: > > 1. Patch 1 prepares architecture-specific code (needed for MIPS only) > > to avoid duplicating elf core header reservation later. > > 2. Patch 2 prepares the visibility of variables used to hold > > information retrieved from the DT properties. > > 3. Patches 3-5 add support to the FDT core for handling the > > properties. > > This can co-exist safely with architecture-specific handling, until > > the latter has been removed. > > Looks like patch 5 doesn't have any dependencies with the series? Indeed. So you can take it independently. > > 4. Patch 6 removes the non-standard handling of "linux,elfcorehdr" on > > riscv. > > I thought this should be applied for 5.14? Me too, but unfortunately that hasn't happened yet... > > 5. Patches 7-8 convert arm64 to use the generic handling instead of > > its own implementation. > > 6. Patch 9 adds support for kdump properties to arm32. > > The corresponding patch for kexec-tools is "[PATCH] arm: kdump: Add > > DT properties to crash dump kernel's DTB"[3], which is still valid. > > This one can be applied on its own, right? While that wouldn't break anything (i.e. no regression), it still wouldn't work if the DT properties are present, and the now-legacy "mem=" kernel command line parameter is not. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds