From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A5DC433F5 for ; Tue, 4 Oct 2022 11:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbiJDLIu (ORCPT ); Tue, 4 Oct 2022 07:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbiJDLIl (ORCPT ); Tue, 4 Oct 2022 07:08:41 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C733564F0 for ; Tue, 4 Oct 2022 04:08:38 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id h8-20020a17090a054800b00205ccbae31eso18257977pjf.5 for ; Tue, 04 Oct 2022 04:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Gtwwkxm3K9zy3ub+GhlddjjtZ7fh91sG2Y46OOYgmCM=; b=EnhlO7DcICPKJpPG1jb7KTMLBU7DAMNWLzZM/l8aLFUsRZkWp+mkSVMMBmLZ1zgxaC wxY3CYIRcHyRXss5NtxD4hq5yFum2Xsa/Xfa8NFMZbQ3tgmqUq13E1Fcil8BIgM2OEw6 m+P6TSNsaCcBVdUXpgo0TEJ7VOVGVt6KKPFMuMhn/bj0r2dm5zCuaEvX7UiZOqeeJEdX h1wGhs9cmKjNMVwi5bkackIBv98JM8+NjLMoMPaPS3klw1yQNu9dahurEQIN+cDnqkmM Hbcu0L1M6U3Rd654P0n2Hh4Q6bzGWuS7xOAcwB9SuDvPVBJ1Tctv5MAKRuD35o1eodHl dgPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Gtwwkxm3K9zy3ub+GhlddjjtZ7fh91sG2Y46OOYgmCM=; b=jaSTXAJTW2rmM3Sh7oqOZWrYx9Xj69R0ExdUZQWQ1s9nFhxf/UVKZ4F5PIOWPNMuUr V5c0ukVicLyA2j8D+5QTH7wctKlcb7m3Sn1pE07/8z5CxRiG7xD6VDJotEXBmNogmv0R gB6MRsvu1y1QrFqSE36J2ot+Sb45T/eucJl2LNZWU+NltvsB9yV2gjNCMNdoKqHaZchD GhS6STQqUVikm//wZjDl7/Nf9Mv480ly+2rLzSBVARQnR4jIIA88bqGl0gfIEqePBA/E 59k4nXiUv8OgeTaCJBQpoI9snDquxvXmKFsyrKYhSQhh0abFahdcD0VfvouEJgBJDtZW BWyA== X-Gm-Message-State: ACrzQf0QCNSz7X4RM15Bj2/aLEwr/GZUwcfks+TuVnDqIA5w8P2PdFFz MbBbHvRxOKUqg2N+74zOBsjepC9pK8egwSSxyNDCHg== X-Google-Smtp-Source: AMsMyM6cCdnxuhXSy92rYBN/YepwF/hndLawv3zc1vUJoDTHY6JL7u1f8y1gp2OsfAUCoRgnjKuog3OS/wqaN/v/F3w= X-Received: by 2002:a17:90b:1b06:b0:202:cce0:2148 with SMTP id nu6-20020a17090b1b0600b00202cce02148mr17035330pjb.84.1664881717434; Tue, 04 Oct 2022 04:08:37 -0700 (PDT) MIME-Version: 1.0 References: <20220919095939.761690562@infradead.org> <20220919101521.886766952@infradead.org> In-Reply-To: <20220919101521.886766952@infradead.org> From: Ulf Hansson Date: Tue, 4 Oct 2022 13:08:00 +0200 Message-ID: Subject: Re: [PATCH v2 23/44] arm,smp: Remove trace_.*_rcuidle() usage To: Peter Zijlstra Cc: juri.lelli@redhat.com, rafael@kernel.org, catalin.marinas@arm.com, linus.walleij@linaro.org, bsegall@google.com, guoren@kernel.org, pavel@ucw.cz, agordeev@linux.ibm.com, linux-arch@vger.kernel.org, vincent.guittot@linaro.org, mpe@ellerman.id.au, chenhuacai@kernel.org, christophe.leroy@csgroup.eu, linux-acpi@vger.kernel.org, agross@kernel.org, geert@linux-m68k.org, linux-imx@nxp.com, vgupta@kernel.org, mattst88@gmail.com, mturquette@baylibre.com, sammy@sammy.net, pmladek@suse.com, linux-pm@vger.kernel.org, Sascha Hauer , linux-um@lists.infradead.org, npiggin@gmail.com, tglx@linutronix.de, linux-omap@vger.kernel.org, dietmar.eggemann@arm.com, andreyknvl@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, senozhatsky@chromium.org, svens@linux.ibm.com, jolsa@kernel.org, tj@kernel.org, Andrew Morton , mark.rutland@arm.com, linux-ia64@vger.kernel.org, dave.hansen@linux.intel.com, virtualization@lists.linux-foundation.org, James.Bottomley@hansenpartnership.com, jcmvbkbc@gmail.com, thierry.reding@gmail.com, kernel@xen0n.name, cl@linux.com, linux-s390@vger.kernel.org, vschneid@redhat.com, john.ogness@linutronix.de, ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, festevam@gmail.com, deller@gmx.de, daniel.lezcano@linaro.org, jonathanh@nvidia.com, dennis@kernel.org, lenb@kernel.org, linux-xtensa@linux-xtensa.org, kernel@pengutronix.de, gor@linux.ibm.com, linux-arm-msm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev, shorne@gmail.com, chris@zankel.net, sboyd@kernel.org, dinguyen@kernel.org, bristot@redhat.com, alexander.shishkin@linux.intel.com, fweisbec@gmail.com, lpieralisi@kernel.org, atishp@atishpatra.org, linux@rasmusvillemoes.dk, kasan-dev@googlegroups.com, will@kernel.org, boris.ostrovsky@oracle.com, khilman@kernel.org, linux-csky@vger.kernel.org, pv-drivers@vmware.com, linux-snps-arc@lists.infradead.org, mgorman@suse.de, jacob.jun.pan@linux.intel.com, Arnd Bergmann , ulli.kroll@googlemail.com, linux-clk@vger.kernel.org, rostedt@goodmis.org, ink@jurassic.park.msu.ru, bcain@quicinc.com, tsbogend@alpha.franken.de, linux-parisc@vger.kernel.org, ryabinin.a.a@gmail.com, sudeep.holla@arm.com, shawnguo@kernel.org, davem@davemloft.net, dalias@libc.org, tony@atomide.com, amakhalov@vmware.com, konrad.dybcio@somainline.org, bjorn.andersson@linaro.org, glider@google.com, hpa@zytor.com, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, vincenzo.frascino@arm.com, anton.ivanov@cambridgegreys.com, jonas@southpole.se, yury.norov@gmail.com, richard@nod.at, x86@kernel.org, linux@armlinux.org.uk, mingo@redhat.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, richard.henderson@linaro.org, stefan.kristiansson@saunalahti.fi, openrisc@lists.librecores.org, acme@kernel.org, paul.walmsley@sifive.com, linux-tegra@vger.kernel.org, namhyung@kernel.org, andriy.shevchenko@linux.intel.com, jpoimboe@kernel.org, dvyukov@google.com, jgross@suse.com, monstr@monstr.eu, linux-mips@vger.kernel.org, palmer@dabbelt.com, anup@brainfault.org, bp@alien8.de, johannes@sipsolutions.net, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > None of these functions should ever be ran with RCU disabled anymore. > > Specifically, do_handle_IPI() is only called from handle_IPI() which > explicitly does irq_enter()/irq_exit() which ensures RCU is watching. > > The problem with smp_cross_call() was, per commit 7c64cc0531fa ("arm: Use > _rcuidle for smp_cross_call() tracepoints"), that > cpuidle_enter_state_coupled() already had RCU disabled, but that's > long been fixed by commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle > deeper into the idle path"). > > Signed-off-by: Peter Zijlstra (Intel) FWIW: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/arm/kernel/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > --- a/arch/arm/kernel/smp.c > +++ b/arch/arm/kernel/smp.c > @@ -639,7 +639,7 @@ static void do_handle_IPI(int ipinr) > unsigned int cpu = smp_processor_id(); > > if ((unsigned)ipinr < NR_IPI) > - trace_ipi_entry_rcuidle(ipi_types[ipinr]); > + trace_ipi_entry(ipi_types[ipinr]); > > switch (ipinr) { > case IPI_WAKEUP: > @@ -686,7 +686,7 @@ static void do_handle_IPI(int ipinr) > } > > if ((unsigned)ipinr < NR_IPI) > - trace_ipi_exit_rcuidle(ipi_types[ipinr]); > + trace_ipi_exit(ipi_types[ipinr]); > } > > /* Legacy version, should go away once all irqchips have been converted */ > @@ -709,7 +709,7 @@ static irqreturn_t ipi_handler(int irq, > > static void smp_cross_call(const struct cpumask *target, unsigned int ipinr) > { > - trace_ipi_raise_rcuidle(target, ipi_types[ipinr]); > + trace_ipi_raise(target, ipi_types[ipinr]); > __ipi_send_mask(ipi_desc[ipinr], target); > } > > > > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization