From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB46C04FE3 for ; Wed, 4 Aug 2021 11:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8D0860FC4 for ; Wed, 4 Aug 2021 11:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237091AbhHDLNh (ORCPT ); Wed, 4 Aug 2021 07:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235606AbhHDLNc (ORCPT ); Wed, 4 Aug 2021 07:13:32 -0400 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0EE5C06179E for ; Wed, 4 Aug 2021 04:13:17 -0700 (PDT) Received: by mail-vs1-xe2a.google.com with SMTP id x144so798665vsx.3 for ; Wed, 04 Aug 2021 04:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E1t0SNn5x7f6Dj4MvLfPbAe/nFhEaNG0D5+fMN+d0a4=; b=Nf2KyfVLFfCtc3VuPIByG76ejagI+MoZoGEbfaqyQkA4Edo4g7jlqu/TWtLlZBzI2Z s/nx4C8zYdl+AXVtju2jqdk0NwvbRNpbMn7sJOtpBwATeiCEHms9sG0ky0iednIbrJje 8ErulyiXYP6SX4XSHeQER6RRMpM4uVyDS3WvWceptahkfNpmAaeCos8+6XMsuDosj3Yd au34bdb0Q+VMDOHYvMgodwhSP5NRwqRF5rIdxF/LQH5Mqif1pck1+6eRAWRmnVj+viJe OZWCpHHFesk0dsxMLa6m7NXG+cBA/KMcQaOeYi4wnGW8EyM+xI2+ucKP1wcogYE6UXEz wnyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E1t0SNn5x7f6Dj4MvLfPbAe/nFhEaNG0D5+fMN+d0a4=; b=fbs+4VJESC8lnHe65jfOpOHRQj+A1wN+/qKdhnybIb4JBQA0oz30Lqw8frcbunP0vC vHMcAUocIqtAzqhuJVECEDxQ2xU7gBTPUS/0lDQKiCyQtcj76kEZtPIJiuZyNEE+rwhO 5Z2a2gAJehk0Nh/fHUTLV75DIZJOb9qr0EunC0UrBoRQrELevSoB8Ez/fG346kq6NYWR 1mEfbfApHJuc1tkUPAtBz7F04b/71Qjj2f7F09XWPF/UiGfawv1hDFZ/Aj8pTN3QPWnN d0UnwOuqU6GNZcypxlO6lQWYaDc0oE8/D93YNWLu/UXqzIJ8YTmvTz6Y9zWc2w3q7Rzs vBDg== X-Gm-Message-State: AOAM530AnSqI0a7r8/389sLDHa+7/OIvYrNmwKpr79Ve/d34bplnyxSA x2gr74ZUcDvyPNH+dyAyJByi6ljfpjEXms+I1o1Xeg== X-Google-Smtp-Source: ABdhPJyvlEJk0kPUpk5hZjg1GBcfvcfyWBefSBKSC5X0FVKU1TS5OavoWFYJ7J3TB54jujHaG0St1s/ayVgY/H/S0V0= X-Received: by 2002:a67:7c14:: with SMTP id x20mr9690293vsc.42.1628075596862; Wed, 04 Aug 2021 04:13:16 -0700 (PDT) MIME-Version: 1.0 References: <20210712060928.4161649-1-hch@lst.de> <20210712060928.4161649-3-hch@lst.de> In-Reply-To: <20210712060928.4161649-3-hch@lst.de> From: Ulf Hansson Date: Wed, 4 Aug 2021 13:12:40 +0200 Message-ID: Subject: Re: [PATCH 2/6] mmc: mmc_spi: replace flush_kernel_dcache_page with flush_dcache_page To: Christoph Hellwig Cc: Linus Torvalds , Andrew Morton , "James E.J. Bottomley" , Russell King , Guo Ren , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Helge Deller , Yoshinori Sato , Rich Felker , Geoff Levand , Paul Cercueil , Alex Shi , Linux Kernel Mailing List , Linux ARM , linux-csky@vger.kernel.org, linux-mips , linux-parisc@vger.kernel.org, Linux-sh list , linux-mmc , linux-scsi , linux-mm@kvack.org, Linux Documentation Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, 12 Jul 2021 at 08:11, Christoph Hellwig wrote: > > Pages passed to block drivers can be mapped page cache pages, so we > must use flush_dcache_page here instead of the more limited > flush_kernel_dcache_page that is intended for highmem pages only. > > Signed-off-by: Christoph Hellwig Apologies for the delay! Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/mmc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c > index 65c65bb5737f..3d28a3d3001b 100644 > --- a/drivers/mmc/host/mmc_spi.c > +++ b/drivers/mmc/host/mmc_spi.c > @@ -948,7 +948,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, > > /* discard mappings */ > if (direction == DMA_FROM_DEVICE) > - flush_kernel_dcache_page(sg_page(sg)); > + flush_dcache_page(sg_page(sg)); > kunmap(sg_page(sg)); > if (dma_dev) > dma_unmap_page(dma_dev, dma_addr, PAGE_SIZE, dir); > -- > 2.30.2 >