From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB78CA9EAF for ; Mon, 21 Oct 2019 14:58:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1EE420656 for ; Mon, 21 Oct 2019 14:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DoMy1wWt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbfJUO6H (ORCPT ); Mon, 21 Oct 2019 10:58:07 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:38168 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728826AbfJUO6E (ORCPT ); Mon, 21 Oct 2019 10:58:04 -0400 Received: by mail-ua1-f68.google.com with SMTP id 107so3893331uau.5 for ; Mon, 21 Oct 2019 07:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xl5HbtCvAk9GKynQL9GOsijJT7m6YA6GZF9QqoAexoI=; b=DoMy1wWt5SqZIDChScV+zdd7Y/Ie0TLM9sKJrQs2S1hZ+hsiLtUtPUHxCUMMEX8LbO vb3opcGd+/Na4K9DSLQaZaOK1JHr+l+jy0YE6BUfkWll6cIaz78qArRQZsm7zaV6jF/q TbEH7N0DzGXwR4FJv02eq9B2qrJXTP9myHnx6zDjUn3k1fmT6lHKNdfhK6YZjOjXQwxm iJJgca2JS9CzzeIFrgiqXAR40ulixXCiblT2rmpxPf0JYOF/sCaQT7s/wSVAZLyIo2LY r0x2B56H4BEb0qhbjRqzLE0aXuVfEbeXRJz5/OEopQxtmNJmODXX5kZIg130P9JUkZ+H NMQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xl5HbtCvAk9GKynQL9GOsijJT7m6YA6GZF9QqoAexoI=; b=W130JwrxKAXUiMSslKWESLeR8bxc1E7a1/gXApJdsWvF3OwKxl+vqDNAUMasTQLzDz 5i9KYZh34NyXuyMyQWXNQI6UU5ybK7+4FQZvOAi7tu6G7bdYZci3eXNXCkX/XvaLpAOI 9RlbalDxxOHxc546u1x1uicT2qqP2+DHQy3meN/ru0p86qfXiL1z35dMYvuM6XvywaA8 A99eQDmn1Osie59VmwdydUGTxvVyJ4PqWLEv+cOZnhI9FTr9WOnQ5iy1t6RvGPxsGP8x CDQiDM8sFsA7PjcBQXhBCN/1EnLxHFZqe0Z8C6xFi2JVAPPdxrIcaGsAvRzVhkeUcjTD 4B9A== X-Gm-Message-State: APjAAAVDmqKJOCdRv+P+PicdyQ6Tec/MjdgG+GXdsFROcK8STrxiWYR0 QqIUE+dag/HidN58IIacsHuLPhmHYh0hL8w0BEa//g== X-Google-Smtp-Source: APXvYqwR8uDfCggaF5xEo1UJr8wTwbIeCqoiB4/XGD3itd7jHcJkuglR2FjN1rtjKVpnR3u4ZBFOp3qgc5xIPsE/sIw= X-Received: by 2002:ab0:331a:: with SMTP id r26mr6107644uao.104.1571669882589; Mon, 21 Oct 2019 07:58:02 -0700 (PDT) MIME-Version: 1.0 References: <5DA9EE2F.4030603@zoho.com> <47f6-5dab7580-33-5680128@176712317> In-Reply-To: <47f6-5dab7580-33-5680128@176712317> From: Ulf Hansson Date: Mon, 21 Oct 2019 16:57:26 +0200 Message-ID: Subject: Re: [PATCH 6/6 v2] MMC: JZ4740: Add support for LPM. To: Ezequiel Garcia Cc: Zhou Yanjie , Paul Cercueil , linux-mips@vger.kernel.org, Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , DTML , Rob Herring , Paul Burton , Mark Rutland , syq@debian.org, Linus Walleij , armijn@tjaldur.nl, Thomas Gleixner , YueHaibing , Mathieu Malaterre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, 19 Oct 2019 at 22:44, Ezequiel Garcia wrote: > > On Friday, October 18, 2019 13:54 -03, Zhou Yanjie = wrote: > > > > > > > > > > I also have a general question. Should we perhaps rename the driver > > > from jz4740_mmc.c to ingenic.c (and the file for the DT bindings, the > > > Kconfig, etc), as that seems like a more appropriate name? No? > > > > I am very much in favor of this proposal. Now jz4740_mmc.c is not only = used > > for the JZ4740 processor, it is also used for JZ4725, JZ4760, JZ4770, J= Z4780 > > and X1000, and now Ingenic's processor is no longer named after JZ47xx, > > it is divided into three product lines: M, T, and X. It is easy to caus= e > > some > > misunderstandings by using jz4740_mmc.c. At the same time, I think that > > some register names also need to be adjusted. For example, the STLPPL > > register name has only appeared in JZ4730 and JZ4740, and this register > > in all subsequent processors is called CTRL. This time I was confused b= y > > the STLPPL when I added drivers for the JZ4760's and X1000's LPM. > > > > I am very much against renamings, for several reasons. As Paul already me= ntioned, it's pointless and just adds noise to the git-log, making history = harder to recover. Driver file names don't really have to reflect the devic= e > > exactly. For the compatibility list, it's far easier to just git-grep= for compatible strings, or git-grep Documentation and/or Kconfig. I have no strong opinions. What matters to me, is that people agree on the best option, based on a case by case discussion. > > Renaming macros and register names, is equally pointless and equally git-= history invasive. Simply adding some documentation is enough. Sounds like documentation is what people prefer here - and the DT doc seems already fine in regards to that. Perhaps some more words added to the header in driver's c-file could be and option to consider, as today it only mentions "JZ4740 SD/MMC controller driver". Anyway, it's up to you. :-) Kind regards Uffe