Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Paul Burton <paulburton@kernel.org>,
	mips-creator-ci20-dev@googlegroups.com,
	letux-kernel@openphoenux.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Fix gettimeofday() in the vdso library
Date: Fri, 29 Nov 2019 16:09:51 +0100
Message-ID: <DCD7A17F-B045-440E-AB66-7F8AB72A19CA@goldelico.com> (raw)
In-Reply-To: <0b64c6bb-ffc7-059d-3cb3-012092e0fcf0@arm.com>


> Am 29.11.2019 um 15:58 schrieb Vincenzo Frascino <vincenzo.frascino@arm.com>:
> 
> On 11/29/19 2:52 PM, H. Nikolaus Schaller wrote:
>> 
>>> Am 29.11.2019 um 15:36 schrieb Vincenzo Frascino <vincenzo.frascino@arm.com>:
>>> 
>>> The libc provides a discovery mechanism for vDSO library and its
>>> symbols. When a symbol is not exposed by the vDSOs the libc falls back
>>> on the system calls.
>>> 
>>> With the introduction of the unified vDSO library on mips this behavior
>>> is not honored anymore by the kernel in the case of gettimeofday().
>>> 
>>> The issue has been noticed and reported due to a dhclient failure on the
>>> CI20 board:
>>> 
>>> root@letux:~# dhclient
>>> ../../../../lib/isc/unix/time.c:200: Operation not permitted
>>> root@letux:~#
>>> 
>>> Restore the original behavior fixing gettimeofday() in the vDSO library.
>>> 
>>> Cc: Paul Burton <paulburton@kernel.org>
>>> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> Testes-by: H. Nikolaus Schaller <hns@goldelico.com> # CI20 with JZ4780
>> ^^^ funny typo... -> Tested-by:
> 
> Ops, I copy-pasted it from your email ;) Can't trust you ;)

No :)

Well, typos happen and nobody seems to notice. My favourite:

5f9e832c137075045d15cd6899ab0505cfb2ca4b

BR,
Nikolaus


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 14:36 Vincenzo Frascino
2019-11-29 14:52 ` H. Nikolaus Schaller
2019-11-29 14:58   ` Vincenzo Frascino
2019-11-29 15:09     ` H. Nikolaus Schaller [this message]
2019-12-02 19:48 ` Paul Burton

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCD7A17F-B045-440E-AB66-7F8AB72A19CA@goldelico.com \
    --to=hns@goldelico.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mips-creator-ci20-dev@googlegroups.com \
    --cc=paulburton@kernel.org \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git