Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include
       [not found] <20170118001403.GJ27312@n2100.armlinux.org.uk>
@ 2017-01-31 19:17 ` Russell King - ARM Linux
  2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
                     ` (13 more replies)
  0 siblings, 14 replies; 26+ messages in thread
From: Russell King - ARM Linux @ 2017-01-31 19:17 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: Andrew Lunn, Anna Schumaker, David S. Miller, Derek Chickles,
	Felix Manlunas, Florian Fainelli, J. Bruce Fields, Jeff Layton,
	Jiri Slaby, Kalle Valo, Luis R. Rodriguez, Madalin Bucur,
	Microchip Linux Driver Support, Nicholas A. Bellinger,
	Nick Kossifidis, Nicolas Ferre, Raghu Vatsavayi, Ralf Baechle,
	Satanand Burla, Thomas Petazzoni, Timur Tabi, Trond Myklebust,
	Vivien Didelot, Woojung Huh

Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
unnecessary dependency for quite a large amount of the kernel.  There's
very little which actually requires definitions from phy.h in net/dsa.h
- the include itself only wants the declaration of a couple of
structures and IFNAMSIZ.

Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
and phy_fixed.h from net/dsa.h.

This patch reduces from around 800 files rebuilt to around 40 - even
with ccache, the time difference is noticable.

In order to make this change, several drivers need to be updated to
include necessary headers that they were picking up through this
include.  This has resulted in a much larger patch series.

I'm assuming the 0-day builder has had 24 hours with this series, and
hasn't reported any further issues with it - the last issue was two
weeks ago (before I became ill) which I fixed over the last weekend.

I'm hoping this doesn't conflict with what's already in net-next...

 arch/mips/cavium-octeon/octeon-platform.c             | 4 ----
 drivers/net/dsa/mv88e6xxx/mv88e6xxx.h                 | 1 +
 drivers/net/ethernet/broadcom/bgmac.c                 | 2 ++
 drivers/net/ethernet/cadence/macb.h                   | 2 ++
 drivers/net/ethernet/cavium/liquidio/lio_main.c       | 1 +
 drivers/net/ethernet/cavium/liquidio/lio_vf_main.c    | 1 +
 drivers/net/ethernet/cavium/liquidio/octeon_console.c | 1 +
 drivers/net/ethernet/freescale/fman/fman_memac.c      | 1 +
 drivers/net/ethernet/marvell/mvneta.c                 | 1 +
 drivers/net/ethernet/qualcomm/emac/emac-sgmii.c       | 1 +
 drivers/net/usb/lan78xx.c                             | 1 +
 drivers/net/wireless/ath/ath5k/ahb.c                  | 2 +-
 drivers/target/iscsi/iscsi_target_login.c             | 1 +
 include/net/dsa.h                                     | 6 ++++--
 net/core/netprio_cgroup.c                             | 1 +
 net/sunrpc/xprtrdma/svc_rdma_backchannel.c            | 1 +
 16 files changed, 20 insertions(+), 7 deletions(-)

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
@ 2017-01-31 19:18   ` Russell King
  2017-01-31 19:48     ` Anna Schumaker
  2017-01-31 19:18   ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
                     ` (12 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, J. Bruce Fields, Jeff Layton,
	Trond Myklebust, Anna Schumaker

Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc
code:

net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put':
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_setup_rdma_bc':
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]

Fix this by adding linux/module.h to svc_rdma_backchannel.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
index 288e35c2d8f4..cb1e48e54eb1 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
@@ -4,6 +4,7 @@
  * Support for backward direction RPCs on RPC/RDMA (server-side).
  */
 
+#include <linux/module.h>
 #include <linux/sunrpc/svc_rdma.h>
 #include "xprt_rdma.h"
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 02/13] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
  2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
                     ` (11 subsequent siblings)
  13 siblings, 0 replies; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL v2");
                   ^~~~~~~~

Add linux/module.h to fix this.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 net/core/netprio_cgroup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
index 2ec86fc552df..756637dc7a57 100644
--- a/net/core/netprio_cgroup.c
+++ b/net/core/netprio_cgroup.c
@@ -13,6 +13,7 @@
 
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/module.h>
 #include <linux/string.h>
 #include <linux/errno.h>
 #include <linux/skbuff.h>
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
  2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
  2017-01-31 19:18   ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-02-01  9:40     ` Nicolas Ferre
  2017-01-31 19:18   ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
                     ` (10 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Nicolas Ferre

drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration
drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier
drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface
drivers/net/ethernet/cadence/macb.h:877:1: sparse: Expected ; at the end of type declaration
drivers/net/ethernet/cadence/macb.h:877:1: sparse: got }
In file included from drivers/net/ethernet/cadence/macb_pci.c:29:0:
drivers/net/ethernet/cadence/macb.h:862:2: error: unknown type name 'phy_interface_t'
     phy_interface_t  phy_interface;
     ^~~~~~~~~~~~~~~

Add linux/phy.h to macb.h

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/cadence/macb.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
index d67adad67be1..383da8cf5f6d 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -10,6 +10,8 @@
 #ifndef _MACB_H
 #define _MACB_H
 
+#include <linux/phy.h>
+
 #define MACB_GREGS_NBR 16
 #define MACB_GREGS_VERSION 2
 #define MACB_MAX_QUEUES 8
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 04/13] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (2 preceding siblings ...)
  2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-01-31 19:18   ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
                     ` (9 subsequent siblings)
  13 siblings, 0 replies; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Woojung Huh,
	Microchip Linux Driver Support

drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration
drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier
drivers/net/usb/lan78xx.c:394:33: sparse: got interface
drivers/net/usb/lan78xx.c:403:1: sparse: Expected ; at the end of type declaration
drivers/net/usb/lan78xx.c:403:1: sparse: got }

Add linux/phy.h to lan78xx.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/usb/lan78xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 08f8703e4d54..9889a70ff4f6 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -35,6 +35,7 @@
 #include <linux/irq.h>
 #include <linux/irqchip/chained_irq.h>
 #include <linux/microchipphy.h>
+#include <linux/phy.h>
 #include "lan78xx.h"
 
 #define DRIVER_AUTHOR	"WOOJUNG HUH <woojung.huh@microchip.com>"
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (3 preceding siblings ...)
  2017-01-31 19:18   ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-02-01  9:55     ` Rafał Miłecki
  2017-01-31 19:18   ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
                     ` (8 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus'
drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1198:2: error: implicit declaration of function 'phy_stop' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1239:9: error: implicit declaration of function 'phy_mii_ioctl' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1389:28: error: 'phy_ethtool_get_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1390:28: error: 'phy_ethtool_set_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1403:13: error: dereferencing pointer to incomplete type 'struct phy_device'
drivers/net/ethernet/broadcom/bgmac.c:1417:3: error: implicit declaration of function 'phy_print_status' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1424:26: error: storage size of 'fphy_status' isn't known
drivers/net/ethernet/broadcom/bgmac.c:1424:9: error: variable 'fphy_status' has initializer but incomplete type
drivers/net/ethernet/broadcom/bgmac.c:1425:11: warning: excess elements in struct initializer
drivers/net/ethernet/broadcom/bgmac.c:1425:3: error: unknown field 'link' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1426:12: note: in expansion of macro 'SPEED_1000'
drivers/net/ethernet/broadcom/bgmac.c:1426:3: error: unknown field 'speed' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1427:13: note: in expansion of macro 'DUPLEX_FULL'
drivers/net/ethernet/broadcom/bgmac.c:1427:3: error: unknown field 'duplex' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1432:12: error: implicit declaration of function 'fixed_phy_register' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1432:31: error: 'PHY_POLL' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1438:8: error: implicit declaration of function 'phy_connect_direct' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1541:15: error: expected declaration specifiers or '...' before string constant

Add linux/phy.h to bgmac.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/broadcom/bgmac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 0e066dc6b8cc..58a2bd3c0458 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -12,6 +12,8 @@
 #include <linux/bcma/bcma.h>
 #include <linux/etherdevice.h>
 #include <linux/bcm47xx_nvram.h>
+#include <linux/phy.h>
+#include <linux/phy_fixed.h>
 #include "bgmac.h"
 
 static bool bgmac_wait_value(struct bgmac *bgmac, u16 reg, u32 mask,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 06/13] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (4 preceding siblings ...)
  2017-01-31 19:18   ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
                     ` (7 subsequent siblings)
  13 siblings, 0 replies; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Madalin Bucur

drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status'

Add linux/phy_fixed.h to fman_memac.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/freescale/fman/fman_memac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 71a5ded9d1de..cd6a53eaf161 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -38,6 +38,7 @@
 #include <linux/slab.h>
 #include <linux/io.h>
 #include <linux/phy.h>
+#include <linux/phy_fixed.h>
 #include <linux/of_mdio.h>
 
 /* PCS registers */
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (5 preceding siblings ...)
  2017-01-31 19:18   ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
@ 2017-01-31 19:18   ` Russell King
  2017-02-01 10:27     ` Thomas Petazzoni
  2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
                     ` (6 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:18 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Thomas Petazzoni

drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known
drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known
drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type
drivers/net/ethernet/marvell/mvneta.c:2709:2: error: implicit declaration of function 'fixed_phy_update_state' [-Werror=implicit-function-declaration]

Add linux/phy_fixed.h to mvneta.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/marvell/mvneta.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index e05e22705cf7..eb0eb3e62ca0 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -28,6 +28,7 @@
 #include <linux/of_mdio.h>
 #include <linux/of_net.h>
 #include <linux/phy.h>
+#include <linux/phy_fixed.h>
 #include <linux/platform_device.h>
 #include <linux/skbuff.h>
 #include <net/hwbm.h>
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (6 preceding siblings ...)
  2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-01-31 20:15     ` Timur Tabi
  2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
                     ` (5 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Timur Tabi

drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device'

Add linux/phy.h to emac-sgmii.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
index bf722a9bb09d..5e31fb7e4ab8 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
@@ -16,6 +16,7 @@
 #include <linux/iopoll.h>
 #include <linux/acpi.h>
 #include <linux/of_device.h>
+#include <linux/phy.h>
 #include "emac.h"
 #include "emac-mac.h"
 #include "emac-sgmii.h"
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (7 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-01-31 19:32     ` Bart Van Assche
  2017-01-31 19:19   ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
                     ` (4 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Nicholas A. Bellinger

drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]

Add linux/module.h to iscsi_target_login.c.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/target/iscsi/iscsi_target_login.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index 450f51deb2a2..eab274d17b5c 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -17,6 +17,7 @@
  ******************************************************************************/
 
 #include <crypto/hash.h>
+#include <linux/module.h>
 #include <linux/string.h>
 #include <linux/kthread.h>
 #include <linux/idr.h>
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*()
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (8 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
                     ` (3 subsequent siblings)
  13 siblings, 0 replies; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Ralf Baechle

octeon-platform.c can not be built as a module for two reasons:

(a) the Makefile doesn't allow it:
    obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o

(b) the multiple *_initcall() statements, each of which are translated
    to a module_init() call when attempting a module build, become
    aliases to init_module().  Having more than one alias will cause a
    build error.

Hence, rather than adding a linux/module.h include, remove the redundant
MODULE_*() from this file.

Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 37a932d9148c..8297ce714c5e 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -1060,7 +1060,3 @@ static int __init octeon_publish_devices(void)
 	return of_platform_bus_probe(NULL, octeon_ids, NULL);
 }
 arch_initcall(octeon_publish_devices);
-
-MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Platform driver for Octeon SOC");
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (9 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-02-01 19:07     ` Felix Manlunas
  2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
                     ` (2 subsequent siblings)
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Derek Chickles,
	Satanand Burla, Felix Manlunas, Raghu Vatsavayi

drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:36: error: expected ')' before 'int'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:37: error: expected ')' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: parameter names (without types) in function declaration
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: error: type defaults to 'int' in declaration of 'module_init'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: parameter names (without types) in function declaration
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: error: type defaults to 'int' in declaration of 'module_exit'
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: parameter names (without types) in function declaration
drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:36: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:37: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:38: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:39: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:40: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:41: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:42: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: expected declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:43: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: function declaration isn't a prototype
drivers/net/ethernet/cavium/liquidio/lio_main.c:46: error: expected ')' before 'int'
drivers/net/ethernet/cavium/liquidio/lio_main.c:48: error: expected ')' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:53: error: expected ')' before 'int'
drivers/net/ethernet/cavium/liquidio/lio_main.c:54: error: expected ')' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:57: error: expected ')' before 'sizeof'
drivers/net/ethernet/cavium/liquidio/lio_main.c:58: error: expected ')' before string constant
drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: data definitionhas no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:498: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: parameter names (without types) in function declaration
drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_recv_vf_drv_notice':
drivers/net/ethernet/cavium/liquidio/lio_main.c:4393: error: implicit declaration of function 'try_module_get'
drivers/net/ethernet/cavium/liquidio/lio_main.c:4400: error: implicit declaration of function 'module_put'
drivers/net/ethernet/cavium/liquidio/lio_main.c: At top level:
drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: error: type defaults to 'int' in declaration of 'module_init'
drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: parameter names (without types) in function declaration
drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: data definition has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: error: type defaults to 'int' in declaration of 'module_exit'
drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: parameter names (without types) in function declaration

Add linux/module.h to both these files.

drivers/net/ethernet/cavium/liquidio/octeon_console.c:40:31: error: expected ')' before 'int'
drivers/net/ethernet/cavium/liquidio/octeon_console.c:42:4: error: expected ')' before string constant

Add linux/moduleparam.h to this file.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c       | 1 +
 drivers/net/ethernet/cavium/liquidio/lio_vf_main.c    | 1 +
 drivers/net/ethernet/cavium/liquidio/octeon_console.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 39a9665c9d00..e4dd39440687 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -15,6 +15,7 @@
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or
  * NONINFRINGEMENT.  See the GNU General Public License for more details.
  ***********************************************************************/
+#include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/firmware.h>
 #include <net/vxlan.h>
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
index 70d96c10c673..b98d29827a0d 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
@@ -15,6 +15,7 @@
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or
  * NONINFRINGEMENT.  See the GNU General Public License for more details.
  ***********************************************************************/
+#include <linux/module.h>
 #include <linux/pci.h>
 #include <net/vxlan.h>
 #include "liquidio_common.h"
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_console.c b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
index 3265e0b7923e..964058c55d47 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_console.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
@@ -18,6 +18,7 @@
 /**
  * @file octeon_console.c
  */
+#include <linux/moduleparam.h>
 #include <linux/pci.h>
 #include <linux/netdevice.h>
 #include <linux/crc32.h>
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (10 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-02-01  5:34     ` Kalle Valo
  2017-01-31 19:19   ` [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes Russell King
  2017-02-01  2:42   ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli
  13 siblings, 1 reply; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Jiri Slaby, Nick Kossifidis,
	Luis R. Rodriguez, Kalle Valo

Fix these errors reported by the 0-day builder by replacing the
linux/export.h include with linux/module.h.

In file included from include/linux/platform_device.h:14:0,
                 from drivers/net/wireless/ath/ath5k/ahb.c:20:
include/linux/device.h:1463:1: warning: data definition has no type or storage class
 module_init(__driver##_init); \
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1463:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
 module_init(__driver##_init); \
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
In file included from include/linux/platform_device.h:14:0,
                 from drivers/net/wireless/ath/ath5k/ahb.c:20:
include/linux/device.h:1468:1: warning: data definition has no type or storage class
 module_exit(__driver##_exit);
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1468:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
 module_exit(__driver##_exit);
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
In file included from include/linux/platform_device.h:14:0,
                 from drivers/net/wireless/ath/ath5k/ahb.c:20:
drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_exit' defined but not used [-Wunused-function]
 module_platform_driver(ath_ahb_driver);
                        ^
include/linux/device.h:1464:20: note: in definition of macro 'module_driver'
 static void __exit __driver##_exit(void) \
                    ^~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_init' defined but not used [-Wunused-function]
 module_platform_driver(ath_ahb_driver);
                        ^
include/linux/device.h:1459:19: note: in definition of macro 'module_driver'
 static int __init __driver##_init(void) \
                   ^~~~~~~~
drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(ath_ahb_driver);
 ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/wireless/ath/ath5k/ahb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 2ca88b593e4c..c0794f5988b3 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -16,10 +16,10 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
+#include <linux/module.h>
 #include <linux/nl80211.h>
 #include <linux/platform_device.h>
 #include <linux/etherdevice.h>
-#include <linux/export.h>
 #include <ath25_platform.h>
 #include "ath5k.h"
 #include "debug.h"
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (11 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
@ 2017-01-31 19:19   ` Russell King
  2017-02-01  2:42   ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli
  13 siblings, 0 replies; 26+ messages in thread
From: Russell King @ 2017-01-31 19:19 UTC (permalink / raw)
  To: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, Andrew Lunn, Vivien Didelot

Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
unnecessary dependency for quite a large amount of the kernel.  There's
very little which actually requires definitions from phy.h in net/dsa.h
- the include itself only wants the declaration of a couple of
structures and IFNAMSIZ.

Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
and phy_fixed.h from net/dsa.h.

This patch reduces from around 800 files rebuilt to around 40 - even
with ccache, the time difference is noticable.

Tested-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
 include/net/dsa.h                     | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
index af54baea47cf..3a949095068a 100644
--- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
+++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
@@ -15,6 +15,7 @@
 #include <linux/if_vlan.h>
 #include <linux/irq.h>
 #include <linux/gpio/consumer.h>
+#include <linux/phy.h>
 
 #ifndef UINT64_MAX
 #define UINT64_MAX		(u64)(~((u64)0))
diff --git a/include/net/dsa.h b/include/net/dsa.h
index b122196d5a1f..887b2f98f9ea 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -11,15 +11,17 @@
 #ifndef __LINUX_NET_DSA_H
 #define __LINUX_NET_DSA_H
 
+#include <linux/if.h>
 #include <linux/if_ether.h>
 #include <linux/list.h>
 #include <linux/timer.h>
 #include <linux/workqueue.h>
 #include <linux/of.h>
-#include <linux/phy.h>
-#include <linux/phy_fixed.h>
 #include <linux/ethtool.h>
 
+struct phy_device;
+struct fixed_phy_status;
+
 enum dsa_tag_protocol {
 	DSA_TAG_PROTO_NONE = 0,
 	DSA_TAG_PROTO_DSA,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
@ 2017-01-31 19:32     ` Bart Van Assche
  2017-01-31 19:32       ` Bart Van Assche
  0 siblings, 1 reply; 26+ messages in thread
From: Bart Van Assche @ 2017-01-31 19:32 UTC (permalink / raw)
  To: linux-usb, linux-mips, linux-nfs, rmk+kernel, linux-scsi,
	target-devel, netdev, linux-wireless
  Cc: davem, f.fainelli, nab

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
From Anna.Schumaker@netapp.com Tue Jan 31 20:49:19 2017
Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 31 Jan 2017 20:49:27 +0100 (CET)
Received: from mx144.netapp.com ([216.240.21.25]:30617 "EHLO mx144.netapp.com"
        rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP
        id S23993899AbdAaTtTu5Hxi (ORCPT <rfc822;linux-mips@linux-mips.org>);
        Tue, 31 Jan 2017 20:49:19 +0100
X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; 
   d="scan'208";a="174051109"
Received: from vmwexchts01-prd.hq.netapp.com ([10.122.105.12])
  by mx144-out.netapp.com with ESMTP; 31 Jan 2017 11:40:54 -0800
Received: from VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) by
 VMWEXCHTS01-PRD.hq.netapp.com (10.122.105.12) with Microsoft SMTP Server
 (TLS) id 15.0.1210.3; Tue, 31 Jan 2017 11:48:12 -0800
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.120.60.153)
 by VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) with Microsoft SMTP Server
 (TLS) id 15.0.1210.3 via Frontend Transport; Tue, 31 Jan 2017 11:48:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netapp.onmicrosoft.com; s=selector1-netapp-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=uOWCiHoJOkeJ03T4mq0DkYm1YX/LM+dO6vMB4b4yogo=;
 b=ol0wo4fSJiK9ThT5aRZzpKEfdIMlk3oOq2hVjsGGH5cB8RvD0evUS3Rd+bd6P79YOdedQzTjOZbnvMA6Vkp1Cuz32mD4CUgmpIldMDVS9cbU1T3iav5x4hBPocr9jbxDnHDHYgCAkphs+kXVAQ723EPvkCqNQHvhqCzrKJJQUKQ=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Anna.Schumaker@netapp.com; 
Received: from gouda.nowheycreamery.com (68.40.188.1) by
 BLUPR0601MB1635.namprd06.prod.outlook.com (10.163.212.141) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Tue, 31
 Jan 2017 19:48:07 +0000
Subject: Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when
 linux/phy*.h is removed from net/dsa.h
To:     Russell King <rmk+kernel@armlinux.org.uk>,
        <linux-mips@linux-mips.org>, <linux-nfs@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <target-devel@vger.kernel.org>
References: <20170131191704.GA8281@n2100.armlinux.org.uk>
 <E1cYdwi-0000Vs-97@rmk-PC.armlinux.org.uk>
CC:     "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Jeff Layton <jlayton@poochiereds.net>,
        Trond Myklebust <trond.myklebust@primarydata.com>
From:   Anna Schumaker <Anna.Schumaker@Netapp.com>
Message-ID: <52ceb082-1e0a-7210-833a-f4ac22df4b8c@Netapp.com>
Date:   Tue, 31 Jan 2017 14:48:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <E1cYdwi-0000Vs-97@rmk-PC.armlinux.org.uk>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [68.40.188.1]
X-ClientProxiedBy: MWHPR14CA0052.namprd14.prod.outlook.com (10.173.97.142) To
 BLUPR0601MB1635.namprd06.prod.outlook.com (10.163.212.141)
X-MS-Office365-Filtering-Correlation-Id: 0b097ef3-bc3b-4f54-2fb0-08d44a12156a
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BLUPR0601MB1635;
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;3:pqQdKQnggVpXZO9kxDGGHXk3jnYxph8zNcHgN123tPYZ6V21FkmUKK0KLfpFZbd+MDx48Y0ZQpEnYayQEqbYLIkxb7/pSsJp3oY5Bhd+WbIJ0q3evXFvZdFo3FjGg4WAq5/JqKpcF7V0bqktVaq//9kN78GINRzSysWksyulT3TfakRpmVsM36PjLeZSP/4cLUUi5Kzzn1skeyeYJWvtzZp73Nx/AOAljKKRPlEiRUDnt1dHDecckXOis6u0phWDVu08AwmgkFAdIiINYOrkZw==;25:H7evsomXQrGUJrzkwAjsHBn39ESJypT6h+oQ+JNNzHEslcZvDqHRnC2tk9i4xWdrrvNG9wh4wcGOHqNqCnHeP6e9gYLkkjj9bTIbJAUmcpcL09H1OH7UdlAdr6wrUdcgT7dSyk5LMslrROICSbXM4dDjzhX1+yPj8s9lB0B3jvFNH0l5bWGFlpnl3NrBNHq19gOTlqnWTSHtQ4apE15BGNQEFZNDWMMlRYMuZic6gea+oTDiqzO2Quc74TdaA8Xt9RrzZjdWkWU4IRD+XpE144MAyHFxSkXClXdfQdrM/F4mixCqJVwGPwIJX3VfsUyMBQEUClXefVyqxw7Xi6B72Luc5Nj0i8zqy4h0uHjhwrbIgUMbMUt+KfY4YtK7l3gbXLhWN/7+XQJIYnDyk3jxrslCa0L+d1zQY2pCDLuRshKuyQeZgbzQ90iwKYcsrPt1zu7bN7c3J3a0pPBVUehDzQ==
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;31:FPynjvJrN9BMI8B3BNKoHQkq1MZPPqM9Mif8RRC77N4dy/1NVfuzSCbBPJYGZxYQfB35q8mJQr8+wQMIURjD8hck35fQcmnHgXOtwuiI90Bv8C2Wc5N1G6505tSQ5ZxLCA2DeFILxXP1EzReathqsjxXM9411zYE/+hRo/96CobErHkKQAaOQ4U98daErgLDyxfkzOgDJcagj6ez8EggXhEXWq5iTp9xPdyuORAKOIjADnlwM+sMXNr+CNw/OueblnlA2UPQprhodUnwmwBwFw==;20:xVlh5kgHDL3g/cNSrQRJrpzu52Dk4hxyD2EiNs8FNLwfYYTFGTUKZhOnIs/+ft1bP6Biqs1UOV6MuXEb6uF+6OBYYy9BnC/yR/ActKjccGVN1jfBmDHvpPr68hklyHGKYRA4WYnW3UDCywPy31Af7MuKIJFlmOlhvLLgWBD8Dpxy8L+tJPCHVigb5ABrGrIxDmtSfXLJ1CcvBHDtaueLCFcnZ7GKTldFgZz3oWSMFoueivz6+gWTTlaX0cAZVRNTQo1Be+kabWW/EXiObi2tLeNfrW/MjpKdie3GEt2EopCIhtS9JNI5SkSW8Inf4AxxJcz+91rTAqz0g0WqpNSZe3I2i/7smCTmGUUvUsRlNGcmUa1WL/F//xFIyq5sHWNCDQ7GUAM1hwEbNYYK91EP5hmoG5KUCpgtfPGuP46xmZ7tgUtzZx664uTwUfUYrqujW6KVpn9A9ebV1rnx6NnoW1Z5v4rjB05ESqmoFAfEQJTaZh8hfftrcxHjQlMgGfEu
X-Microsoft-Antispam-PRVS: <BLUPR0601MB1635ECE13E0623F977ABE259F84A0@BLUPR0601MB1635.namprd06.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BLUPR0601MB1635;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0601MB1635;
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;4:WQ7hukXGogirq7lIFOPEnAoI8nYeiVQTHRF99OC/Sqdesvzz3Db5RBEQyDc1X+Z1oaFO88whk5vJ9CLLTfJfqu8R1auysiV+GLuxQkA/de715ZF1L6heZV7rTK+IlpUB08sBInyIEEC/1W6EEWYnCoqrSaBaGisyPouSPv1tmdpAz5RlgXS2ayDnihpnydFI6QBzDh6w8bd4jSASZZAbrepu+CnYajsWP/OuUzroj/AgEZ3EEKA4lKZ749ozJTZaHwbkBTnuNt5xhmSkUl2WBGWuNgRde6Dtg3utXQOcUqrzj2k0Q7azJqoVXjI5S4RXpRaVeqOfrLuq1WEk+QJvEwuszcfbrlyu5FqSlwB2DyRlICzL+yEPCQ0okUwUImwMiVOJW+Oz8cz0aNeqIw/RXq64qCoydJWU6zoDlPiM+QxhbJ096LAqkH8wSaDJgXsuMfIPybA9L2l6Bz+PvAr9/uRXkBgZcJEfROCiFXDmXwrBIklyk67YFLqdChSNc1Xjzd4qlzcF6U2W/U4gEgEt79/WndCJhlWxeoSMFMRVvSFrwHya2i2/2FuJyYTfcO/74VjNYS5Wjw00QFP/v/+G4w==
X-Forefront-PRVS: 0204F0BDE2
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(377454003)(24454002)(189002)(199003)(6506006)(39060400001)(97736004)(42186005)(229853002)(38730400001)(4001350100001)(31686004)(54906002)(6512007)(92566002)(83506001)(36756003)(3846002)(6486002)(53936002)(69596002)(101416001)(189998001)(81166006)(76176999)(54356999)(64126003)(8676002)(50986999)(50466002)(81156014)(25786008)(47776003)(4326007)(2906002)(6666003)(106356001)(68736007)(5001770100001)(6116002)(53416004)(105586002)(66066001)(305945005)(33646002)(7736002)(5660300001)(31696002)(23676002)(86362001)(65826007)(2201001)(2950100002)(7416002)(65956001)(230700001)(65806001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0601MB1635;H:gouda.nowheycreamery.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
Received-SPF: None (protection.outlook.com: netapp.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA2MDFNQjE2MzU7MjM6S1UrUys0dElrLzNLSC90RWxFUjJvNy83?=
 =?utf-8?B?WDhHRHcxaDBSVDV2STBKWGg3LzFMOWdHOGwzc3E3WWVlakpnRkV1STFmWmcw?=
 =?utf-8?B?dmdyZFhrczZGRGRuM0pQQzU2bCs3L2E3M0IzV09HWkFmK1JWenVHQ3FiRzJH?=
 =?utf-8?B?UlVQVGFNdW1vT1VVZWJxWWRZYUJhakhlVDd3NTRnU09wU3FFdXdROWkwWHhV?=
 =?utf-8?B?QTYwazdpU1NhdTlZcDErZCtDVVRNblYwY1dOUU1HY0dPcTd3U3BpNW5XdlI4?=
 =?utf-8?B?eHJlRGN3RGFiRHNEblQzcXhTc0FyZm5kdGxpUW0xbWlIeDRtSkpJWmI5MXlm?=
 =?utf-8?B?QU0ycFJuOHg4bTc4dTAyTmUxOXlKYzRFeEdrdktoQjhOUzJ4SmE1NTRiUnFY?=
 =?utf-8?B?QjMwMTRzZjBsWFd2ZDFmSFZlby81OVdQc0tPQUsyait4ZXl6cWNtdEk2OU5B?=
 =?utf-8?B?VVVubElKOGtCU1d5R3FJa3hNR2toajlKRTNKZGhsVm9haHYrdzFYMUgyUDJw?=
 =?utf-8?B?UGVidjAvNDNveklLUHg4enJJY21DbzRubWZLVnNDWWQ5bTFFQ0NoQ1VTdm8y?=
 =?utf-8?B?blRLK3dsWUZlVGtvSmZwZnJmeWpEVXFVZEViRm9ma0psb0RnKzYrQ0d0dTFz?=
 =?utf-8?B?MVFxS3lFbG9ZL0U4OE9tZVNhZkVSZThkRWptWi9lMDJKYTlvbUYyQkhKRWx4?=
 =?utf-8?B?YXlBK0ZDNkowLzZBN1RiMW5SSU9MbG5XWFd2ZXhVaG9xZG9ob2JXcUl5UDl3?=
 =?utf-8?B?SldUR25EendDamQ4U3B4L0pGWlhoYm9HVEpIUEVxSVJwYkFxbE8xcWprTllS?=
 =?utf-8?B?ajV4cW9qbnR2VXBaQ01MK3RMODNlWitvb0VuZ3B6bTRKSFdKTmsvZ1pOTisz?=
 =?utf-8?B?Sy9zZVFYYTgxTWhrT0Y2Z1lRc1d3SWV1cFJNZm1MTU5DMEpLZkpLekUyM2FX?=
 =?utf-8?B?L3dVa3FoVlNIdllOZFhmK3JkS3JOZEswdXV1RU5sVTZaR1NqM3AwSlg0NHpx?=
 =?utf-8?B?amF2bkFXSzVIVi9HSFl6RkUzRGpHK1U3UzVsNjd6bi92ZUNFc2NsV29WVzdY?=
 =?utf-8?B?RU4yV3BYZ1RQcEg0V3duMFpaeXlZODRmZnlQdEVPOXVLYklQSHY5U0lOaGRY?=
 =?utf-8?B?Y1ErdlZ4TFlLeERzMm5SOTkwMmYxL2ZNWVNxRk1UYjVRZGkvNHp4d2FvUmlv?=
 =?utf-8?B?bDZBTWpXdHpIaWdxVHp2UThoRG1KQzdVbG9sRkRnSWExYzd1L1JyUUYzVW83?=
 =?utf-8?B?aStWbW9lZjNqWThkSGxUZmllaGgvOXRzS0Zka2g3N08yT2NmQzZpWExiS1BN?=
 =?utf-8?B?SU9mWlp1eWlJRmc0dURuU2Y2WmhvSmNCcVFXV1BWUDdtekozaDRlNHRrWVVu?=
 =?utf-8?B?SSszeVllb2dISVJEUUF0Q0RqeWpieDR0M0oyYUk0cXJVL05BR2V3Z05tU0pp?=
 =?utf-8?B?SXVsZzNkUEVjVmZ4eDE2SlpudjlVVGx4NWQzSDRXbWVwNTIrVHhQbXlrQnZY?=
 =?utf-8?B?cDNnL0E0dmpxSHVra3NRS3UwSy85R3hZYklMaFNCV01FRzNFQlZzL05zM0Q4?=
 =?utf-8?B?Ulc2UXRhVmhzd0VhQ2VLZWN1NzNYWjVNL1pPMFZFSmsrU3RQaWZXYi90YlN4?=
 =?utf-8?B?dHFCQnhxTnEzeVBaZkJHSnp2bFM2djhXaDBiWE96Z1FabXZUMVR4SkFsNXpZ?=
 =?utf-8?B?WUJUZGlickl5VWNjREYwQ3ByVUd2NW9GYVhzTjllQy8vaVZhSTh5MUhJUkIw?=
 =?utf-8?B?RGFXWE1VV1hWU2tUMXpoUFpCS3ozbDFJcnpGbzVuelRHR2FWS0RmdUNCZ3gw?=
 =?utf-8?B?d214L0FQZDg5SzVMeFRFVUN1MWlSM1BmNjRVUFJBZERCUWora2lYWE1iV3FJ?=
 =?utf-8?B?ZEZ6UFh1blF1WlUzY0ZLcHV5Q1NKQy9sNWNJbGVEYmNwejl6bXhMdTNkalBo?=
 =?utf-8?B?dUNsdVQxWFQ3ODgyQk81UHhOWlJCNy80S2dXN2hZWS84ZFU0T0VXdFdGcHA4?=
 =?utf-8?B?cEJYMmdodnp2M0ExL0VwVVEvWDg0SXQvbDNRNkdBPT0=?=
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;6:WBLtr3MXXwoiHkSwhKjB673n8OX329kgpwwMBXNqeCS/EQFBbUGHSsuqSk92sCCl2+JLRhBvCPJVKpDnluqxe7eIitEzjXfXh4mOW8U01bMeJovtsel8plK7iNeiw0+bRIpoLZi47r5AGXsxs/dmZXNRupF5ZK9F6suMm7OGKTbpHX0HyNZFESYLtBYP9agxizQkubL6c4gIh1/Yybom+vTlYV8SI+MHj7iJFYOmb+3QmtMvgf31vNll54wNpfyJgFbTnC0EhJy8byMN46lvfYLIsAILmr6trcwWxClGPxfS6clss2KZK/r3q0xkpzWNAH8m7ZBT0c65+enFhrJh7tbEXGvyS+J9jtmjqahPAkhzQXi3UqL76Q8ZbAcMJ09611t3mR1YC7rEpRQbEegkaxSnijiJ0u9NGm5cp2yUEII=;5:pzqEmbfXD1634cfC2rXSM9Esk+gpX9gLy0mBHGt1rCJgtjKgIhLKsHMeJhV9OVJsBhGKMweyrCiL4SHbK5CNwaSvWJU/ar1zjwYSoQaTjvAfMYHQ8beQC5FlSPXKD3WxSb0U5mjnfxF9q9bnzSLMfAf6WgiTrGChx9K9Y18SrBs=;24:FjvrVeHw1jlBi2zVZGiMJxIh0Rd1Giet37EvGDiMeDJJTHTGj8yitNhlxclTSa41EVFMsgjneP81dvWtuaN5qocnwo5FOjPscWHu4c6oj0k=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;7:7BaS/kk9Q5ZaK3Y3BVeMBlAsV0tO/bcGbrxXHcz5ZMLMNXoVd2BiOe4Fgq+IgUQAhntgcK6XzHuJ42cwuYpF6aVjDo1jBhdG62EtEECrEcMUFRGpGCTLD82ljyFtNBtnsLGRp6J9qSG+q4Ky5tdTBv8Pm3pMUAcWnQzWA/QsUpm1NV1cDB4mUFrw2jjHdZOf5YpZ7mq45xxJSm9A3j1Em8zdiaR3x2bUf+PD1Em+EZ5GGTm392gP+Fh1Q2b5Rp+6RFTvGgP32xOM+OrPGJBr9F3wlJRskmupi4nBXr3DjHEx/KVXGbzT4y5IH3/oQrNRYMIGFDs+LBx03uIHMqiiTX692AbQF8+czBtVsfrOnq0QsSgPacFUb/+uVcEkdz6eFldr4BmCu28qkU7obFBYLvxR7o2sHKrJPAlI1nkOGG2/ep2s2tOJXUiDiLKSzjQfuxRUlqgB4zAVINN0aPoY1TzfHg7h4o7KbpJBMbu64Cu+nBnsGZ56G+ZSjFcO9ytbLiyt7V21TnSd6uoU9hVn+q7ikeNkYxyU6a7ppEPi9YVUJbbEnRofJ4n505T1KvhL
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2017 19:48:07.4192 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0601MB1635
X-OriginatorOrg: netapp.com
Return-Path: <Anna.Schumaker@netapp.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 56566
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: Anna.Schumaker@Netapp.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
Content-Length: 1346
Lines: 36

Hi Russell,

On 01/31/2017 02:18 PM, Russell King wrote:
> Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc
> code:
> 
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_setup_rdma_bc':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Fix this by adding linux/module.h to svc_rdma_backchannel.c
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

This patch looks okay to me:

Acked-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

> ---
>  net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> index 288e35c2d8f4..cb1e48e54eb1 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> @@ -4,6 +4,7 @@
>   * Support for backward direction RPCs on RPC/RDMA (server-side).
>   */
>  
> +#include <linux/module.h>
>  #include <linux/sunrpc/svc_rdma.h>
>  #include "xprt_rdma.h"
>  
> 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:32     ` Bart Van Assche
@ 2017-01-31 19:32       ` Bart Van Assche
  0 siblings, 0 replies; 26+ messages in thread
From: Bart Van Assche @ 2017-01-31 19:32 UTC (permalink / raw)
  To: linux-usb, linux-mips, linux-nfs, rmk+kernel, linux-scsi,
	target-devel, netdev, linux-wireless
  Cc: davem, f.fainelli, nab

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
@ 2017-01-31 19:48     ` Anna Schumaker
  0 siblings, 0 replies; 26+ messages in thread
From: Anna Schumaker @ 2017-01-31 19:48 UTC (permalink / raw)
  To: Russell King, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, netdev, target-devel
  Cc: David S. Miller, Florian Fainelli, J. Bruce Fields, Jeff Layton,
	Trond Myklebust

Hi Russell,

On 01/31/2017 02:18 PM, Russell King wrote:
> Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc
> code:
> 
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_setup_rdma_bc':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Fix this by adding linux/module.h to svc_rdma_backchannel.c
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

This patch looks okay to me:

Acked-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

> ---
>  net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> index 288e35c2d8f4..cb1e48e54eb1 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> @@ -4,6 +4,7 @@
>   * Support for backward direction RPCs on RPC/RDMA (server-side).
>   */
>  
> +#include <linux/module.h>
>  #include <linux/sunrpc/svc_rdma.h>
>  #include "xprt_rdma.h"
>  
> 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
@ 2017-01-31 20:15     ` Timur Tabi
  0 siblings, 0 replies; 26+ messages in thread
From: Timur Tabi @ 2017-01-31 20:15 UTC (permalink / raw)
  To: Russell King, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

On 01/31/2017 01:19 PM, Russell King wrote:
> drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device'
>
> Add linux/phy.h to emac-sgmii.c
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 +

The version of emac-sgmii.c on net-next does not need this fixed.  I already 
removed all references to phy_device in commit "net: qcom/emac: always use 
autonegotiation to configure the SGMII link".

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include
  2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
                     ` (12 preceding siblings ...)
  2017-01-31 19:19   ` [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes Russell King
@ 2017-02-01  2:42   ` Florian Fainelli
  13 siblings, 0 replies; 26+ messages in thread
From: Florian Fainelli @ 2017-02-01  2:42 UTC (permalink / raw)
  To: Russell King - ARM Linux, linux-mips, linux-nfs, linux-scsi,
	linux-usb, linux-wireless, netdev, target-devel
  Cc: Andrew Lunn, Anna Schumaker, David S. Miller, Derek Chickles,
	Felix Manlunas, J. Bruce Fields, Jeff Layton, Jiri Slaby,
	Kalle Valo, Luis R. Rodriguez, Madalin Bucur,
	Microchip Linux Driver Support, Nicholas A. Bellinger,
	Nick Kossifidis, Nicolas Ferre, Raghu Vatsavayi, Ralf Baechle,
	Satanand Burla, Thomas Petazzoni, Timur Tabi, Trond Myklebust,
	Vivien Didelot, Woojung Huh

On 01/31/2017 11:17 AM, Russell King - ARM Linux wrote:
> Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
> unnecessary dependency for quite a large amount of the kernel.  There's
> very little which actually requires definitions from phy.h in net/dsa.h
> - the include itself only wants the declaration of a couple of
> structures and IFNAMSIZ.
> 
> Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
> mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
> and phy_fixed.h from net/dsa.h.
> 
> This patch reduces from around 800 files rebuilt to around 40 - even
> with ccache, the time difference is noticable.
> 
> In order to make this change, several drivers need to be updated to
> include necessary headers that they were picking up through this
> include.  This has resulted in a much larger patch series.
> 
> I'm assuming the 0-day builder has had 24 hours with this series, and
> hasn't reported any further issues with it - the last issue was two
> weeks ago (before I became ill) which I fixed over the last weekend.
> 
> I'm hoping this doesn't conflict with what's already in net-next...

For the entire series:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks a lot for doing that.

> 
>  arch/mips/cavium-octeon/octeon-platform.c             | 4 ----
>  drivers/net/dsa/mv88e6xxx/mv88e6xxx.h                 | 1 +
>  drivers/net/ethernet/broadcom/bgmac.c                 | 2 ++
>  drivers/net/ethernet/cadence/macb.h                   | 2 ++
>  drivers/net/ethernet/cavium/liquidio/lio_main.c       | 1 +
>  drivers/net/ethernet/cavium/liquidio/lio_vf_main.c    | 1 +
>  drivers/net/ethernet/cavium/liquidio/octeon_console.c | 1 +
>  drivers/net/ethernet/freescale/fman/fman_memac.c      | 1 +
>  drivers/net/ethernet/marvell/mvneta.c                 | 1 +
>  drivers/net/ethernet/qualcomm/emac/emac-sgmii.c       | 1 +
>  drivers/net/usb/lan78xx.c                             | 1 +
>  drivers/net/wireless/ath/ath5k/ahb.c                  | 2 +-
>  drivers/target/iscsi/iscsi_target_login.c             | 1 +
>  include/net/dsa.h                                     | 6 ++++--
>  net/core/netprio_cgroup.c                             | 1 +
>  net/sunrpc/xprtrdma/svc_rdma_backchannel.c            | 1 +
>  16 files changed, 20 insertions(+), 7 deletions(-)
> 


-- 
Florian

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
@ 2017-02-01  5:34     ` Kalle Valo
  0 siblings, 0 replies; 26+ messages in thread
From: Kalle Valo @ 2017-02-01  5:34 UTC (permalink / raw)
  To: Russell King
  Cc: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel, David S. Miller, Florian Fainelli,
	Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez

Russell King <rmk+kernel@armlinux.org.uk> writes:

> Fix these errors reported by the 0-day builder by replacing the
> linux/export.h include with linux/module.h.
>
> In file included from include/linux/platform_device.h:14:0,
>                  from drivers/net/wireless/ath/ath5k/ahb.c:20:
> include/linux/device.h:1463:1: warning: data definition has no type or storage class
>  module_init(__driver##_init); \
>  ^
> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
>   module_driver(__platform_driver, platform_driver_register, \
>   ^~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/device.h:1463:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
>  module_init(__driver##_init); \
>  ^
> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
>   module_driver(__platform_driver, platform_driver_register, \
>   ^~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
> In file included from include/linux/platform_device.h:14:0,
>                  from drivers/net/wireless/ath/ath5k/ahb.c:20:
> include/linux/device.h:1468:1: warning: data definition has no type or storage class
>  module_exit(__driver##_exit);
>  ^
> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
>   module_driver(__platform_driver, platform_driver_register, \
>   ^~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
> include/linux/device.h:1468:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
>  module_exit(__driver##_exit);
>  ^
> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
>   module_driver(__platform_driver, platform_driver_register, \
>   ^~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration
> In file included from include/linux/platform_device.h:14:0,
>                  from drivers/net/wireless/ath/ath5k/ahb.c:20:
> drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_exit' defined but not used [-Wunused-function]
>  module_platform_driver(ath_ahb_driver);
>                         ^
> include/linux/device.h:1464:20: note: in definition of macro 'module_driver'
>  static void __exit __driver##_exit(void) \
>                     ^~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_init' defined but not used [-Wunused-function]
>  module_platform_driver(ath_ahb_driver);
>                         ^
> include/linux/device.h:1459:19: note: in definition of macro 'module_driver'
>  static int __init __driver##_init(void) \
>                    ^~~~~~~~
> drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver'
>  module_platform_driver(ath_ahb_driver);
>  ^~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Looks good to me:

Acked-by: Kalle Valo <kvalo@codeaurora.org>

I assume Dave will take this so I'll drop the patch from my queue.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
@ 2017-02-01  9:40     ` Nicolas Ferre
  2017-02-01  9:40       ` Nicolas Ferre
  0 siblings, 1 reply; 26+ messages in thread
From: Nicolas Ferre @ 2017-02-01  9:40 UTC (permalink / raw)
  To: Russell King, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

Le 31/01/2017 à 20:18, Russell King a écrit :
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface
> drivers/net/ethernet/cadence/macb.h:877:1: sparse: Expected ; at the end of type declaration
> drivers/net/ethernet/cadence/macb.h:877:1: sparse: got }
> In file included from drivers/net/ethernet/cadence/macb_pci.c:29:0:
> drivers/net/ethernet/cadence/macb.h:862:2: error: unknown type name 'phy_interface_t'
>      phy_interface_t  phy_interface;
>      ^~~~~~~~~~~~~~~
> 
> Add linux/phy.h to macb.h
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/net/ethernet/cadence/macb.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index d67adad67be1..383da8cf5f6d 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -10,6 +10,8 @@
>  #ifndef _MACB_H
>  #define _MACB_H
>  
> +#include <linux/phy.h>
> +
>  #define MACB_GREGS_NBR 16
>  #define MACB_GREGS_VERSION 2
>  #define MACB_MAX_QUEUES 8
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-02-01  9:40     ` Nicolas Ferre
@ 2017-02-01  9:40       ` Nicolas Ferre
  0 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2017-02-01  9:40 UTC (permalink / raw)
  To: Russell King, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

Le 31/01/2017 à 20:18, Russell King a écrit :
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier
> drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface
> drivers/net/ethernet/cadence/macb.h:877:1: sparse: Expected ; at the end of type declaration
> drivers/net/ethernet/cadence/macb.h:877:1: sparse: got }
> In file included from drivers/net/ethernet/cadence/macb_pci.c:29:0:
> drivers/net/ethernet/cadence/macb.h:862:2: error: unknown type name 'phy_interface_t'
>      phy_interface_t  phy_interface;
>      ^~~~~~~~~~~~~~~
> 
> Add linux/phy.h to macb.h
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/net/ethernet/cadence/macb.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index d67adad67be1..383da8cf5f6d 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -10,6 +10,8 @@
>  #ifndef _MACB_H
>  #define _MACB_H
>  
> +#include <linux/phy.h>
> +
>  #define MACB_GREGS_NBR 16
>  #define MACB_GREGS_VERSION 2
>  #define MACB_MAX_QUEUES 8
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:18   ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
@ 2017-02-01  9:55     ` Rafał Miłecki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafał Miłecki @ 2017-02-01  9:55 UTC (permalink / raw)
  To: Russell King, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, netdev, target-devel
  Cc: David S. Miller, Florian Fainelli

On 01/31/2017 08:18 PM, Russell King wrote:
> drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus'
> drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1198:2: error: implicit declaration of function 'phy_stop' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1239:9: error: implicit declaration of function 'phy_mii_ioctl' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1389:28: error: 'phy_ethtool_get_link_ksettings' undeclared here (not in a function)
> drivers/net/ethernet/broadcom/bgmac.c:1390:28: error: 'phy_ethtool_set_link_ksettings' undeclared here (not in a function)
> drivers/net/ethernet/broadcom/bgmac.c:1403:13: error: dereferencing pointer to incomplete type 'struct phy_device'
> drivers/net/ethernet/broadcom/bgmac.c:1417:3: error: implicit declaration of function 'phy_print_status' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1424:26: error: storage size of 'fphy_status' isn't known
> drivers/net/ethernet/broadcom/bgmac.c:1424:9: error: variable 'fphy_status' has initializer but incomplete type
> drivers/net/ethernet/broadcom/bgmac.c:1425:11: warning: excess elements in struct initializer
> drivers/net/ethernet/broadcom/bgmac.c:1425:3: error: unknown field 'link' specified in initializer
> drivers/net/ethernet/broadcom/bgmac.c:1426:12: note: in expansion of macro 'SPEED_1000'
> drivers/net/ethernet/broadcom/bgmac.c:1426:3: error: unknown field 'speed' specified in initializer
> drivers/net/ethernet/broadcom/bgmac.c:1427:13: note: in expansion of macro 'DUPLEX_FULL'
> drivers/net/ethernet/broadcom/bgmac.c:1427:3: error: unknown field 'duplex' specified in initializer
> drivers/net/ethernet/broadcom/bgmac.c:1432:12: error: implicit declaration of function 'fixed_phy_register' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1432:31: error: 'PHY_POLL' undeclared (first use in this function)
> drivers/net/ethernet/broadcom/bgmac.c:1438:8: error: implicit declaration of function 'phy_connect_direct' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function)
> drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/broadcom/bgmac.c:1541:15: error: expected declaration specifiers or '...' before string constant
>
> Add linux/phy.h to bgmac.c
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Rafał Miłecki <rafal@milecki.pl>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
@ 2017-02-01 10:27     ` Thomas Petazzoni
  0 siblings, 0 replies; 26+ messages in thread
From: Thomas Petazzoni @ 2017-02-01 10:27 UTC (permalink / raw)
  To: Russell King
  Cc: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel, David S. Miller, Florian Fainelli

Hello,

On Tue, 31 Jan 2017 19:18:59 +0000, Russell King wrote:
> drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known
> drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known
> drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type
> drivers/net/ethernet/marvell/mvneta.c:2709:2: error: implicit declaration of function 'fixed_phy_update_state' [-Werror=implicit-function-declaration]
> 
> Add linux/phy_fixed.h to mvneta.c
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
@ 2017-02-01 19:07     ` Felix Manlunas
  2017-02-01 19:07       ` Felix Manlunas
  0 siblings, 1 reply; 26+ messages in thread
From: Felix Manlunas @ 2017-02-01 19:07 UTC (permalink / raw)
  To: Russell King
  Cc: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel, David S. Miller, Florian Fainelli,
	Derek Chickles, Satanand Burla, Felix Manlunas, Raghu Vatsavayi

Russell King <rmk+kernel@armlinux.org.uk> wrote on Tue [2017-Jan-31 19:19:19 +0000]:
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:36: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:37: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: error: type defaults to 'int' in declaration of 'module_init'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: error: type defaults to 'int' in declaration of 'module_exit'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:46: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:48: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:53: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:54: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:57: error: expected ')' before 'sizeof'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:58: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: data definitionhas no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_recv_vf_drv_notice':
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4393: error: implicit declaration of function 'try_module_get'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4400: error: implicit declaration of function 'module_put'
> drivers/net/ethernet/cavium/liquidio/lio_main.c: At top level:
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: error: type defaults to 'int' in declaration of 'module_init'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: error: type defaults to 'int' in declaration of 'module_exit'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: parameter names (without types) in function declaration
> 
> Add linux/module.h to both these files.
> 
> drivers/net/ethernet/cavium/liquidio/octeon_console.c:40:31: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/octeon_console.c:42:4: error: expected ')' before string constant
> 
> Add linux/moduleparam.h to this file.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Felix Manlunas <felix.manlunas@cavium.com>

Thank you.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h
  2017-02-01 19:07     ` Felix Manlunas
@ 2017-02-01 19:07       ` Felix Manlunas
  0 siblings, 0 replies; 26+ messages in thread
From: Felix Manlunas @ 2017-02-01 19:07 UTC (permalink / raw)
  To: Russell King
  Cc: linux-mips, linux-nfs, linux-scsi, linux-usb, linux-wireless,
	netdev, target-devel, David S. Miller, Florian Fainelli,
	Derek Chickles, Satanand Burla, Felix Manlunas, Raghu Vatsavayi

Russell King <rmk+kernel@armlinux.org.uk> wrote on Tue [2017-Jan-31 19:19:19 +0000]:
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:31: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:33: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:36: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:37: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:325: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: error: type defaults to 'int' in declaration of 'module_init'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3250: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: error: type defaults to 'int' in declaration of 'module_exit'
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:3251: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:36: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:37: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:38: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: type defaults to 'int' in declaration of 'MODULE_VERSION'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:39: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:40: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:41: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:42: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: expected declaration specifiers or '...' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: type defaults to 'int' in declaration of 'MODULE_FIRMWARE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:43: error: function declaration isn't a prototype
> drivers/net/ethernet/cavium/liquidio/lio_main.c:46: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:48: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:53: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:54: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:57: error: expected ')' before 'sizeof'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:58: error: expected ')' before string constant
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: data definitionhas no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:498: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_recv_vf_drv_notice':
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4393: error: implicit declaration of function 'try_module_get'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4400: error: implicit declaration of function 'module_put'
> drivers/net/ethernet/cavium/liquidio/lio_main.c: At top level:
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: error: type defaults to 'int' in declaration of 'module_init'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4670: warning: parameter names (without types) in function declaration
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: data definition has no type or storage class
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: error: type defaults to 'int' in declaration of 'module_exit'
> drivers/net/ethernet/cavium/liquidio/lio_main.c:4671: warning: parameter names (without types) in function declaration
> 
> Add linux/module.h to both these files.
> 
> drivers/net/ethernet/cavium/liquidio/octeon_console.c:40:31: error: expected ')' before 'int'
> drivers/net/ethernet/cavium/liquidio/octeon_console.c:42:4: error: expected ')' before string constant
> 
> Add linux/moduleparam.h to this file.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Felix Manlunas <felix.manlunas@cavium.com>

Thank you.

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, back to index

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20170118001403.GJ27312@n2100.armlinux.org.uk>
2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-01-31 19:48     ` Anna Schumaker
2017-01-31 19:18   ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
2017-02-01  9:40     ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-01-31 19:18   ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
2017-02-01  9:55     ` Rafał Miłecki
2017-01-31 19:18   ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
2017-02-01 10:27     ` Thomas Petazzoni
2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
2017-01-31 20:15     ` Timur Tabi
2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
2017-01-31 19:32     ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:19   ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-02-01 19:07     ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
2017-02-01  5:34     ` Kalle Valo
2017-01-31 19:19   ` [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes Russell King
2017-02-01  2:42   ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git