From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Lichao Liu <liulichao@loongson.cn>, Huacai Chen <chenhc@lemote.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
James Hogan <jhogan@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
David Howells <dhowells@redhat.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.
Date: Thu, 21 Nov 2019 14:17:28 +0800 [thread overview]
Message-ID: <E3B6A677-013F-4431-B29C-8C069931C84C@flygoat.com> (raw)
In-Reply-To: <20191121014156.25618-1-liulichao@loongson.cn>
于 2019年11月21日 GMT+08:00 上午9:41:56, Lichao Liu <liulichao@loongson.cn> 写到:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.
You should have a dedicated short patch tittle.
Like MIPS: Loongson64: Limit i8259 include by config
>
>Signed-off-by: Lichao Liu <liulichao@loongson.cn>
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>
--
Jiaxun Yang
prev parent reply other threads:[~2019-11-21 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 1:41 [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file Lichao Liu
2019-11-21 6:12 ` Jiaxun Yang
2019-11-21 6:17 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B6A677-013F-4431-B29C-8C069931C84C@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhc@lemote.com \
--cc=dhowells@redhat.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liulichao@loongson.cn \
--cc=marc.dionne@auristor.com \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).