From: Paul Burton <paul.burton@mips.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <pburton@wavecomp.com>,
James Hogan <jhogan@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: entry: Remove unneeded need_resched() loop
Date: Tue, 19 Mar 2019 23:18:25 +0000 [thread overview]
Message-ID: <MWHPR2201MB12771A95F3320F9D1E343B23C1400@MWHPR2201MB1277.namprd22.prod.outlook.com> (raw)
In-Reply-To: <20190315163133.31632-1-valentin.schneider@arm.com>
Hello,
Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Note that commit a18815abcdfd ("Use preempt_schedule_irq.") initially
> removed the existing loop, but missed the final branch to restore_all.
> Commit cdaed73afb61 ("Fix preemption bug.") missed that and reintroduced
> the loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: James Hogan <jhogan@kernel.org>
> Cc: linux-mips@vger.kernel.org
Applied to mips-next.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
next prev parent reply other threads:[~2019-03-19 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 22:47 [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-03-11 22:47 ` [PATCH 06/14] MIPS: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-03-14 18:13 ` Paul Burton
2019-03-14 18:38 ` Valentin Schneider
2019-05-10 16:16 ` Maciej W. Rozycki
2019-03-15 16:31 ` [PATCH v2] " Valentin Schneider
2019-03-19 23:18 ` Paul Burton [this message]
2019-03-12 18:03 ` [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Vineet Gupta
2019-03-12 18:18 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR2201MB12771A95F3320F9D1E343B23C1400@MWHPR2201MB1277.namprd22.prod.outlook.com \
--to=paul.burton@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=pburton@wavecomp.com \
--cc=ralf@linux-mips.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).