Linux-MIPS Archive on lore.kernel.org
 help / Atom feed
* [PATCH] MIPS: Use lower case for addresses in nexys4ddr.dts
@ 2019-02-04 19:53 Paul Burton
  2019-02-04 21:17 ` Paul Burton
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Burton @ 2019-02-04 19:53 UTC (permalink / raw)
  To: linux-mips; +Cc: Paul Burton, stable

DTC introduced an i2c_bus_reg check in v1.4.7, used since Linux v4.20,
which complains about upper case addresses used in the unit name.

nexys4ddr.dts names an I2C device node "ad7420@4B", leading to:

  arch/mips/boot/dts/xilfpga/nexys4ddr.dts:109.16-112.8: Warning
    (i2c_bus_reg): /i2c@10A00000/ad7420@4B: I2C bus unit address format
    error, expected "4b"

Fix this by switching to lower case addresses throughout the file, as is
*mostly* the case in the file already & fairly standard throughout the
tree.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: stable@vger.kernel.org # v4.20+
---
 arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
index 2152b7ba65fb..cc8dbea0911f 100644
--- a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
+++ b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
@@ -90,11 +90,11 @@
 		interrupts = <0>;
 	};
 
-	axi_i2c: i2c@10A00000 {
+	axi_i2c: i2c@10a00000 {
 	    compatible = "xlnx,xps-iic-2.00.a";
 	    interrupt-parent = <&axi_intc>;
 	    interrupts = <4>;
-	    reg = < 0x10A00000 0x10000 >;
+	    reg = < 0x10a00000 0x10000 >;
 	    clocks = <&ext>;
 	    xlnx,clk-freq = <0x5f5e100>;
 	    xlnx,family = "Artix7";
@@ -106,9 +106,9 @@
 	    #address-cells = <1>;
 	    #size-cells = <0>;
 
-	    ad7420@4B {
+	    ad7420@4b {
 		compatible = "adi,adt7420";
-		reg = <0x4B>;
+		reg = <0x4b>;
 	    };
 	} ;
 };
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: Use lower case for addresses in nexys4ddr.dts
  2019-02-04 19:53 [PATCH] MIPS: Use lower case for addresses in nexys4ddr.dts Paul Burton
@ 2019-02-04 21:17 ` Paul Burton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-02-04 21:17 UTC (permalink / raw)
  To: Paul Burton; +Cc: linux-mips, Paul Burton, stable, linux-mips

Hello,

Paul Burton wrote:
> DTC introduced an i2c_bus_reg check in v1.4.7, used since Linux v4.20,
> which complains about upper case addresses used in the unit name.
> 
> nexys4ddr.dts names an I2C device node "ad7420@4B", leading to:
> 
> arch/mips/boot/dts/xilfpga/nexys4ddr.dts:109.16-112.8: Warning
> (i2c_bus_reg): /i2c@10A00000/ad7420@4B: I2C bus unit address format
> error, expected "4b"
> 
> Fix this by switching to lower case addresses throughout the file, as is
> *mostly* the case in the file already & fairly standard throughout the
> tree.
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> Cc: stable@vger.kernel.org # v4.20+

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 19:53 [PATCH] MIPS: Use lower case for addresses in nexys4ddr.dts Paul Burton
2019-02-04 21:17 ` Paul Burton

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org linux-mips@archiver.kernel.org
	public-inbox-index linux-mips


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/ public-inbox