* [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368
@ 2018-12-10 11:40 Jonas Gorski
2018-12-14 19:03 ` Paul Burton
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Gorski @ 2018-12-10 11:40 UTC (permalink / raw)
To: linux-mips; +Cc: Ralf Baechle, Paul Burton, James Hogan, Florian Fainelli
The Ethernet Switch core mask was set to 0, causing the switch core to
be not reset on BCM6368 on boot. Provide the proper mask so the switch
core gets reset to a known good state.
Fixes: 799faa626c71 ("MIPS: BCM63XX: add core reset helper")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
arch/mips/bcm63xx/reset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/bcm63xx/reset.c b/arch/mips/bcm63xx/reset.c
index a2af38cf28a7..64574e74cb23 100644
--- a/arch/mips/bcm63xx/reset.c
+++ b/arch/mips/bcm63xx/reset.c
@@ -120,7 +120,7 @@
#define BCM6368_RESET_DSL 0
#define BCM6368_RESET_SAR SOFTRESET_6368_SAR_MASK
#define BCM6368_RESET_EPHY SOFTRESET_6368_EPHY_MASK
-#define BCM6368_RESET_ENETSW 0
+#define BCM6368_RESET_ENETSW SOFTRESET_6368_ENETSW_MASK
#define BCM6368_RESET_PCM SOFTRESET_6368_PCM_MASK
#define BCM6368_RESET_MPI SOFTRESET_6368_MPI_MASK
#define BCM6368_RESET_PCIE 0
--
2.13.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368
2018-12-10 11:40 [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368 Jonas Gorski
@ 2018-12-14 19:03 ` Paul Burton
0 siblings, 0 replies; 4+ messages in thread
From: Paul Burton @ 2018-12-14 19:03 UTC (permalink / raw)
To: Jonas Gorski
Cc: linux-mips, Ralf Baechle, Paul Burton, James Hogan,
Florian Fainelli, linux-mips
Hello,
Jonas Gorski wrote:
> The Ethernet Switch core mask was set to 0, causing the switch core to
> be not reset on BCM6368 on boot. Provide the proper mask so the switch
> core gets reset to a known good state.
>
> Fixes: 799faa626c71 ("MIPS: BCM63XX: add core reset helper")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368
2019-11-13 10:57 Amit Pundir
@ 2019-11-14 5:53 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-11-14 5:53 UTC (permalink / raw)
To: Amit Pundir
Cc: Sasha Levin, Lee Jones, Stable, Jonas Gorski, Paul Burton,
linux-mips, Ralf Baechle, James Hogan, Florian Fainelli
On Wed, Nov 13, 2019 at 04:27:00PM +0530, Amit Pundir wrote:
> From: Jonas Gorski <jonas.gorski@gmail.com>
>
> commit 8a38dacf87180738d42b058334c951eba15d2d47 upstream.
>
> The Ethernet Switch core mask was set to 0, causing the switch core to
> be not reset on BCM6368 on boot. Provide the proper mask so the switch
> core gets reset to a known good state.
>
> Fixes: 799faa626c71 ("MIPS: BCM63XX: add core reset helper")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> Cc: linux-mips@vger.kernel.org
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: James Hogan <jhogan@kernel.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
> ---
> Cherry-picked from lede/openwrt https://git.lede-project.org/?p=source.git.
> Build tested on v4.{19,14,9,4}.y and v3.18.y for ARCH=mips bcm63xx_defconfig.
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368
@ 2019-11-13 10:57 Amit Pundir
2019-11-14 5:53 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Amit Pundir @ 2019-11-13 10:57 UTC (permalink / raw)
To: Greg KH, Sasha Levin, Lee Jones
Cc: Stable, Jonas Gorski, Paul Burton, linux-mips, Ralf Baechle,
James Hogan, Florian Fainelli
From: Jonas Gorski <jonas.gorski@gmail.com>
commit 8a38dacf87180738d42b058334c951eba15d2d47 upstream.
The Ethernet Switch core mask was set to 0, causing the switch core to
be not reset on BCM6368 on boot. Provide the proper mask so the switch
core gets reset to a known good state.
Fixes: 799faa626c71 ("MIPS: BCM63XX: add core reset helper")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
Cherry-picked from lede/openwrt https://git.lede-project.org/?p=source.git.
Build tested on v4.{19,14,9,4}.y and v3.18.y for ARCH=mips bcm63xx_defconfig.
arch/mips/bcm63xx/reset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/bcm63xx/reset.c b/arch/mips/bcm63xx/reset.c
index a2af38cf28a7..64574e74cb23 100644
--- a/arch/mips/bcm63xx/reset.c
+++ b/arch/mips/bcm63xx/reset.c
@@ -120,7 +120,7 @@
#define BCM6368_RESET_DSL 0
#define BCM6368_RESET_SAR SOFTRESET_6368_SAR_MASK
#define BCM6368_RESET_EPHY SOFTRESET_6368_EPHY_MASK
-#define BCM6368_RESET_ENETSW 0
+#define BCM6368_RESET_ENETSW SOFTRESET_6368_ENETSW_MASK
#define BCM6368_RESET_PCM SOFTRESET_6368_PCM_MASK
#define BCM6368_RESET_MPI SOFTRESET_6368_MPI_MASK
#define BCM6368_RESET_PCIE 0
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-14 5:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 11:40 [PATCH] MIPS: BCM63XX: fix switch core reset on BCM6368 Jonas Gorski
2018-12-14 19:03 ` Paul Burton
2019-11-13 10:57 Amit Pundir
2019-11-14 5:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).