* [PATCH] MIPS: OCTEON: mark RGMII interface disabled on OCTEON III
@ 2019-01-02 18:43 Aaro Koskinen
2019-01-02 22:16 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2019-01-02 18:43 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan; +Cc: linux-mips, Aaro Koskinen
Commit 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx
interface detection") added RGMII interface detection for OCTEON III,
but it results in the following logs:
[ 7.165984] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
[ 7.173017] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
The current RGMII routines are valid only for older OCTEONS that
use GMX/ASX hardware blocks. On later chips AGL should be used,
but support for that is missing in the mainline. Until that is added,
mark the interface as disabled.
Fixes: 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
arch/mips/cavium-octeon/executive/cvmx-helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c
index a76bbcc30f95..38e0444e57e8 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c
@@ -266,7 +266,8 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7xxx(int interface)
case 3:
return CVMX_HELPER_INTERFACE_MODE_LOOP;
case 4:
- return CVMX_HELPER_INTERFACE_MODE_RGMII;
+ /* TODO: Implement support for AGL (RGMII). */
+ return CVMX_HELPER_INTERFACE_MODE_DISABLED;
default:
return CVMX_HELPER_INTERFACE_MODE_DISABLED;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: OCTEON: mark RGMII interface disabled on OCTEON III
2019-01-02 18:43 [PATCH] MIPS: OCTEON: mark RGMII interface disabled on OCTEON III Aaro Koskinen
@ 2019-01-02 22:16 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-01-02 22:16 UTC (permalink / raw)
To: Aaro Koskinen
Cc: Ralf Baechle, Paul Burton, James Hogan, linux-mips,
Aaro Koskinen, linux-mips
Hello,
Aaro Koskinen wrote:
> Commit 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx
> interface detection") added RGMII interface detection for OCTEON III,
> but it results in the following logs:
>
> [ 7.165984] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
> [ 7.173017] ERROR: Unsupported Octeon model in __cvmx_helper_rgmii_probe
>
> The current RGMII routines are valid only for older OCTEONS that
> use GMX/ASX hardware blocks. On later chips AGL should be used,
> but support for that is missing in the mainline. Until that is added,
> mark the interface as disabled.
>
> Fixes: 885872b722b7 ("MIPS: Octeon: Add Octeon III CN7xxx interface detection")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-02 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 18:43 [PATCH] MIPS: OCTEON: mark RGMII interface disabled on OCTEON III Aaro Koskinen
2019-01-02 22:16 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).