From: Paul Burton <paul.burton@mips.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"maz@kernel.org" <maz@kernel.org>,
"paul@crapouillou.net" <paul@crapouillou.net>,
"malat@debian.org" <malat@debian.org>,
Paul Burton <pburton@wavecomp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
Date: Mon, 19 Aug 2019 21:17:16 +0000 [thread overview]
Message-ID: <MWHPR2201MB127774E2D45194657F876CC4C1A80@MWHPR2201MB1277.namprd22.prod.outlook.com> (raw)
In-Reply-To: <20190813015602.30576-1-yuehaibing@huawei.com>
Hello,
YueHaibing wrote:
> While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> not selected, it fails:
>
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
>
> select GENERIC_IRQ_CHIP to fix this.
Applied to mips-next.
> commit 8084499bd7d4
> https://git.kernel.org/mips/c/8084499bd7d4
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
prev parent reply other threads:[~2019-08-19 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 1:56 [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building YueHaibing
2019-08-16 12:28 ` Thomas Gleixner
2019-08-16 20:19 ` Paul Burton
2019-08-16 20:41 ` Thomas Gleixner
2019-08-19 21:17 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR2201MB127774E2D45194657F876CC4C1A80@MWHPR2201MB1277.namprd22.prod.outlook.com \
--to=paul.burton@mips.com \
--cc=jason@lakedaemon.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=malat@debian.org \
--cc=maz@kernel.org \
--cc=paul@crapouillou.net \
--cc=pburton@wavecomp.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).