Linux-MIPS Archive on
 help / Atom feed
* Re: [PATCH] MIPS: Loongson: Introduce and use loongson_llsc_mb()
       [not found] <>
@ 2019-02-04 21:17 ` Paul Burton
  0 siblings, 0 replies; 1+ messages in thread
From: Paul Burton @ 2019-02-04 21:17 UTC (permalink / raw)
  To: Huang Pei
  Cc: Ralf Baechle, ambrosehua, Paul Burton, Steven J . Hill,
	linux-mips, Fuxin Zhang, Zhangjin Wu, Li Xuefeng, Xu Chenghua,
	Huacai Chen, linux-mips


Huang Pei wrote:
> From: Huacai Chen <>
> On the Loongson-2G/2H/3A/3B there is a hardware flaw that ll/sc and
> lld/scd is very weak ordering. We should add sync instructions "before
> each ll/lld" and "at the branch-target between ll/sc" to workaround.
> Otherwise, this flaw will cause deadlock occasionally (e.g. when doing
> heavy load test with LTP).
> Below is the explaination of CPU designer:
> "For Loongson 3 family, when a memory access instruction (load, store,
> or prefetch)'s executing occurs between the execution of LL and SC, the
> success or failure of SC is not predictable. Although programmer would
> not insert memory access instructions between LL and SC, the memory
> instructions before LL in program-order, may dynamically executed
> between the execution of LL/SC, so a memory fence (SYNC) is needed
> before LL/LLD to avoid this situation.
> Since Loongson-3A R2 (3A2000), we have improved our hardware design to
> handle this case. But we later deduce a rarely circumstance that some
> speculatively executed memory instructions due to branch misprediction
> between LL/SC still fall into the above case, so a memory fence (SYNC)
> at branch-target (if its target is not between LL/SC) is needed for
> Loongson 3A1000, 3B1500, 3A2000 and 3A3000.
> Our processor is continually evolving and we aim to to remove all these
> workaround-SYNCs around LL/SC for new-come processor."
> Here is an example:
> Both cpu1 and cpu2 simutaneously run atomic_add by 1 on same atomic var,
> this bug cause both 'sc' run by two cpus (in atomic_add) succeed at same
> time('sc' return 1), and the variable is only *added by 1*, sometimes,
> which is wrong and unacceptable(it should be added by 2).
> Why disable fix-loongson3-llsc in compiler?
> Because compiler fix will cause problems in kernel's __ex_table section.
> This patch fix all the cases in kernel, but:
> +. the fix at the end of futex_atomic_cmpxchg_inatomic is for branch-target
> of 'bne', there other cases which smp_mb__before_llsc() and smp_llsc_mb() fix
> the ll and branch-target coincidently such as atomic_sub_if_positive/
> cmpxchg/xchg, just like this one.
> +. Loongson 3 does support CONFIG_EDAC_ATOMIC_SCRUB, so no need to touch
> edac.h
> +. local_ops and cmpxchg_local should not be affected by this bug since
> only the owner can write.
> +. mips_atomic_set for syscall.c is deprecated and rarely used, just let
> it go
> Signed-off-by: Huacai Chen <>
> Signed-off-by: Huang Pei <>

Applied to mips-fixes.


[ This message was auto-generated; if you believe anything is incorrect
  then please email to report it. ]

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <>
2019-02-04 21:17 ` [PATCH] MIPS: Loongson: Introduce and use loongson_llsc_mb() Paul Burton

Linux-MIPS Archive on

Archives are clonable:
	git clone --mirror linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ \
	public-inbox-index linux-mips

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox