From: Paul Burton <paul.burton@mips.com>
To: Yifeng Li <tomli@tomli.me>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhc@lemote.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <pburton@wavecomp.com>,
James Hogan <jhogan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yifeng Li <tomli@tomli.me>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to "cascade" irqaction.
Date: Mon, 11 Mar 2019 18:14:01 +0000 [thread overview]
Message-ID: <MWHPR2201MB1277B26232DBDC311AEC16EEC1480@MWHPR2201MB1277.namprd22.prod.outlook.com> (raw)
In-Reply-To: <20190304220022.20682-1-tomli@tomli.me>
Hello,
Yifeng Li wrote:
> Timekeeping IRQs from CS5536 MFGPT are routed to i8259, which then
> triggers the "cascade" IRQ on MIPS CPU. Without IRQF_NO_SUSPEND in
> cascade_irqaction, MFGPT interrupts will be masked in suspend mode,
> and the machine would be unable to resume once suspended.
>
> Previously, MIPS IRQs were not disabled properly, so the original
> code appeared to work. Commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq
> on CPU IRQs) uncovers the bug. To fix it, add IRQF_NO_SUSPEND to
> cascade_irqaction.
>
> This commit is functionally identical to 0add9c2f1cff ("MIPS:
> Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction"), but it forgot
> to apply the same fix to Loongson2.
>
> Signed-off-by: Yifeng Li <tomli@tomli.me>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
prev parent reply other threads:[~2019-03-11 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 22:00 [PATCH] mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to "cascade" irqaction Yifeng Li
2019-03-11 18:14 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR2201MB1277B26232DBDC311AEC16EEC1480@MWHPR2201MB1277.namprd22.prod.outlook.com \
--to=paul.burton@mips.com \
--cc=chenhc@lemote.com \
--cc=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=pburton@wavecomp.com \
--cc=ralf@linux-mips.org \
--cc=tomli@tomli.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).