linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hassan Naveed <hnaveed@wavecomp.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Paul Burton <pburton@wavecomp.com>
Cc: "kafai@fb.com" <kafai@fb.com>,
	"songliubraving@fb.com" <songliubraving@fb.com>,
	"yhs@fb.com" <yhs@fb.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	"open list:MIPS" <linux-mips@linux-mips.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture.
Date: Wed, 20 Mar 2019 19:37:19 +0000	[thread overview]
Message-ID: <MWHPR2201MB13583388481F01A422CE7D66D4410@MWHPR2201MB1358.namprd22.prod.outlook.com> (raw)
In-Reply-To: <98323a41-2851-d000-c928-242d055a5bc1@iogearbox.net>

Hi Daniel,

> >
> >On 03/12/2019 11:48 PM, Hassan Naveed wrote:
> >> Currently MIPS32 supports a JIT for classic BPF only, not extended BPF.
> >> This patch adds JIT support for extended BPF on MIPS32, so code is
> >> actually JIT'ed instead of being only interpreted. Instructions with
> >> 64-bit operands are not supported at this point.
> >> We can delete classic BPF because the kernel will translate classic
> >> BPF programs into extended BPF and JIT them, eliminating the need for
> >> classic BPF.
> >>
> >> Signed-off-by: Hassan Naveed <hnaveed@wavecomp.com>
> >
> >Nice! Did you check BPF test suite (lib/test_bpf.ko) that both before/after the
> >same number of cBPF programs could be JITed?

Yes, we did check that and the number of tests JITed is same. Hence we thought it's better to get rid of cBPF and simplify things.

> >
> >Please also follow-up to update Documentation/sysctl/net.txt, bpf_jit_enable
> >section, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't
> >hurt either if Paul would be good with that, too.
> >

I'll update the bpf_jit_enable section in the next patch. I believe this one is already applied.

> >Any plans on completing eBPF support for mips32?

It definitely is on my to-do list, though I'm not quite sure when I'd be able to get to it.
> >
> >Thanks,
> >Daniel

  reply	other threads:[~2019-03-20 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 22:47 [PATCH v2 1/3] MIPS: uasm: Add div, mul and sel instructions for mipsr6 Hassan Naveed
2019-03-12 22:48 ` [PATCH v2 2/3] MIPS: eBPF: Provide eBPF support for MIPS64R6 Hassan Naveed
2019-03-12 22:48 ` [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture Hassan Naveed
2019-03-20 14:07   ` Daniel Borkmann
2019-03-20 19:37     ` Hassan Naveed [this message]
2019-03-19 23:18 ` [PATCH v2 1/3] MIPS: uasm: Add div, mul and sel instructions for mipsr6 Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR2201MB13583388481F01A422CE7D66D4410@MWHPR2201MB1358.namprd22.prod.outlook.com \
    --to=hnaveed@wavecomp.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jhogan@kernel.org \
    --cc=kafai@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pburton@wavecomp.com \
    --cc=ralf@linux-mips.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).