From: Paul Cercueil <paul@crapouillou.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
list@opendingux.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v2 3/6] PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros
Date: Fri, 07 Jan 2022 16:43:37 +0000 [thread overview]
Message-ID: <PGMC5R.ZEUF4DPAECD7@crapouillou.net> (raw)
In-Reply-To: <CAPDyKFpUUPzqonNBrFq68h8QOVxardvf2q7AuEQVeUJ-S2726A@mail.gmail.com>
Le ven., janv. 7 2022 at 17:33:04 +0100, Ulf Hansson
<ulf.hansson@linaro.org> a écrit :
> On Wed, 5 Jan 2022 at 19:30, Paul Cercueil <paul@crapouillou.net>
> wrote:
>>
>> These macros are defined conditionally, according to CONFIG_PM:
>> - if CONFIG_PM is enabled, these macros resolve to
>> DEFINE_SIMPLE_DEV_PM_OPS(), and the dev_pm_ops symbol will be
>> exported.
>>
>> - if CONFIG_PM is disabled, these macros will result in a dummy
>> static
>> dev_pm_ops to be created with the __maybe_unused flag. The
>> dev_pm_ops
>> will then be discarded by the compiler, along with the provided
>> callback functions if they are not used anywhere else.
>>
>> In the second case, the symbol is not exported, which should be
>> perfectly fine - users of the symbol should all use the pm_ptr() or
>> pm_sleep_ptr() macro, so the dev_pm_ops marked as "extern" in the
>> client's code will never be accessed.
>
> How common is it to export the dev_pm_ops? Do we really need a macro
> for this?
$ rgrep EXPORT_SYMBOL drivers/ |grep pm_ops |wc -l
44
That should be enough to justify a macro.
Cheers,
-Paul
>
> The similar comment/question applies for patch5.
>
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Kind regards
> Uffe
>
>> ---
>>
>> Notes:
>> v2: Remove useless empty line
>>
>> include/linux/pm.h | 32 +++++++++++++++++++++++++++++---
>> 1 file changed, 29 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/linux/pm.h b/include/linux/pm.h
>> index 389e600df233..b82f40e701ab 100644
>> --- a/include/linux/pm.h
>> +++ b/include/linux/pm.h
>> @@ -8,6 +8,7 @@
>> #ifndef _LINUX_PM_H
>> #define _LINUX_PM_H
>>
>> +#include <linux/export.h>
>> #include <linux/list.h>
>> #include <linux/workqueue.h>
>> #include <linux/spinlock.h>
>> @@ -357,14 +358,39 @@ struct dev_pm_ops {
>> #define SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn)
>> #endif
>>
>> +#define _DEFINE_DEV_PM_OPS(name, \
>> + suspend_fn, resume_fn, \
>> + runtime_suspend_fn, runtime_resume_fn,
>> idle_fn) \
>> +const struct dev_pm_ops name = { \
>> + SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
>> + RUNTIME_PM_OPS(runtime_suspend_fn, runtime_resume_fn,
>> idle_fn) \
>> +}
>> +
>> /*
>> * Use this if you want to use the same suspend and resume
>> callbacks for suspend
>> * to RAM and hibernation.
>> */
>> #define DEFINE_SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
>> -const struct dev_pm_ops name = { \
>> - SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
>> -}
>> + _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL,
>> NULL)
>> +
>> +#ifdef CONFIG_PM
>> +#define _EXPORT_DEV_PM_OPS(name, suspend_fn, resume_fn,
>> runtime_suspend_fn, \
>> + runtime_resume_fn, idle_fn, sec) \
>> + _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn,
>> runtime_suspend_fn, \
>> + runtime_resume_fn, idle_fn); \
>> + _EXPORT_SYMBOL(name, sec)
>> +#else
>> +#define _EXPORT_DEV_PM_OPS(name, suspend_fn, resume_fn,
>> runtime_suspend_fn, \
>> + runtime_resume_fn, idle_fn, sec) \
>> +static __maybe_unused _DEFINE_DEV_PM_OPS(__static_##name,
>> suspend_fn, \
>> + resume_fn,
>> runtime_suspend_fn, \
>> + runtime_resume_fn, idle_fn)
>> +#endif
>> +
>> +#define EXPORT_SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
>> + _EXPORT_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL,
>> NULL, "")
>> +#define EXPORT_GPL_SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
>> + _EXPORT_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL,
>> NULL, "_gpl")
>>
>> /* Deprecated. Use DEFINE_SIMPLE_DEV_PM_OPS() instead. */
>> #define SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2022-01-07 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 18:29 [PATCH v2 0/6] DEV_PM_OPS macros rework v2 Paul Cercueil
2022-01-05 18:29 ` [PATCH v2 1/6] PM: core: Remove DEFINE_UNIVERSAL_DEV_PM_OPS() macro Paul Cercueil
2022-01-07 16:26 ` Ulf Hansson
2022-01-07 16:37 ` Paul Cercueil
2022-01-07 16:40 ` Ulf Hansson
2022-01-07 17:39 ` Paul Cercueil
2022-01-05 18:29 ` [PATCH v2 2/6] PM: core: Remove static qualifier in DEFINE_SIMPLE_DEV_PM_OPS macro Paul Cercueil
2022-01-07 16:26 ` Ulf Hansson
2022-01-05 18:29 ` [PATCH v2 3/6] PM: core: Add EXPORT[_GPL]_SIMPLE_DEV_PM_OPS macros Paul Cercueil
2022-01-07 16:33 ` Ulf Hansson
2022-01-07 16:43 ` Paul Cercueil [this message]
2022-01-07 17:11 ` Ulf Hansson
2022-01-05 18:29 ` [PATCH v2 4/6] PM: runtime: Add DEFINE_RUNTIME_DEV_PM_OPS() macro Paul Cercueil
2022-01-05 18:29 ` [PATCH v2 5/6] PM: runtime: Add EXPORT[_GPL]_RUNTIME_DEV_PM_OPS macros Paul Cercueil
2022-01-05 18:29 ` [PATCH v2 6/6] iio: pressure: bmp280: Use new PM macros Paul Cercueil
2022-01-06 13:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PGMC5R.ZEUF4DPAECD7@crapouillou.net \
--to=paul@crapouillou.net \
--cc=arnd@arndb.de \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=lars@metafoo.de \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=list@opendingux.net \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).