From: Paul Cercueil <paul@crapouillou.net>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: tsbogend@alpha.franken.de, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, keescook@chromium.org,
hns@goldelico.com, ebiederm@xmission.com,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, yanfei.li@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com
Subject: Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
Date: Thu, 23 Jul 2020 10:47:19 +0200 [thread overview]
Message-ID: <V2ZWDQ.DNM4EVLAB6YN3@crapouillou.net> (raw)
In-Reply-To: <20200723071950.130007-2-zhouyanjie@wanyeetech.com>
Hi Zhou,
Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> a écrit :
> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address") add EFUSE
> node for DM9000 in CI20, however, the EFUSE driver is not selected,
> which will cause the DM9000 to fail to read the MAC address from
> EFUSE, causing the following issue:
>
> [FAILED] Failed to start Raise network interfaces.
>
> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
> ci20_defconfig.
Does it actually fix it on a clean 5.8-rc kernel?
From what I know, the efuse driver cannot probe, because the nemc
driver requests the complete memory resource, so the efuse driver's
devm_platform_ioremap_resource() fails.
I did send a patch to fix this
(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
but it's hard to have somebody merge it, because nobody maintains
drivers/memory/.
> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address").
That shouldn't be a fix IMHO - the devicetree was updated in one
commit, the config should be updated in another. The "bug" here is that
it wasn't done right away.
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Btw - when you add a Fixes: tag to fix a commit that is not for the
kernel currently in RC phase, you need to Cc linux-stable as well.
Cheers,
-Paul
> ---
> arch/mips/configs/ci20_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/configs/ci20_defconfig
> b/arch/mips/configs/ci20_defconfig
> index f433fad16073..ba26ba4de09a 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
> CONFIG_MEMORY=y
> CONFIG_PWM=y
> CONFIG_PWM_JZ4740=m
> +CONFIG_JZ4780_EFUSE=y
> CONFIG_EXT4_FS=y
> # CONFIG_DNOTIFY is not set
> CONFIG_AUTOFS_FS=y
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-07-23 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:19 MIPS: CI20: Update defconfig for EFUSE 周琰杰 (Zhou Yanjie)
2020-07-23 7:19 ` [PATCH] " 周琰杰 (Zhou Yanjie)
2020-07-23 8:47 ` Paul Cercueil [this message]
2020-07-25 8:02 ` Zhou Yanjie
2020-07-28 15:40 ` Paul Cercueil
2020-08-07 15:55 ` Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=V2ZWDQ.DNM4EVLAB6YN3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=ebiederm@xmission.com \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).