From: Petr Vorel <pvorel@suse.cz>
To: zhanglianjie <zhanglianjie@uniontech.com>
Cc: linux-mips@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] regen.sh: Limit mips o32 system calls
Date: Tue, 27 Jul 2021 14:03:42 +0200 [thread overview]
Message-ID: <YP/2HhUaQVQc1oAV@pevik> (raw)
In-Reply-To: <20210722125219.31895-1-zhanglianjie@uniontech.com>
Hi zhanglianjie,
> With mips architecture, 64-bit programs cannot call o32 system calls.
> For example, __NR_stime, __NR_socketcall, __NR_time, etc.
@Thomas or somebody from MIPS folks, could you please confirm this?
> Better solve the problem described in commit: 22c2c9e2f
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> diff --git a/include/lapi/syscalls/regen.sh b/include/lapi/syscalls/regen.sh
> index 7a4f0cf44..8ac80440c 100755
> --- a/include/lapi/syscalls/regen.sh
> +++ b/include/lapi/syscalls/regen.sh
> @@ -80,7 +80,7 @@ for arch in $(cat "${srcdir}/order") ; do
> s390) echo "#if defined(__s390__) && !defined(__s390x__)" ;;
> mips_n32) echo "#if defined(__mips__) && defined(_ABIN32)" ;;
> mips_n64) echo "#if defined(__mips__) && defined(_ABI64)" ;;
> - mips_o32) echo "#if defined(__mips__) && defined(_ABIO32)" ;;
> + mips_o32) echo "#if defined(__mips__) && defined(_ABIO32) && _MIPS_SZLONG == 32" ;;
> *) echo "#ifdef __${arch}__" ;;
> esac
> while read line ; do
parent reply other threads:[~2021-07-27 12:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210722125219.31895-1-zhanglianjie@uniontech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/2HhUaQVQc1oAV@pevik \
--to=pvorel@suse.cz \
--cc=linux-mips@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=tsbogend@alpha.franken.de \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).