linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [LTP] [PATCH] regen.sh: Limit mips o32 system calls
       [not found] <20210722125219.31895-1-zhanglianjie@uniontech.com>
@ 2021-07-27 12:03 ` Petr Vorel
  0 siblings, 0 replies; only message in thread
From: Petr Vorel @ 2021-07-27 12:03 UTC (permalink / raw)
  To: zhanglianjie; +Cc: linux-mips, Thomas Bogendoerfer, ltp

Hi zhanglianjie,

> With mips architecture, 64-bit programs cannot call o32 system calls.
> For example, __NR_stime, __NR_socketcall, __NR_time, etc.
@Thomas or somebody from MIPS folks, could you please confirm this?

> Better solve the problem described in commit: 22c2c9e2f

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>

> diff --git a/include/lapi/syscalls/regen.sh b/include/lapi/syscalls/regen.sh
> index 7a4f0cf44..8ac80440c 100755
> --- a/include/lapi/syscalls/regen.sh
> +++ b/include/lapi/syscalls/regen.sh
> @@ -80,7 +80,7 @@ for arch in $(cat "${srcdir}/order") ; do
>  		s390) echo "#if defined(__s390__) && !defined(__s390x__)" ;;
>  		mips_n32) echo "#if defined(__mips__) && defined(_ABIN32)" ;;
>  		mips_n64) echo "#if defined(__mips__) && defined(_ABI64)" ;;
> -		mips_o32) echo "#if defined(__mips__) && defined(_ABIO32)" ;;
> +		mips_o32) echo "#if defined(__mips__) && defined(_ABIO32) && _MIPS_SZLONG == 32" ;;
>  		*) echo "#ifdef __${arch}__" ;;
>  	esac
>  	while read line ; do

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-27 12:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210722125219.31895-1-zhanglianjie@uniontech.com>
2021-07-27 12:03 ` [LTP] [PATCH] regen.sh: Limit mips o32 system calls Petr Vorel

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox