From: Matthew Wilcox <willy@infradead.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-arch@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Make PMD_ORDER generically available
Date: Thu, 15 Jul 2021 17:38:05 +0100 [thread overview]
Message-ID: <YPBkbcmNzFKipXfC@casper.infradead.org> (raw)
In-Reply-To: <a79b8c48-fd45-01c5-e43d-66077c495941@gmx.de>
On Thu, Jul 15, 2021 at 06:28:42PM +0200, Helge Deller wrote:
> On 7/15/21 3:46 PM, Matthew Wilcox (Oracle) wrote:
> > These three architectures each define PMD_ORDER to mean "the order of
> > an allocation for a PMD table", but logically PMD_ORDER should be the
> > order of a PMD allocation, ie (PMD_SHIFT - PAGE_SHIFT) as DAX defines it.
>
> Some architectures do have PGD_ORDER, PUD_ORDER and PTE_ORDER as well.
> If you rename PMD_ORDER, IMHO the others should be renamed too.
>
> Why not simply rename "PMD_ORDER" in fs/dax.c to e.g.
> #define DAX_PMD_SHIFT (PMD_SHIFT - PAGE_SHIFT)
> and use that inside the dax filesystem code?
Because that's wrong. PMD order is clearly the order of a PMD page,
not the order of a PMD table.
I'm sure the others should also be renamed, but this is the one which
is causing me pain today.
prev parent reply other threads:[~2021-07-15 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 13:46 [PATCH 0/3] Make PMD_ORDER generically available Matthew Wilcox (Oracle)
2021-07-15 13:46 ` [PATCH 1/3] arm: Rename PMD_ORDER to PMD_TABLE_ORDER Matthew Wilcox (Oracle)
2021-07-15 16:47 ` Russell King (Oracle)
2021-07-15 18:10 ` Matthew Wilcox
2021-07-15 18:37 ` Russell King (Oracle)
2021-07-15 19:16 ` Matthew Wilcox
2021-07-15 13:46 ` [PATCH 2/3] mips: " Matthew Wilcox (Oracle)
2021-07-15 13:46 ` [PATCH 3/3] parisc: " Matthew Wilcox (Oracle)
2021-07-15 16:28 ` [PATCH 0/3] Make PMD_ORDER generically available Helge Deller
2021-07-15 16:38 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPBkbcmNzFKipXfC@casper.infradead.org \
--to=willy@infradead.org \
--cc=deller@gmx.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).