From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB32DC4338F for ; Thu, 29 Jul 2021 09:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CCE361074 for ; Thu, 29 Jul 2021 09:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234996AbhG2JEH (ORCPT ); Thu, 29 Jul 2021 05:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234972AbhG2JEG (ORCPT ); Thu, 29 Jul 2021 05:04:06 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04DDAC061757; Thu, 29 Jul 2021 02:04:03 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id y200so6133764iof.1; Thu, 29 Jul 2021 02:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=obmNjwOpYpNIrk2WRzS0fBK8P38CDDlYfyhz5quNEUc=; b=QSCmSlY8mauv1ESXdaQmS8cIJikGHlCYwi9+ErHMzezvQ6/1Vg18aHSiWFuH+JFCka 6jursxSH5n2F6Kufg9Vt44FNFSVaBIkd8LHJf2Mb7TNJo6/Q9ObBLpWdnmKbvK2snGpD lbyb1Ds8qNvipV1JMNiRItVom0e49e8pe9UfLLNyzGECrSyyaqfvne/LUG83fGdv0RC+ ppNO252CrN9W/Fg6dNFcuxxZxuvmFiqcuhp91h5O67Cw2peWBg/qfVmhMWJULk6CtiTK YRdd1k1TaGW+j/3UVx+4CBXdXqKEdmpVjmCTrFFZF95HhA0JR2FmpehD6rDB0Qho5Gtj iQ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=obmNjwOpYpNIrk2WRzS0fBK8P38CDDlYfyhz5quNEUc=; b=HnKxgU9zDoDG6RYTZ/kJCHK0KSEKIfENW3hqQ9v2/3f8Hdieepqu5MqgeUnQ3Fr/8/ VknT8kisKbazhfpk4dnAW00lwKmiBlbwCuzVyI8z5sZZ87y1kVbS9CWWIR2tRRoVtfkX UHAOem6E6bH0N93v2YxlMQ6r8HRgmYHUPC3sWslhkUBocbu3aFYlcbDdatsQNb1/Zwt1 v5nuF43FQnragXOOdDmx0qKnq56HukQpdVI99nrjWkB+0xo8UKY/nBP5kch3HikaaPWJ R48bHKnDU7Yt5wjtrYeLNs4BLBde+FV+vMKQJw7o0nyJxfSxUojKDdOY3PdvqWS7Jslm 7Sog== X-Gm-Message-State: AOAM530C36UGZKqH218VbeP1sN8HW2V/6/g0Y7n/xjwcg5G7/e1YWcXS jU+dgU1JDi7ddu/Gf8EQMoAiEm+iK88FGdP0 X-Google-Smtp-Source: ABdhPJwUcldzmoxgaOsLX3ceCtFrwbn0kXUzxzDaZtsezarSFjWMXXNi4Qy1x4yM4N49kPBLWpS5/A== X-Received: by 2002:a5d:8596:: with SMTP id f22mr3324274ioj.147.1627549442495; Thu, 29 Jul 2021 02:04:02 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id o13sm1534851ilq.58.2021.07.29.02.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 02:04:01 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 582EA27C0054; Thu, 29 Jul 2021 05:04:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 29 Jul 2021 05:04:01 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrhedugddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpedvleeigedugfegveejhfejveeuveeiteejieekvdfgjeefudehfefhgfegvdeg jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsoh hquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdeigedq udejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfihigmh gvrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jul 2021 05:03:59 -0400 (EDT) Date: Thu, 29 Jul 2021 17:03:37 +0800 From: Boqun Feng To: Rui Wang Cc: Thomas Bogendoerfer , Peter Zijlstra , Will Deacon , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, hev Subject: Re: [RFC PATCH] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive Message-ID: References: <20210729082549.144559-1-wangrui@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729082549.144559-1-wangrui@loongson.cn> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi, On Thu, Jul 29, 2021 at 04:25:49PM +0800, Rui Wang wrote: > This looks like a typo and that caused atomic64 test failed. > > Signed-off-by: Rui Wang > Signed-off-by: hev In your upcoming patches, please change this part to your real name. Here is a quote from Documentation/process/submitting-patches.rst: using your real name (sorry, no pseudonyms or anonymous contributions.) Regards, Boqun > --- > arch/mips/include/asm/atomic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h > index 95e1f7f3597f..a0b9e7c1e4fc 100644 > --- a/arch/mips/include/asm/atomic.h > +++ b/arch/mips/include/asm/atomic.h > @@ -206,7 +206,7 @@ ATOMIC_OPS(atomic64, xor, s64, ^=, xor, lld, scd) > * The function returns the old value of @v minus @i. > */ > #define ATOMIC_SIP_OP(pfx, type, op, ll, sc) \ > -static __inline__ int arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > +static __inline__ type arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > { \ > type temp, result; \ > \ > -- > 2.32.0 >